You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@arrow.apache.org by "Will Jones (Jira)" <ji...@apache.org> on 2021/12/08 17:58:00 UTC

[jira] [Commented] (ARROW-14996) [Python][Gandiva] Deprecate or hide make_projector and make_filter testing utilities

    [ https://issues.apache.org/jira/browse/ARROW-14996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17455909#comment-17455909 ] 

Will Jones commented on ARROW-14996:
------------------------------------

I thought these are an essential part of the API. The {{Filter}} and {{Projector}} classes both explicitly say to use these function to construct their respective objects. 

https://github.com/apache/arrow/blob/d3bf0f6560dce414c8baea0c473b6f7eba1ef070/python/pyarrow/gandiva.pyx#L220

> [Python][Gandiva] Deprecate or hide make_projector and make_filter testing utilities
> ------------------------------------------------------------------------------------
>
>                 Key: ARROW-14996
>                 URL: https://issues.apache.org/jira/browse/ARROW-14996
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: Python
>            Reporter: Krisztian Szucs
>            Priority: Major
>
> {{pyarrow.gandiva.{make_filter, make_projector}}} functions are only used from gandiva unittests. Additionally unexpected arguments can cause segmentations faults. We either should deprecate or hide these functions from the public API.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)