[GitHub] [helix] rahulrane50 commented on a diff in pull request #2495: Add recursive persist listener API in ZkClient and test native ZK - API only

["rahulrane50 (via GitHub)" <gi...@apache.org>]

rahulrane50 commented on code in PR #2495:
URL: https://github.com/apache/helix/pull/2495#discussion_r1204650655


##########
zookeeper-api/src/main/java/org/apache/helix/zookeeper/zkclient/ZkClient.java:
##########
@@ -326,16 +329,33 @@ public boolean subscribeDataChanges(String path, IZkDataListener listener, boole
     return true;
   }
 
-   /**
-    * Subscribe the path and the listener will handle data events of the path
-    * WARNING: if the path is created after deletion, users need to re-subscribe the path
-    * @param path The zookeeper path
-    * @param listener Instance of {@link IZkDataListener}
-    */
+  /**
+   * Subscribe the path and the listener will handle data events of the path
+   * WARNING: if the path is created after deletion, users need to re-subscribe the path
+   * @param path The zookeeper path
+   * @param listener Instance of {@link IZkDataListener}
+   */
   public void subscribeDataChanges(String path, IZkDataListener listener) {
     subscribeDataChanges(path, listener, false);
   }
 
+  /**
+   * Subscribe RecursivePersistListener for a particular path. User can only subscribe when
+   * `_usePersistWatcher` is set to true and there is no pre-existing watcher on the path.
+   */
+  // TODO: Add impl and remove exception
+  public boolean subscribePersistRecursiveWatcher(String path,

Review Comment:
   nit. subscribePersistRecursiveWatcher --> subscribePersistentRecursiveWatcher?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org