[GitHub] [guacamole-client] mike-jumper commented on a diff in pull request #834: GUACAMOLE-1769: Handle case that KSM's getCustom() returns null.

["mike-jumper (via GitHub)" <gi...@apache.org>]

mike-jumper commented on code in PR #834:
URL: https://github.com/apache/guacamole-client/pull/834#discussion_r1166007293


##########
extensions/guacamole-vault/modules/guacamole-vault-ksm/src/main/java/org/apache/guacamole/vault/ksm/secret/KsmRecordService.java:
##########
@@ -229,6 +231,10 @@ private <T> String getSingleStringValue(List<T> values, Function<T, String> mapp
     private <T extends KeeperRecordField> T getField(List<KeeperRecordField> fields,
             Class<T> fieldClass, Pattern labelPattern) {
 
+        // There are no fields if no List was provided at all
+        if (fields == null)

Review Comment:
   I'm actually surprised the compiler didn't catch this, as `getCustom()` is annotated with `@Nullable`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org