You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "tustvold (via GitHub)" <gi...@apache.org> on 2023/06/09 12:58:13 UTC

[GitHub] [arrow-rs] tustvold opened a new pull request, #4391: Cleanup downcast macros

tustvold opened a new pull request, #4391:
URL: https://github.com/apache/arrow-rs/pull/4391

   # Which issue does this PR close?
   
   <!--
   We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
   -->
   
   Closes #.
   
   # Rationale for this change
    
   <!--
   Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
   Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
   -->
   
   The downcast macros contained the pattern `$($p:pat),+` which they would then reproduce as `($($p),+)`. The intent was to match patterns like `(a, b)`, however, this is redundant as this is also matched by `$p:pat`. This redundancy would result in cases where the macro resolver would match `(a, b)` as a single repetition, which would then get reproduced as `((a, b))` which the compiler would then complain about
   
   # What changes are included in this PR?
   
   <!--
   There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
   -->
   
   Simplifies the macros to not attempt to destructure the fallback patterns.
   
   # Are there any user-facing changes?
   
   
   <!--
   If there are user-facing changes then we may require documentation to be updated before approving the PR.
   -->
   
   <!---
   If there are any breaking changes to public APIs, please add the `breaking change` label.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-rs] alamb commented on a diff in pull request #4391: Cleanup downcast macros

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #4391:
URL: https://github.com/apache/arrow-rs/pull/4391#discussion_r1224301361


##########
arrow-array/src/cast.rs:
##########
@@ -577,7 +577,7 @@ macro_rules! downcast_run_array {
 }
 
 /// Force downcast of an [`Array`], such as an [`ArrayRef`] to
-/// [`GenericListArray<T>`], panic'ing on failure.
+/// [`GenericListArray<T>`], panicking on failure.

Review Comment:
   Past (present in this case) participle strikes again
   
   This is consistent with the Rust terminology so 👍 
   
   https://doc.rust-lang.org/std/thread/fn.panicking.html



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-rs] tustvold commented on a diff in pull request #4391: Cleanup downcast macros

Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on code in PR #4391:
URL: https://github.com/apache/arrow-rs/pull/4391#discussion_r1224270730


##########
arrow-array/src/cast.rs:
##########
@@ -237,16 +237,16 @@ macro_rules! downcast_temporal_array {
     ($values:ident => $e:expr, $($p:pat => $fallback:expr $(,)*)*) => {
         $crate::downcast_temporal_array!($values => {$e} $($p => $fallback)*)
     };
-    (($($values:ident),+) => $e:block $($($p:pat),+ => $fallback:expr $(,)*)*) => {
-        $crate::downcast_temporal_array!($($values),+ => $e $($($p),+ => $fallback)*)
+    (($($values:ident),+) => $e:expr, $($p:pat => $fallback:expr $(,)*)*) => {

Review Comment:
   This is a new variant to allow
   
   ```
   downcast_primitive_array! {
       (a, b) => expr,
   }
   ```
   
   As opposed to just
   
   ```
   downcast_primitive_array! {
       (a, b) =>  {
           block
       }
   }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-rs] tustvold merged pull request #4391: Cleanup downcast macros

Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold merged PR #4391:
URL: https://github.com/apache/arrow-rs/pull/4391


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-rs] alamb commented on a diff in pull request #4391: Cleanup downcast macros

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #4391:
URL: https://github.com/apache/arrow-rs/pull/4391#discussion_r1224301361


##########
arrow-array/src/cast.rs:
##########
@@ -577,7 +577,7 @@ macro_rules! downcast_run_array {
 }
 
 /// Force downcast of an [`Array`], such as an [`ArrayRef`] to
-/// [`GenericListArray<T>`], panic'ing on failure.
+/// [`GenericListArray<T>`], panicking on failure.

Review Comment:
   Past participle strikes again
   
   This is consistent with the Rust terminology so 👍 
   
   https://doc.rust-lang.org/std/thread/fn.panicking.html



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-rs] tustvold commented on a diff in pull request #4391: Cleanup downcast macros

Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on code in PR #4391:
URL: https://github.com/apache/arrow-rs/pull/4391#discussion_r1224269957


##########
arrow-array/src/cast.rs:
##########
@@ -237,16 +237,16 @@ macro_rules! downcast_temporal_array {
     ($values:ident => $e:expr, $($p:pat => $fallback:expr $(,)*)*) => {
         $crate::downcast_temporal_array!($values => {$e} $($p => $fallback)*)
     };
-    (($($values:ident),+) => $e:block $($($p:pat),+ => $fallback:expr $(,)*)*) => {

Review Comment:
   This variant is redundant and can be removed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org