You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@serf.apache.org by Denis Kovalchuk <de...@visualsvn.com.INVALID> on 2022/06/27 14:45:26 UTC

[PATCH] Properly handle unknown ctrl requests in bio implementation

Hello!

I noticed that serf bio implementation does not properly handle unknown ctrl
requests by returning 1 instead of 0. According to the documentation [1],
the implementation is expected to return 0 for unknown ctrls.

This issue has been discussed in SERF-198 [2]. I would like to propose an
updated and extended patch to solve the issue.

The patch includes:
- The fix for the bio_bucket_ctrl() function.
- Similar fix for the new bio_file_ctrl() function.
- Similar fix for the bio_apr_socket_ctrl() function in the MockHTTP server.

[1] https://www.openssl.org/docs/manmaster/man3/BIO_ctrl.html#NOTES
[2] https://issues.apache.org/jira/browse/SERF-198

Kind Regards,
Denis Kovalchuk

Re: [PATCH] Properly handle unknown ctrl requests in bio implementation

Posted by Evgeny Kotkov <ev...@visualsvn.com.INVALID>.

Denis Kovalchuk <de...@visualsvn.com> writes:

> I noticed that serf bio implementation does not properly handle unknown ctrl
> requests by returning 1 instead of 0. According to the documentation [1],
> the implementation is expected to return 0 for unknown ctrls.
>
> This issue has been discussed in SERF-198 [2]. I would like to propose an
> updated and extended patch to solve the issue.
>
> The patch includes:
> - The fix for the bio_bucket_ctrl() function.
> - Similar fix for the new bio_file_ctrl() function.
> - Similar fix for the bio_apr_socket_ctrl() function in the MockHTTP server.

Committed in https://svn.apache.org/r1902304


Thanks,
Evgeny Kotkov