You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/07/26 05:19:26 UTC

[GitHub] [airflow] uranusjr commented on pull request #25293: Fix legacy Airflow SqlSensor rejecting common.sql providers

uranusjr commented on PR #25293:
URL: https://github.com/apache/airflow/pull/25293#issuecomment-1195015154

   Maybe instead of importing the deprecated base class, we should do different things depending on Airflow version:
   
   1. If running on Airflow < 2.3, import the legacy base class.
   2. In Airflow 2.3+, we add additional logic in `BaseSQLOperator` to also accept hooks inheriting the new base class.
   
   This would avoid needing the `filterwarning` block, which feels like a hack to me.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org