You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2022/09/29 14:20:18 UTC
[GitHub] [yunikorn-k8shim] codecov[bot] commented on pull request #467: [YUNIKORN-1338] [admission] support different kind of workloads other than pods
codecov[bot] commented on PR #467:
URL: https://github.com/apache/yunikorn-k8shim/pull/467#issuecomment-1262355390
# [Codecov](https://codecov.io/gh/apache/yunikorn-k8shim/pull/467?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#467](https://codecov.io/gh/apache/yunikorn-k8shim/pull/467?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c835f54) into [master](https://codecov.io/gh/apache/yunikorn-k8shim/commit/244a28f3175b5d4a1c314aa621a45cc9010bca4a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (244a28f) will **increase** coverage by `0.74%`.
> The diff coverage is `83.33%`.
```diff
@@ Coverage Diff @@
## master #467 +/- ##
==========================================
+ Coverage 67.00% 67.74% +0.74%
==========================================
Files 41 43 +2
Lines 6767 6960 +193
==========================================
+ Hits 4534 4715 +181
- Misses 2062 2068 +6
- Partials 171 177 +6
```
| [Impacted Files](https://codecov.io/gh/apache/yunikorn-k8shim/pull/467?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...g/plugin/admissioncontrollers/webhook/workloads.go](https://codecov.io/gh/apache/yunikorn-k8shim/pull/467/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3BsdWdpbi9hZG1pc3Npb25jb250cm9sbGVycy93ZWJob29rL3dvcmtsb2Fkcy5nbw==) | `63.26% <63.26%> (ø)` | |
| [...missioncontrollers/webhook/admission\_controller.go](https://codecov.io/gh/apache/yunikorn-k8shim/pull/467/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3BsdWdpbi9hZG1pc3Npb25jb250cm9sbGVycy93ZWJob29rL2FkbWlzc2lvbl9jb250cm9sbGVyLmdv) | `67.07% <78.26%> (+2.89%)` | :arrow_up: |
| [pkg/plugin/admissioncontrollers/webhook/webhook.go](https://codecov.io/gh/apache/yunikorn-k8shim/pull/467/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3BsdWdpbi9hZG1pc3Npb25jb250cm9sbGVycy93ZWJob29rL3dlYmhvb2suZ28=) | `40.00% <93.15%> (+40.00%)` | :arrow_up: |
| [...g/plugin/admissioncontrollers/webhook/usergroup.go](https://codecov.io/gh/apache/yunikorn-k8shim/pull/467/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3BsdWdpbi9hZG1pc3Npb25jb250cm9sbGVycy93ZWJob29rL3VzZXJncm91cC5nbw==) | `100.00% <100.00%> (ø)` | |
| [pkg/dispatcher/dispatcher.go](https://codecov.io/gh/apache/yunikorn-k8shim/pull/467/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2Rpc3BhdGNoZXIvZGlzcGF0Y2hlci5nbw==) | `74.82% <0.00%> (-1.40%)` | :arrow_down: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org