You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/01/27 06:52:35 UTC

[GitHub] [apisix-website] KishaniKandasamy opened a new pull request #160: fix: adjust images' dimension

KishaniKandasamy opened a new pull request #160:
URL: https://github.com/apache/apisix-website/pull/160


   Fixes: #158
   
   Changes:
   I've updated customTheme.css
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] KishaniKandasamy commented on a change in pull request #160: fix: adjust images' dimension

Posted by GitBox <gi...@apache.org>.
KishaniKandasamy commented on a change in pull request #160:
URL: https://github.com/apache/apisix-website/pull/160#discussion_r565156123



##########
File path: website/src/css/customTheme.css
##########
@@ -8,10 +8,6 @@
   --ifm-color-primary-darker: #9a2521;
   --ifm-color-shadow--lw: #7f1e1b;
 }
-.navbar {
-  background: var(--ifm-color-primary);
-  color: var(--ifm-color-primary-lightest);
-}

Review comment:
       When we change the default  text color of the navigation bar to be #fff ..we also need to add hover and active selector to it IMHO :)
   ![Screenshot (67)](https://user-images.githubusercontent.com/53715187/105971319-64684e00-60b0-11eb-955d-b6874f6a350e.png)
   
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] guoqqqi commented on a change in pull request #160: fix: adjust images' dimension

Posted by GitBox <gi...@apache.org>.
guoqqqi commented on a change in pull request #160:
URL: https://github.com/apache/apisix-website/pull/160#discussion_r565089939



##########
File path: website/src/css/customTheme.css
##########
@@ -8,10 +8,6 @@
   --ifm-color-primary-darker: #9a2521;
   --ifm-color-shadow--lw: #7f1e1b;
 }
-.navbar {
-  background: var(--ifm-color-primary);
-  color: var(--ifm-color-primary-lightest);
-}

Review comment:
       Sorry, we want the text color of the navigation bar to be #fff, like this
   `.navbar a {
     color: #fff;
   }`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] guoqqqi commented on a change in pull request #160: fix: adjust images' dimension

Posted by GitBox <gi...@apache.org>.
guoqqqi commented on a change in pull request #160:
URL: https://github.com/apache/apisix-website/pull/160#discussion_r565089939



##########
File path: website/src/css/customTheme.css
##########
@@ -8,10 +8,6 @@
   --ifm-color-primary-darker: #9a2521;
   --ifm-color-shadow--lw: #7f1e1b;
 }
-.navbar {
-  background: var(--ifm-color-primary);
-  color: var(--ifm-color-primary-lightest);
-}

Review comment:
       we would prefer the text color of the navigation bar to be #fff, like this
   
   ```css
   .navbar a {
     color: #fff;
   }
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] juzhiyuan commented on pull request #160: fix: adjust images' dimension

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #160:
URL: https://github.com/apache/apisix-website/pull/160#issuecomment-768075802


   @guoqqqi Please review when you have time.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] juzhiyuan commented on pull request #160: fix: adjust images' dimension

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #160:
URL: https://github.com/apache/apisix-website/pull/160#issuecomment-774120762


   Hi, @KishaniKandasamy, I just fixed the auto deployed issue, we could continue working on this one :)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] LiteSun commented on pull request #160: fix: adjust images' dimension

Posted by GitBox <gi...@apache.org>.
LiteSun commented on pull request #160:
URL: https://github.com/apache/apisix-website/pull/160#issuecomment-772983146


   any update? 😊


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] guoqqqi commented on a change in pull request #160: fix: adjust images' dimension

Posted by GitBox <gi...@apache.org>.
guoqqqi commented on a change in pull request #160:
URL: https://github.com/apache/apisix-website/pull/160#discussion_r565091046



##########
File path: website/src/css/customTheme.css
##########
@@ -8,10 +8,6 @@
   --ifm-color-primary-darker: #9a2521;
   --ifm-color-shadow--lw: #7f1e1b;
 }
-.navbar {
-  background: var(--ifm-color-primary);
-  color: var(--ifm-color-primary-lightest);
-}

Review comment:
       It is my fault for not expressing clearly, thank you for your help～




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] KishaniKandasamy commented on a change in pull request #160: fix: adjust images' dimension

Posted by GitBox <gi...@apache.org>.
KishaniKandasamy commented on a change in pull request #160:
URL: https://github.com/apache/apisix-website/pull/160#discussion_r565134026



##########
File path: website/src/css/customTheme.css
##########
@@ -8,10 +8,6 @@
   --ifm-color-primary-darker: #9a2521;
   --ifm-color-shadow--lw: #7f1e1b;
 }
-.navbar {
-  background: var(--ifm-color-primary);
-  color: var(--ifm-color-primary-lightest);
-}

Review comment:
       > we would prefer the text color of the navigation bar to be #fff, like this
   > 
   > ```css
   > .navbar a {
   >   color: #fff;
   > }
   > ```
   
   Yesss but here  nav bar style was already set to primary style(in docusaurus.config.js) so I thought we could remove  these lines from  css :)
   .navbar {
     background: var(--ifm-color-primary);
     color: var(--ifm-color-primary-lightest);
   }




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] KishaniKandasamy closed pull request #160: fix: adjust images' dimension

Posted by GitBox <gi...@apache.org>.
KishaniKandasamy closed pull request #160:
URL: https://github.com/apache/apisix-website/pull/160


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] juzhiyuan commented on a change in pull request #160: fix: adjust images' dimension

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #160:
URL: https://github.com/apache/apisix-website/pull/160#discussion_r565483888



##########
File path: website/src/css/customTheme.css
##########
@@ -8,10 +8,6 @@
   --ifm-color-primary-darker: #9a2521;
   --ifm-color-shadow--lw: #7f1e1b;
 }
-.navbar {
-  background: var(--ifm-color-primary);
-  color: var(--ifm-color-primary-lightest);
-}

Review comment:
       Yep, we'd better support Hover haha 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org