You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "mistercrunch (via GitHub)" <gi...@apache.org> on 2024/02/15 06:35:05 UTC
[PR] feat: faster docker builds [superset]
mistercrunch opened a new pull request, #27122:
URL: https://github.com/apache/superset/pull/27122
### SUMMARY
trying to optimize the docker builds a little
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat: faster docker builds [superset]
Posted by "mistercrunch (via GitHub)" <gi...@apache.org>.
mistercrunch commented on code in PR #27122:
URL: https://github.com/apache/superset/pull/27122#discussion_r1490491070
##########
Dockerfile:
##########
@@ -61,9 +74,7 @@ ENV LANG=C.UTF-8 \
SUPERSET_HOME="/app/superset_home" \
SUPERSET_PORT=8088
-RUN mkdir -p ${PYTHONPATH} superset/static superset-frontend apache_superset.egg-info requirements \
- && useradd --user-group -d ${SUPERSET_HOME} -m --no-log-init --shell /bin/bash superset \
Review Comment:
Here I'm thinking some of the commands (maybe useradd?) may trigger the apt-get stuff to not use the cache at times. I see a lot of builds re-running `apt-get` when nothing here should have changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat: faster docker builds [superset]
Posted by "mistercrunch (via GitHub)" <gi...@apache.org>.
mistercrunch closed pull request #27122: feat: faster docker builds
URL: https://github.com/apache/superset/pull/27122
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat: faster docker builds [superset]
Posted by "mistercrunch (via GitHub)" <gi...@apache.org>.
mistercrunch commented on code in PR #27122:
URL: https://github.com/apache/superset/pull/27122#discussion_r1490540121
##########
Dockerfile:
##########
@@ -47,11 +47,24 @@ COPY ./superset-frontend ./
# This seems to be the most expensive step
RUN npm run ${BUILD_CMD}
+######################################################################
+# Python pre-lean image
Review Comment:
Other options:
- have the release manager bump both `setup.py` and `package.json`, have a CI / build-step that checks that they have been bumped
- have some other mechanism to store the version that get pushed into package.json?
- use a `package.js` insetad of a package.json, that dynamically read some sort of version.txt
I figure this target (pre_lean) could be useful as a place to prepare/cache more python-related stuff eventually. Install more stuff here and COPY into lean
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat: faster docker builds [superset]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #27122:
URL: https://github.com/apache/superset/pull/27122#issuecomment-1945464091
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/27122?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Comparison is base [(`3224ac1`)](https://app.codecov.io/gh/apache/superset/commit/3224ac18185f7e8f6e7ce09898ce07620b86977d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 69.49% compared to head [(`89b7dd1`)](https://app.codecov.io/gh/apache/superset/pull/27122?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 67.17%.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #27122 +/- ##
==========================================
- Coverage 69.49% 67.17% -2.33%
==========================================
Files 1901 1901
Lines 74449 74449
Branches 8300 8300
==========================================
- Hits 51740 50010 -1730
- Misses 20655 22385 +1730
Partials 2054 2054
```
| [Flag](https://app.codecov.io/gh/apache/superset/pull/27122/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hive](https://app.codecov.io/gh/apache/superset/pull/27122/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [mysql](https://app.codecov.io/gh/apache/superset/pull/27122/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `78.00% <ø> (ø)` | |
| [postgres](https://app.codecov.io/gh/apache/superset/pull/27122/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `78.12% <ø> (ø)` | |
| [presto](https://app.codecov.io/gh/apache/superset/pull/27122/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [python](https://app.codecov.io/gh/apache/superset/pull/27122/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `78.26% <ø> (-4.83%)` | :arrow_down: |
| [sqlite](https://app.codecov.io/gh/apache/superset/pull/27122/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `77.64% <ø> (ø)` | |
| [unit](https://app.codecov.io/gh/apache/superset/pull/27122/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/superset/pull/27122?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat: faster docker builds [superset]
Posted by "mistercrunch (via GitHub)" <gi...@apache.org>.
mistercrunch commented on code in PR #27122:
URL: https://github.com/apache/superset/pull/27122#discussion_r1490491070
##########
Dockerfile:
##########
@@ -61,9 +74,7 @@ ENV LANG=C.UTF-8 \
SUPERSET_HOME="/app/superset_home" \
SUPERSET_PORT=8088
-RUN mkdir -p ${PYTHONPATH} superset/static superset-frontend apache_superset.egg-info requirements \
- && useradd --user-group -d ${SUPERSET_HOME} -m --no-log-init --shell /bin/bash superset \
Review Comment:
Here I'm thinking some of the funky commands may trigger the apt-get stuff to not use the cache at times. I see a lot of builds re-running `apt-get` when nothing here should have changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org