You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Andrew Onischuk <ao...@hortonworks.com> on 2017/03/23 13:48:30 UTC
Review Request 57875: In case of IBM Power,
test_CompressionTool[lzo] fails with 'lzo.GPLNativeCodeLoader: Could not
load native gpl library'
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57875/
-----------------------------------------------------------
Review request for Ambari and Vitalyi Brodetskyi.
Bugs: AMBARI-20543
https://issues.apache.org/jira/browse/AMBARI-20543
Repository: ambari
Description
-------
Diffs
-----
ambari-server/src/main/resources/stacks/HDP/2.2/services/HDFS/configuration/hadoop-env.xml 5be2b74
ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/configuration/hadoop-env.xml b6c3738
ambari-server/src/main/resources/stacks/HDP/2.4/services/HDFS/configuration/hadoop-env.xml 24e0193
ambari-server/src/main/resources/stacks/HDP/2.6/services/HDFS/configuration/hadoop-env.xml 768ca82
Diff: https://reviews.apache.org/r/57875/diff/1/
Testing
-------
mvn clean test
Thanks,
Andrew Onischuk
Re: Review Request 57875: In case of IBM Power,
test_CompressionTool[lzo] fails with 'lzo.GPLNativeCodeLoader: Could not
load native gpl library'
Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57875/#review170642
-----------------------------------------------------------
Ship it!
Ship It!
- Sumit Mohanty
On March 30, 2017, 9:10 p.m., Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57875/
> -----------------------------------------------------------
>
> (Updated March 30, 2017, 9:10 p.m.)
>
>
> Review request for Ambari and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-20543
> https://issues.apache.org/jira/browse/AMBARI-20543
>
>
> Repository: ambari
>
>
> Description
> -------
>
> .
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/configuration/hadoop-env.xml 89d5001
> ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/configuration/tez-site.xml d7031e1
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/configuration-mapred/mapred-site.xml bda7bcb
> ambari-server/src/main/resources/stacks/HDP/2.2/services/HDFS/configuration/hadoop-env.xml f5da323
> ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/configuration/hadoop-env.xml d9101c6
> ambari-server/src/main/resources/stacks/HDP/2.4/services/HDFS/configuration/hadoop-env.xml d95460b
> ambari-server/src/main/resources/stacks/HDP/2.6/services/HDFS/configuration/hadoop-env.xml 491c01f
>
>
> Diff: https://reviews.apache.org/r/57875/diff/2/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>
Re: Review Request 57875: In case of IBM Power,
test_CompressionTool[lzo] fails with 'lzo.GPLNativeCodeLoader: Could not
load native gpl library'
Posted by Andrew Onischuk <ao...@hortonworks.com>.
> On March 30, 2017, 9:26 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/configuration/hadoop-env.xml
> > Line 371 (original), 371 (patched)
> > <https://reviews.apache.org/r/57875/diff/2/?file=1681192#file1681192line371>
> >
> > Should not hardcode /usr/hdp inside common-services
> > Consider using a variable like {{stack_root}}
Sure fixing in a separate jira for 2.5.1
> On March 30, 2017, 9:26 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/configuration/tez-site.xml
> > Line 177 (original), 177 (patched)
> > <https://reviews.apache.org/r/57875/diff/2/?file=1681193#file1681193line177>
> >
> > Same comment, and in other locations.
same.
- Andrew
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57875/#review170645
-----------------------------------------------------------
On March 30, 2017, 9:10 p.m., Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57875/
> -----------------------------------------------------------
>
> (Updated March 30, 2017, 9:10 p.m.)
>
>
> Review request for Ambari and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-20543
> https://issues.apache.org/jira/browse/AMBARI-20543
>
>
> Repository: ambari
>
>
> Description
> -------
>
> .
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/configuration/hadoop-env.xml 89d5001
> ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/configuration/tez-site.xml d7031e1
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/configuration-mapred/mapred-site.xml bda7bcb
> ambari-server/src/main/resources/stacks/HDP/2.2/services/HDFS/configuration/hadoop-env.xml f5da323
> ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/configuration/hadoop-env.xml d9101c6
> ambari-server/src/main/resources/stacks/HDP/2.4/services/HDFS/configuration/hadoop-env.xml d95460b
> ambari-server/src/main/resources/stacks/HDP/2.6/services/HDFS/configuration/hadoop-env.xml 491c01f
>
>
> Diff: https://reviews.apache.org/r/57875/diff/2/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>
Re: Review Request 57875: In case of IBM Power,
test_CompressionTool[lzo] fails with 'lzo.GPLNativeCodeLoader: Could not
load native gpl library'
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57875/#review170645
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/configuration/hadoop-env.xml
Line 371 (original), 371 (patched)
<https://reviews.apache.org/r/57875/#comment243526>
Should not hardcode /usr/hdp inside common-services
Consider using a variable like {{stack_root}}
ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/configuration/tez-site.xml
Line 177 (original), 177 (patched)
<https://reviews.apache.org/r/57875/#comment243527>
Same comment, and in other locations.
- Alejandro Fernandez
On March 30, 2017, 9:10 p.m., Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57875/
> -----------------------------------------------------------
>
> (Updated March 30, 2017, 9:10 p.m.)
>
>
> Review request for Ambari and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-20543
> https://issues.apache.org/jira/browse/AMBARI-20543
>
>
> Repository: ambari
>
>
> Description
> -------
>
> .
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/configuration/hadoop-env.xml 89d5001
> ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/configuration/tez-site.xml d7031e1
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/configuration-mapred/mapred-site.xml bda7bcb
> ambari-server/src/main/resources/stacks/HDP/2.2/services/HDFS/configuration/hadoop-env.xml f5da323
> ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/configuration/hadoop-env.xml d9101c6
> ambari-server/src/main/resources/stacks/HDP/2.4/services/HDFS/configuration/hadoop-env.xml d95460b
> ambari-server/src/main/resources/stacks/HDP/2.6/services/HDFS/configuration/hadoop-env.xml 491c01f
>
>
> Diff: https://reviews.apache.org/r/57875/diff/2/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>
Re: Review Request 57875: In case of IBM Power,
test_CompressionTool[lzo] fails with 'lzo.GPLNativeCodeLoader: Could not
load native gpl library'
Posted by Mahadev Konar <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57875/#review170643
-----------------------------------------------------------
Ship it!
Ship It!
- Mahadev Konar
On March 30, 2017, 9:10 p.m., Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57875/
> -----------------------------------------------------------
>
> (Updated March 30, 2017, 9:10 p.m.)
>
>
> Review request for Ambari and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-20543
> https://issues.apache.org/jira/browse/AMBARI-20543
>
>
> Repository: ambari
>
>
> Description
> -------
>
> .
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/configuration/hadoop-env.xml 89d5001
> ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/configuration/tez-site.xml d7031e1
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/configuration-mapred/mapred-site.xml bda7bcb
> ambari-server/src/main/resources/stacks/HDP/2.2/services/HDFS/configuration/hadoop-env.xml f5da323
> ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/configuration/hadoop-env.xml d9101c6
> ambari-server/src/main/resources/stacks/HDP/2.4/services/HDFS/configuration/hadoop-env.xml d95460b
> ambari-server/src/main/resources/stacks/HDP/2.6/services/HDFS/configuration/hadoop-env.xml 491c01f
>
>
> Diff: https://reviews.apache.org/r/57875/diff/2/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>
Re: Review Request 57875: In case of IBM Power,
test_CompressionTool[lzo] fails with 'lzo.GPLNativeCodeLoader: Could not
load native gpl library'
Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57875/
-----------------------------------------------------------
(Updated March 30, 2017, 9:10 p.m.)
Review request for Ambari and Vitalyi Brodetskyi.
Bugs: AMBARI-20543
https://issues.apache.org/jira/browse/AMBARI-20543
Repository: ambari
Description (updated)
-------
.
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/configuration/hadoop-env.xml 89d5001
ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/configuration/tez-site.xml d7031e1
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/configuration-mapred/mapred-site.xml bda7bcb
ambari-server/src/main/resources/stacks/HDP/2.2/services/HDFS/configuration/hadoop-env.xml f5da323
ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/configuration/hadoop-env.xml d9101c6
ambari-server/src/main/resources/stacks/HDP/2.4/services/HDFS/configuration/hadoop-env.xml d95460b
ambari-server/src/main/resources/stacks/HDP/2.6/services/HDFS/configuration/hadoop-env.xml 491c01f
Diff: https://reviews.apache.org/r/57875/diff/2/
Changes: https://reviews.apache.org/r/57875/diff/1-2/
Testing
-------
mvn clean test
Thanks,
Andrew Onischuk
Re: Review Request 57875: In case of IBM Power,
test_CompressionTool[lzo] fails with 'lzo.GPLNativeCodeLoader: Could not
load native gpl library'
Posted by Andrew Onischuk <ao...@hortonworks.com>.
> On March 23, 2017, 4:41 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.6/services/HDFS/configuration/hadoop-env.xml
> > Line 146 (original), 146 (patched)
> > <https://reviews.apache.org/r/57875/diff/1/?file=1672629#file1672629line146>
> >
> > Why isn't this in HDFS in common-services?
> > If it will not be added to that, it should still belong in HDFS in HDP 3.0
It is already in common-services and in 3.0.
However I see that in 3.0 the path doesn't contain architecture substition. Add it as an additional commit, since the patch is already committed. Thanks for finding it.
- Andrew
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57875/#review169890
-----------------------------------------------------------
On March 23, 2017, 1:48 p.m., Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57875/
> -----------------------------------------------------------
>
> (Updated March 23, 2017, 1:48 p.m.)
>
>
> Review request for Ambari and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-20543
> https://issues.apache.org/jira/browse/AMBARI-20543
>
>
> Repository: ambari
>
>
> Description
> -------
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDP/2.2/services/HDFS/configuration/hadoop-env.xml 5be2b74
> ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/configuration/hadoop-env.xml b6c3738
> ambari-server/src/main/resources/stacks/HDP/2.4/services/HDFS/configuration/hadoop-env.xml 24e0193
> ambari-server/src/main/resources/stacks/HDP/2.6/services/HDFS/configuration/hadoop-env.xml 768ca82
>
>
> Diff: https://reviews.apache.org/r/57875/diff/1/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>
Re: Review Request 57875: In case of IBM Power,
test_CompressionTool[lzo] fails with 'lzo.GPLNativeCodeLoader: Could not
load native gpl library'
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57875/#review169890
-----------------------------------------------------------
ambari-server/src/main/resources/stacks/HDP/2.6/services/HDFS/configuration/hadoop-env.xml
Line 146 (original), 146 (patched)
<https://reviews.apache.org/r/57875/#comment242592>
Why isn't this in HDFS in common-services?
If it will not be added to that, it should still belong in HDFS in HDP 3.0
- Alejandro Fernandez
On March 23, 2017, 1:48 p.m., Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57875/
> -----------------------------------------------------------
>
> (Updated March 23, 2017, 1:48 p.m.)
>
>
> Review request for Ambari and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-20543
> https://issues.apache.org/jira/browse/AMBARI-20543
>
>
> Repository: ambari
>
>
> Description
> -------
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDP/2.2/services/HDFS/configuration/hadoop-env.xml 5be2b74
> ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/configuration/hadoop-env.xml b6c3738
> ambari-server/src/main/resources/stacks/HDP/2.4/services/HDFS/configuration/hadoop-env.xml 24e0193
> ambari-server/src/main/resources/stacks/HDP/2.6/services/HDFS/configuration/hadoop-env.xml 768ca82
>
>
> Diff: https://reviews.apache.org/r/57875/diff/1/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>
Re: Review Request 57875: In case of IBM Power,
test_CompressionTool[lzo] fails with 'lzo.GPLNativeCodeLoader: Could not
load native gpl library'
Posted by Eugene Chekanskiy <ec...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57875/#review169868
-----------------------------------------------------------
Ship it!
Ship It!
- Eugene Chekanskiy
On March 23, 2017, 1:48 p.m., Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57875/
> -----------------------------------------------------------
>
> (Updated March 23, 2017, 1:48 p.m.)
>
>
> Review request for Ambari and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-20543
> https://issues.apache.org/jira/browse/AMBARI-20543
>
>
> Repository: ambari
>
>
> Description
> -------
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDP/2.2/services/HDFS/configuration/hadoop-env.xml 5be2b74
> ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/configuration/hadoop-env.xml b6c3738
> ambari-server/src/main/resources/stacks/HDP/2.4/services/HDFS/configuration/hadoop-env.xml 24e0193
> ambari-server/src/main/resources/stacks/HDP/2.6/services/HDFS/configuration/hadoop-env.xml 768ca82
>
>
> Diff: https://reviews.apache.org/r/57875/diff/1/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>