You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/02/07 04:05:39 UTC
[jira] [Commented] (CB-10553) Framework tag in plugin.xml not
handled during plugin-install on Android
[ https://issues.apache.org/jira/browse/CB-10553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15136116#comment-15136116 ]
ASF GitHub Bot commented on CB-10553:
-------------------------------------
GitHub user ktop opened a pull request:
https://github.com/apache/cordova-lib/pull/380
CB-10553 Fix framework tag handler for Android
The framework tag was not being handled during plugin-install for Android. In the conditional check, it checks for the string literal 'platform' instead of just the platform.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ktop/cordova-lib cb-10553
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/380.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #380
----
commit 8cd2c9a60397393a3d49e93995fe68c3c9d58704
Author: Karen Tran <kt...@gmail.com>
Date: 2016-02-07T03:01:58Z
CB-10553 Fix framework tag handler for Android
----
> Framework tag in plugin.xml not handled during plugin-install on Android
> ------------------------------------------------------------------------
>
> Key: CB-10553
> URL: https://issues.apache.org/jira/browse/CB-10553
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaLib
> Affects Versions: Master
> Environment: Android
> Reporter: Karen Tran
> Labels: android, framework, plugin
> Fix For: Master
>
>
> On the Android platform, the framework tag is not being handled during plugin-install. It only runs during build time.
> Recreate:
> cordova create myApp
> cd myApp
> cordova platform add android
> cordova plugin add cordova-plugin-okhttp
> okhttp plugin has a framework tag in it's plugin.xml. If you go check build.gradle after adding the plugin, you'll see the framework tag didn't add a dependency to build.gradle that it was supposed to.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org