You are viewing a plain text version of this content. The canonical link for it is here.
Posted to bugs@httpd.apache.org by bu...@apache.org on 2008/05/12 17:09:01 UTC
DO NOT REPLY [Bug 44974] New: mod_request build
https://issues.apache.org/bugzilla/show_bug.cgi?id=44974
Summary: mod_request build
Product: Apache httpd-2
Version: 2.3-HEAD
Platform: PC
OS/Version: Windows 2000
Status: NEW
Keywords: PatchAvailable
Severity: normal
Priority: P2
Component: Build
AssignedTo: bugs@httpd.apache.org
ReportedBy: Tom.Donovan@acm.org
Created an attachment (id=21949)
--> (https://issues.apache.org/bugzilla/attachment.cgi?id=21949)
Patch for mod_filter.c, mod_request.c, mod_request.h
Several additional changes are needed to make mod_request build correctly on
all platforms:
1. Only the module symbol "request_module" should be exported, all other
symbols should be private.
2. Other modules may include mod_request.h to access the optional functions, so
it must not contain a module declaration. The declaration should only be in
mod_request.c
3. mod_filter.c:149 requires a cast for ap_expr_string on platforms where
AP_DECLARE specifies a non-default linkage (this cast is benign on Unix).
The attached trunk patch addresses these issues.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
DO NOT REPLY [Bug 44974] mod_request build
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=44974
--- Comment #3 from Ruediger Pluem <rp...@apache.org> 2008-05-12 13:26:24 PST ---
Tom, please also raise this on the dev list and feel free to commit your
windows specific patches.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
DO NOT REPLY [Bug 44974] mod_request build
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=44974
--- Comment #4 from Tom Donovan <To...@acm.org> 2008-05-12 16:05:59 PST ---
(In reply to comment #3)
> Tom, please also raise this on the dev list and feel free to commit your
> windows specific patches.
>
Thanks Ruediger, but I don't have commit access yet. I expect it takes a
little while to get processed.
re: "raise this on the dev list" - sure, if you think it's worthwhile. I
presumed this was just routine "tidying up" after r647263 ... r654952 which
were pretty well discussed.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
DO NOT REPLY [Bug 44974] mod_request build
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=44974
--- Comment #1 from Tom Donovan <To...@acm.org> 2008-05-12 08:10:55 PST ---
Created an attachment (id=21950)
--> (https://issues.apache.org/bugzilla/attachment.cgi?id=21950)
Windows project file for mod_request (trunk)
For Windows build, these changes are also needed:
1. a mod_request.dsp project file is attached
it requires these manual steps:
mod_request.dsp should be added to the Apache.dsw workspace
buildbin should depend on mod_request
mod_request depends on libapr, libaprutil, libhttpd
add mod_request.h to "headers" in libhttpd with a custom-build step:
type .\modules\filters\mod_request.h > .\include\mod_request.h
2. a Makefile.win patch is attached in the next comment.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
DO NOT REPLY [Bug 44974] mod_request build
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=44974
--- Comment #2 from Tom Donovan <To...@acm.org> 2008-05-12 08:11:37 PST ---
Created an attachment (id=21951)
--> (https://issues.apache.org/bugzilla/attachment.cgi?id=21951)
Windows Makefile.win patch (trunk)
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
DO NOT REPLY [Bug 44974] mod_request build
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=44974
Will Rowe <wr...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
--- Comment #5 from Will Rowe <wr...@apache.org> 2008-06-06 23:50:54 PST ---
Fixed along with a host of modules, thanks for the report.
Please do review your build success on trunk and report back to dev@ if there
are any remaining issues beyond mod_serf, which I didn't get to as a matter
of it's really crufty looking comments.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org