You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "allthingssecurity (via GitHub)" <gi...@apache.org> on 2026/10/04 00:10:03 UTC
[PR] CAMEL-25291: camel-plc4x - fail the exchange when a write or read cannot be done [camel]
allthingssecurity opened a new pull request, #27327:
URL: https://github.com/apache/camel/pull/27327
# Description
[CAMEL-25291](https://issues.apache.org/jira/browse/CAMEL-25291)
Two places where camel-plc4x reports a failure as success:
- **Producer.** With `autoReconnect=true`, a failed reconnect was logged ("Unable to reconnect, skipping request") and the exchange completed successfully although nothing was written: error handlers and redeliveries never saw it. A failed write also replaced the message of the exchange with `null` (`exchange.setMessage(null)`), so a redelivery or a dead letter channel got an empty message.
- **Polling consumer** (`pollEnrich`). A failed connection or read returned an exchange with an empty `Map` body and no exception, and a read without an answer within the timeout too (nearly always with `receiveNoWait()`).
This change: the producer lets the reconnect failure fail the exchange and keeps the message; the polling consumer sets the exception of a failed connection or read on the returned exchange (`pollEnrich` copies it), returns `null` when nothing was received within the timeout (the `PollingConsumer` contract), and keeps the interrupt status. The "skipping request" of the producer came with the `autoReconnect` option (#8971) without a stated reason (the review only asked for WARN, in the event-driven consumer, which is not changed). The empty Map of the polling consumer was a choice of CAMEL-18861 (#9254: "An exchange with an empty map is created when no connection could be made" (instead of no exchange)); the polling consumer still returns an exchange for a failed connection or read, now with the exception, and `null` only when nothing arrived within the timeout (as `camel-jpa`). The upgrade guide for 4.23 gets a note, including how a periodically polling route can keep going while
the PLC is unreachable.
Tests:
- `Plc4XFailureTest` (new, mocked `Plc4XEndpoint`): failed reconnect and failed write in the producer, failed reconnect, failed read and no answer in the polling consumer, and a control read.
- Without the change 5 fail; the control passes.
- With the change the module suite passes (23 tests).
# Target
- [x] I checked that the commit is targeting the correct branch (Camel 4 uses the `main` branch)
# Tracking
- [x] If this is a large change, bug fix, or code improvement, I checked there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it).
# Apache Camel coding standards and style
- [x] I checked that each commit in the pull request has a meaningful subject line and body.
- [ ] I have run `mvn clean install -DskipTests` locally from root folder and I have committed all auto-generated changes.
(I built and tested the affected module, including the formatter and import-sort plugins. I did not run the full root build.)
# AI-assisted contributions
- [x] If this PR includes AI-generated code, commits have proper co-authorship attribution (e.g., `Co-authored-by` trailers) and the PR description identifies the AI tool used.
This PR was prepared with Claude Code (Claude Opus 5.5). The commit carries a `Co-Authored-By` trailer.
_Claude Code on behalf of allthingssecurity_
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-25291: camel-plc4x - fail the exchange when a write or read cannot be done [camel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27327:
URL: https://github.com/apache/camel/pull/27327#issuecomment-5977282862
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:robot: CI automation will test this PR automatically.
:camel: Apache Camel Committers, please review the following items:
* First-time contributors **require MANUAL approval** for the GitHub Actions to run
* You can use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot although they are normally detected and executed by CI.
* You can label PRs using `skip-tests` and `test-dependents` to fine-tune the checks executed by this PR.
* Build and test logs are available in the summary page. **Only** [Apache Camel committers](https://camel.apache.org/community/team/#committers) have access to the summary.
:warning: Be careful when sharing logs. Review their contents before sharing them publicly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-25291: camel-plc4x - fail the exchange when a write or read cannot be done [camel]
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus merged PR #27327:
URL: https://github.com/apache/camel/pull/27327
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-25291: camel-plc4x - fail the exchange when a write or read cannot be done [camel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27327:
URL: https://github.com/apache/camel/pull/27327#issuecomment-5977470072
<!-- ci-tested-modules -->
:test_tube: **CI tested the following changed modules:**
- `components/camel-plc4x`
- `docs`
---
<details><summary>:microscope: Scalpel shadow comparison — Scalpel: 9 of 698 tested, 26 compile-only — current: 9 all tested</summary>
[Maveniverse Scalpel](https://github.com/maveniverse/scalpel) detected **9 affected modules** (current approach: 9).
**Skip-tests mode would test 9 modules** (2 direct + 8 downstream), **skip tests for 26** (generated code, meta-modules)
<details><summary>Modules Scalpel would test (9)</summary>
- `camel-jbang-mcp` ← downstream of org.apache.camel:camel-catalog
- `camel-jbang-plugin-mcp` ← downstream of org.apache.camel:camel-jbang-core
- `camel-jbang-plugin-route-parser` ← downstream of org.apache.camel:camel-route-parser
- `camel-jbang-plugin-tui` ← downstream of org.apache.camel:camel-catalog
- `camel-jbang-plugin-validate` ← downstream of org.apache.camel:camel-yaml-dsl-validator
- `camel-launcher-container` ← downstream of org.apache.camel:camel-launcher
- `camel-plc4x` ← components/camel-plc4x/src/main/java/org/apache/camel/component/plc4x/Plc4XPollingConsumer.java, components/camel-plc4x/src/main/java/org/apache/camel/component/plc4x/Plc4XProducer.java, components/camel-plc4x/src/test/java/org/apache/camel/component/plc4x/Plc4XFailureTest.java
- `camel-yaml-dsl-validator` ← downstream of org.apache.camel:camel-catalog
- `camel-yaml-dsl-validator-maven-plugin` ← downstream of org.apache.camel:camel-yaml-dsl-validator
</details>
<details><summary>Modules with tests skipped (26)</summary>
- `apache-camel`
- `camel-allcomponents`
- `camel-catalog`
- `camel-catalog-console`
- `camel-catalog-maven`
- `camel-catalog-suggest`
- `camel-componentdsl`
- `camel-endpointdsl`
- `camel-endpointdsl-support`
- `camel-itest`
- `camel-jbang-core`
- `camel-jbang-it`
- `camel-jbang-main`
- `camel-jbang-plugin-edit`
- `camel-jbang-plugin-generate`
- `camel-jbang-plugin-kubernetes`
- `camel-jbang-plugin-test`
- `camel-kamelet-main`
- `camel-launcher`
- `camel-report-maven-plugin`
- `camel-route-parser`
- `camel-yaml-dsl`
- `camel-yaml-dsl-deserializers`
- `camel-yaml-dsl-maven-plugin`
- `coverage`
- `dummy-component`
</details>
> :information_source: Shadow mode — Scalpel observes but does not affect test execution. [Learn more](https://github.com/maveniverse/scalpel)
</details>
<details><summary>All tested modules (36 modules, 6m 6s total)</summary>
**Total reactor time:** 6m 6s
| Module | Duration | Status |
| --- | --- | --- |
| Camel :: Launcher | 47.0s | SUCCESS |
| Camel :: JBang :: Plugin :: TUI | 45.9s | SUCCESS |
| Camel :: JBang :: MCP | 40.9s | SUCCESS |
| Camel :: Component DSL | 30.0s | SUCCESS |
| Camel :: Catalog :: Camel Catalog | 25.0s | SUCCESS |
| Camel :: YAML DSL :: Validator | 21.0s | SUCCESS |
| Camel :: YAML DSL | 20.3s | SUCCESS |
| Camel :: JBang :: Plugin :: Kubernetes | 19.0s | SUCCESS |
| Camel :: Docs | 16.2s | SUCCESS |
| Camel :: PLC4X | 13.7s | SUCCESS |
| Camel :: Kamelet Main | 13.7s | SUCCESS |
| Camel :: Catalog :: Camel Report Maven Plugin | 10.8s | SUCCESS |
| Camel :: YAML DSL :: Deserializers | 8.3s | SUCCESS |
| Camel :: Catalog :: Camel Route Parser | 8.2s | SUCCESS |
| Camel :: JBang :: Plugin :: Testing | 8.0s | SUCCESS |
| Camel :: JBang :: Plugin :: Validate | 5.4s | SUCCESS |
| Camel :: All Components Sync point | 4.8s | SUCCESS |
| Camel :: YAML DSL :: Validator Maven Plugin | 4.8s | SUCCESS |
| Camel :: YAML DSL :: Maven Plugins | 3.6s | SUCCESS |
| Camel :: Catalog :: Maven | 3.5s | SUCCESS |
| Camel :: Catalog :: Suggest (deprecated) | 2.9s | SUCCESS |
| Camel :: Assembly | 2.4s | SUCCESS |
| Camel :: Catalog :: Dummy Component | 1.3s | SUCCESS |
| Camel :: JBang :: Plugin :: Edit | 1.3s | SUCCESS |
| Camel :: JBang :: Plugin :: Generate | 1.3s | SUCCESS |
| Camel :: Endpoint DSL :: Support | 1.2s | SUCCESS |
| Camel :: Coverage | 1.2s | SUCCESS |
| Camel :: Catalog :: Console | 0.9s | SUCCESS |
| Camel :: JBang :: Integration tests | 0.9s | SUCCESS |
| Camel :: Launcher :: Container | 0.7s | SUCCESS |
| Camel :: JBang :: Main | 0.7s | SUCCESS |
| Camel :: JBang :: Plugin :: MCP | 0.6s | SUCCESS |
| Camel :: JBang :: Plugin :: Route Parser | 0.6s | SUCCESS |
| Camel :: Endpoint DSL | n/a | |
| Camel :: Integration Tests | n/a | |
| Camel :: JBang :: Core | n/a | |
**Top 20 slowest modules:**
- `Camel :: Launcher` (47.0s)
- `Camel :: JBang :: Plugin :: TUI` (45.9s)
- `Camel :: JBang :: MCP` (40.9s)
- `Camel :: Component DSL` (30.0s)
- `Camel :: Catalog :: Camel Catalog` (25.0s)
- `Camel :: YAML DSL :: Validator` (21.0s)
- `Camel :: YAML DSL` (20.3s)
- `Camel :: JBang :: Plugin :: Kubernetes` (19.0s)
- `Camel :: Docs` (16.2s)
- `Camel :: PLC4X` (13.7s)
- `Camel :: Kamelet Main` (13.7s)
- `Camel :: Catalog :: Camel Report Maven Plugin` (10.8s)
- `Camel :: YAML DSL :: Deserializers` (8.3s)
- `Camel :: Catalog :: Camel Route Parser` (8.2s)
- `Camel :: JBang :: Plugin :: Testing` (8.0s)
- `Camel :: JBang :: Plugin :: Validate` (5.4s)
- `Camel :: All Components Sync point` (4.8s)
- `Camel :: YAML DSL :: Validator Maven Plugin` (4.8s)
- `Camel :: YAML DSL :: Maven Plugins` (3.6s)
- `Camel :: Catalog :: Maven` (3.5s)
</details>
---
:gear: [View full build and test results](https://github.com/apache/camel/actions/runs/37182530462)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org