[jira] [Comment Edited] (SHINDIG-1910) gadget_holder.js pollutes global namespace

["Matt Whelan (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SHINDIG-1910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13592744#comment-13592744 ] 

Matt Whelan edited comment on SHINDIG-1910 at 3/4/13 10:31 PM:
---------------------------------------------------------------

Patch against trunk.  This resolves the issue.
                
      was (Author: matt.whelan):
    Patch against trunk.
                  
> gadget_holder.js pollutes global namespace
> ------------------------------------------
>
>                 Key: SHINDIG-1910
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1910
>             Project: Shindig
>          Issue Type: Bug
>          Components: Javascript 
>    Affects Versions: 2.5.0-beta5
>            Reporter: Matt Whelan
>         Attachments: namespace_pollution_fix.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> gadget_holder.js has an init method defined in the global namespace.  This causes initialization to fail and all script execution to halt when another, unrelated module defines a function of the same name, and a script combining scheme is used to minimize requests to the server.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira