[GitHub] johnyangk commented on a change in pull request #27: [NEMO-49] Replace failed executor with a new executor

[GitBox <gi...@apache.org>]

johnyangk commented on a change in pull request #27: [NEMO-49] Replace failed executor with a new executor
URL: https://github.com/apache/incubator-nemo/pull/27#discussion_r192950066
 
 

 ##########
 File path: runtime/driver/src/main/java/edu/snu/nemo/driver/NemoDriver.java
 ##########
 @@ -153,13 +153,7 @@ private void startSchedulingUserApplication() {
   public final class FailedEvaluatorHandler implements EventHandler<FailedEvaluator> {
     @Override
     public void onNext(final FailedEvaluator failedEvaluator) {
-      // The list size is 0 if the evaluator failed before an executor started. For now, the size is 1 otherwise.
-      failedEvaluator.getFailedContextList().forEach(failedContext -> {
 
 Review comment:
   Unfortunately there's no clear boundary between NemoDriver and RuntimeMaster at the moment regarding using REEF constructs. I've filed an issue to isolate the REEF dependencies within /runtime/driver: https://issues.apache.org/jira/browse/NEMO-93

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services