You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "AlexStocks (via GitHub)" <gi...@apache.org> on 2025/12/27 11:06:20 UTC
[I] [BUG] fix polaris integretation test fail [dubbo-go]
AlexStocks opened a new issue, #3151:
URL: https://github.com/apache/dubbo-go/issues/3151
### ✅ 验证清单
- [x] 🔍 我已经搜索过 [现有 Issues](https://github.com/apache/dubbo-go/issues)，确信这不是重复问题
### 🚀 Go 版本
1.24.0
### 📦 Dubbo-go 版本
v3.3.1
### 🖥️ 服务端配置
_No response_
### 💻 客户端配置
_No response_
### 🌐 协议配置
_No response_
### 📋 注册中心配置
_No response_
### 💾 操作系统
🪟 Windows
### 📝 Bug 描述
2025-12-27 11:02:55 ERROR chain/chain.go:121 Build router chain failed with routerFactories key:polaris-router and error:polaris router must set application name
from https://github.com/apache/dubbo-go/actions/runs/20538128010/job/58998961504
### 🔄 重现步骤
View https://github.com/apache/dubbo-go/actions/runs/20538128010/job/58998961504 directly.
### ✅ 预期行为
This failure should not appear.
### ❌ 实际行为
fix ti
### 💡 可能的解决方案
fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [I] [BUG] fix polaris integretation test fail [dubbo-go]
Posted by "manvendra5345 (via GitHub)" <gi...@apache.org>.
manvendra5345 commented on issue #3151:
URL: https://github.com/apache/dubbo-go/issues/3151#issuecomment-3699145321
Sir, there is no issue with that. I am new to open-source contributions and have just started learning. I am genuinely interested in contributing and growing through this experience, regardless of whether it is for GSoC or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [I] [BUG] fix polaris integretation test fail [dubbo-go]
Posted by "manvendra5345 (via GitHub)" <gi...@apache.org>.
manvendra5345 commented on issue #3151:
URL: https://github.com/apache/dubbo-go/issues/3151#issuecomment-3864757457
@Alanxtl yes I will push the issue by tomorrow sir. Sorry for the delay I had to understand a bit and learn so it became little hard
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [I] [BUG] fix polaris integretation test fail [dubbo-go]
Posted by "Alanxtl (via GitHub)" <gi...@apache.org>.
Alanxtl commented on issue #3151:
URL: https://github.com/apache/dubbo-go/issues/3151#issuecomment-4052435892
hi @manvendra5345 , any progess?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [I] [BUG] fix polaris integretation test fail [dubbo-go]
Posted by "AlexStocks (via GitHub)" <gi...@apache.org>.
AlexStocks commented on issue #3151:
URL: https://github.com/apache/dubbo-go/issues/3151#issuecomment-3699047115
> Hi [@AlexStocks](https://github.com/AlexStocks) ,
>
> I’m interested in working on this issue as part of GSoC. I’ve gone through the issue details and related code, and I’d love to take ownership and start contributing.
>
> If it’s available, could you please assign this issue to me?
>
> Thanks!
Yeah, I can assign it to you. However, I can not assure u that it is a part of GSoC work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [I] [BUG] fix polaris integretation test fail [dubbo-go]
Posted by "Alanxtl (via GitHub)" <gi...@apache.org>.
Alanxtl commented on issue #3151:
URL: https://github.com/apache/dubbo-go/issues/3151#issuecomment-4135091458
close via #3256
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [I] [BUG] fix polaris integretation test fail [dubbo-go]
Posted by "AlexStocks (via GitHub)" <gi...@apache.org>.
AlexStocks commented on issue #3151:
URL: https://github.com/apache/dubbo-go/issues/3151#issuecomment-4059291655
I traced through the code and the root cause is a **storage-vs-retrieval mismatch** for the application name.
**How it's stored** (`registry/directory/directory.go:88-96`):
```go
application := config.GetRootConfig().Application
url.SetAttribute(constant.ApplicationKey, application) // stores *global.ApplicationConfig as attribute
```
**How polaris router reads it** (`cluster/router/polaris/router.go:57-61`):
```go
applicationName := url.GetParam(constant.ApplicationKey, "") // looks for string param — always ""
applicationName = url.SubURL.GetParam(constant.ApplicationKey, "") // same — always ""
// → "polaris router must set application name"
```
The application is stored as a structured `*global.ApplicationConfig` object in URL **attributes**, but the polaris router tries to read it as a URL **parameter** (plain string). They never meet.
**Fix** — update `cluster/router/polaris/router.go` to read from attributes:
```go
func newPolarisRouter(url *common.URL) (*polarisRouter, error) {
var applicationName string
// first try URL param (backward compat)
applicationName = url.GetParam(constant.ApplicationKey, "")
// then try attribute (current storage path)
if applicationName == "" {
if appConfRaw, ok := url.GetAttribute(constant.ApplicationKey); ok {
if appConf, ok := appConfRaw.(*global.ApplicationConfig); ok && appConf != nil {
applicationName = appConf.Name
}
}
}
// fallback to SubURL
if applicationName == "" && url.SubURL != nil {
applicationName = url.SubURL.GetParam(constant.ApplicationKey, "")
if applicationName == "" {
if appConfRaw, ok := url.SubURL.GetAttribute(constant.ApplicationKey); ok {
if appConf, ok := appConfRaw.(*global.ApplicationConfig); ok && appConf != nil {
applicationName = appConf.Name
}
}
}
}
if applicationName == "" {
return nil, fmt.Errorf("polaris router must set application name")
}
// ...
}
```
This is a ~10 line change. The same pattern is already used elsewhere in the codebase (e.g. `registry/directory/directory.go:223`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [I] [BUG] fix polaris integretation test fail [dubbo-go]
Posted by "Alanxtl (via GitHub)" <gi...@apache.org>.
Alanxtl closed issue #3151: [BUG] fix polaris integretation test fail
URL: https://github.com/apache/dubbo-go/issues/3151
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [I] [BUG] fix polaris integretation test fail [dubbo-go]
Posted by "Alanxtl (via GitHub)" <gi...@apache.org>.
Alanxtl commented on issue #3151:
URL: https://github.com/apache/dubbo-go/issues/3151#issuecomment-3864695576
hi @manvendra5345 , any progess?
fyi #3185 #3199 #3181 may related to this issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [I] [BUG] fix polaris integretation test fail [dubbo-go]
Posted by "manvendra5345 (via GitHub)" <gi...@apache.org>.
manvendra5345 commented on issue #3151:
URL: https://github.com/apache/dubbo-go/issues/3151#issuecomment-3698535629
Hi @AlexStocks ,
I’m interested in working on this issue as part of GSoC. I’ve gone through the issue details and related code, and I’d love to take ownership and start contributing.
If it’s available, could you please assign this issue to me?
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org