You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@solr.apache.org by "epugh (via GitHub)" <gi...@apache.org> on 2023/02/09 15:06:48 UTC

[GitHub] [solr] epugh commented on pull request #1014: Refactor SolrZkclient to use a Builder pattern

epugh commented on PR #1014:
URL: https://github.com/apache/solr/pull/1014#issuecomment-1424338918

   Could we follow the same pattern defined in SOLR-16595 and SOLR-16590 of using `with` instead of bare property names, and using `TimeUnit`?   Have some consistency in how we create our builders!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org