You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2016/01/13 07:23:48 UTC
Review Request 42238: Implemented the Docker URI fetcher plugin based
on curl.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42238/
-----------------------------------------------------------
Review request for mesos, Ben Mahler, Gilbert Song, Jojy Varghese, and Timothy Chen.
Bugs: MESOS-4296
https://issues.apache.org/jira/browse/MESOS-4296
Repository: mesos
Description
-------
Implemented the Docker URI fetcher plugin based on curl.
Diffs
-----
src/uri/fetchers/docker.cpp 3595f915cb4b305659fa803e741333be5115aecf
Diff: https://reviews.apache.org/r/42238/diff/
Testing
-------
make check
Thanks,
Jie Yu
Re: Review Request 42238: Implemented the Docker URI fetcher plugin
based on curl.
Posted by Jie Yu <yu...@gmail.com>.
> On Jan. 13, 2016, 11:09 p.m., Timothy Chen wrote:
> > src/uri/fetchers/docker.cpp, line 532
> > <https://reviews.apache.org/r/42238/diff/1/?file=1195241#file1195241line532>
> >
> > Is it possible to have multiple images/manifests per directory? Assuming a task with multiple volumes and multiple images?
The user of the fetcher will most likely create a temp dir and download images/manifest there. So I don't think this is an issue.
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42238/#review114318
-----------------------------------------------------------
On Jan. 13, 2016, 11:14 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42238/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2016, 11:14 p.m.)
>
>
> Review request for mesos, Ben Mahler, Gilbert Song, Jojy Varghese, and Timothy Chen.
>
>
> Bugs: MESOS-4296
> https://issues.apache.org/jira/browse/MESOS-4296
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Implemented the Docker URI fetcher plugin based on curl.
>
>
> Diffs
> -----
>
> src/uri/fetchers/docker.cpp 3595f915cb4b305659fa803e741333be5115aecf
>
> Diff: https://reviews.apache.org/r/42238/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 42238: Implemented the Docker URI fetcher plugin
based on curl.
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42238/#review114318
-----------------------------------------------------------
src/uri/fetchers/docker.cpp (line 75)
<https://reviews.apache.org/r/42238/#comment175141>
End with period.
src/uri/fetchers/docker.cpp (line 532)
<https://reviews.apache.org/r/42238/#comment175142>
Is it possible to have multiple images/manifests per directory? Assuming a task with multiple volumes and multiple images?
- Timothy Chen
On Jan. 13, 2016, 6:23 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42238/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2016, 6:23 a.m.)
>
>
> Review request for mesos, Ben Mahler, Gilbert Song, Jojy Varghese, and Timothy Chen.
>
>
> Bugs: MESOS-4296
> https://issues.apache.org/jira/browse/MESOS-4296
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Implemented the Docker URI fetcher plugin based on curl.
>
>
> Diffs
> -----
>
> src/uri/fetchers/docker.cpp 3595f915cb4b305659fa803e741333be5115aecf
>
> Diff: https://reviews.apache.org/r/42238/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 42238: Implemented the Docker URI fetcher plugin
based on curl.
Posted by Jie Yu <yu...@gmail.com>.
> On Jan. 13, 2016, 10:51 p.m., Gilbert Song wrote:
> > src/uri/fetchers/docker.cpp, lines 435-437
> > <https://reviews.apache.org/r/42238/diff/1/?file=1195241#file1195241line435>
> >
> > Should this be possible? We may get an error when constructing URI protobuf as `path` is a required field.
Good catch! Thansk!
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42238/#review114295
-----------------------------------------------------------
On Jan. 13, 2016, 11:14 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42238/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2016, 11:14 p.m.)
>
>
> Review request for mesos, Ben Mahler, Gilbert Song, Jojy Varghese, and Timothy Chen.
>
>
> Bugs: MESOS-4296
> https://issues.apache.org/jira/browse/MESOS-4296
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Implemented the Docker URI fetcher plugin based on curl.
>
>
> Diffs
> -----
>
> src/uri/fetchers/docker.cpp 3595f915cb4b305659fa803e741333be5115aecf
>
> Diff: https://reviews.apache.org/r/42238/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 42238: Implemented the Docker URI fetcher plugin
based on curl.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42238/#review114295
-----------------------------------------------------------
src/uri/fetchers/docker.cpp (lines 435 - 437)
<https://reviews.apache.org/r/42238/#comment175111>
Should this be possible? We may get an error when constructing URI protobuf as `path` is a required field.
- Gilbert Song
On Jan. 12, 2016, 10:23 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42238/
> -----------------------------------------------------------
>
> (Updated Jan. 12, 2016, 10:23 p.m.)
>
>
> Review request for mesos, Ben Mahler, Gilbert Song, Jojy Varghese, and Timothy Chen.
>
>
> Bugs: MESOS-4296
> https://issues.apache.org/jira/browse/MESOS-4296
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Implemented the Docker URI fetcher plugin based on curl.
>
>
> Diffs
> -----
>
> src/uri/fetchers/docker.cpp 3595f915cb4b305659fa803e741333be5115aecf
>
> Diff: https://reviews.apache.org/r/42238/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 42238: Implemented the Docker URI fetcher plugin
based on curl.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42238/
-----------------------------------------------------------
(Updated Jan. 17, 2016, 9:51 p.m.)
Review request for mesos, Ben Mahler, Gilbert Song, Jojy Varghese, and Timothy Chen.
Changes
-------
Review comments.
Bugs: MESOS-4296
https://issues.apache.org/jira/browse/MESOS-4296
Repository: mesos
Description
-------
Implemented the Docker URI fetcher plugin based on curl.
Diffs (updated)
-----
include/mesos/uri/fetcher.hpp af2cf00a4d59c36ab811f423ce5c6821b0115c74
src/uri/fetchers/docker.cpp 3595f915cb4b305659fa803e741333be5115aecf
Diff: https://reviews.apache.org/r/42238/diff/
Testing
-------
make check
Thanks,
Jie Yu
Re: Review Request 42238: Implemented the Docker URI fetcher plugin
based on curl.
Posted by Jie Yu <yu...@gmail.com>.
> On Jan. 15, 2016, 8:23 p.m., Gilbert Song wrote:
> > src/uri/fetchers/docker.cpp, line 575
> > <https://reviews.apache.org/r/42238/diff/2/?file=1196119#file1196119line575>
> >
> > Should we take `strings::tokenize(tokens[1], ",")` out and check its size?
Nope. the contains check below will handle the error case.
> On Jan. 15, 2016, 8:23 p.m., Gilbert Song wrote:
> > src/uri/fetchers/docker.cpp, lines 576-581
> > <https://reviews.apache.org/r/42238/diff/2/?file=1196119#file1196119line576>
> >
> > Do we allow any of `"xxx", "yyy", "zzz"` to be empty? If not, it may be more safe to use `strings::tokenize`.
It doesn't matter. It'll be an error anyway.
> On Jan. 15, 2016, 8:23 p.m., Gilbert Song wrote:
> > src/uri/fetchers/docker.cpp, lines 598-601
> > <https://reviews.apache.org/r/42238/diff/2/?file=1196119#file1196119line598>
> >
> > Should we handle removing quotation marks here?
Nope. The quotes have been removed above. I added a TODO about query encoding.
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42238/#review114758
-----------------------------------------------------------
On Jan. 13, 2016, 11:14 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42238/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2016, 11:14 p.m.)
>
>
> Review request for mesos, Ben Mahler, Gilbert Song, Jojy Varghese, and Timothy Chen.
>
>
> Bugs: MESOS-4296
> https://issues.apache.org/jira/browse/MESOS-4296
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Implemented the Docker URI fetcher plugin based on curl.
>
>
> Diffs
> -----
>
> src/uri/fetchers/docker.cpp 3595f915cb4b305659fa803e741333be5115aecf
>
> Diff: https://reviews.apache.org/r/42238/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 42238: Implemented the Docker URI fetcher plugin
based on curl.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42238/#review114758
-----------------------------------------------------------
src/uri/fetchers/docker.cpp (lines 31 - 32)
<https://reviews.apache.org/r/42238/#comment175617>
Add `#include <stout/strings.hpp>`.
src/uri/fetchers/docker.cpp (line 575)
<https://reviews.apache.org/r/42238/#comment175614>
Should we take `strings::tokenize(tokens[1], ",")` out and check its size?
src/uri/fetchers/docker.cpp (lines 576 - 581)
<https://reviews.apache.org/r/42238/#comment175615>
Do we allow any of `"xxx", "yyy", "zzz"` to be empty? If not, it may be more safe to use `strings::tokenize`.
src/uri/fetchers/docker.cpp (lines 598 - 601)
<https://reviews.apache.org/r/42238/#comment175616>
Should we handle removing quotation marks here?
- Gilbert Song
On Jan. 13, 2016, 3:14 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42238/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2016, 3:14 p.m.)
>
>
> Review request for mesos, Ben Mahler, Gilbert Song, Jojy Varghese, and Timothy Chen.
>
>
> Bugs: MESOS-4296
> https://issues.apache.org/jira/browse/MESOS-4296
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Implemented the Docker URI fetcher plugin based on curl.
>
>
> Diffs
> -----
>
> src/uri/fetchers/docker.cpp 3595f915cb4b305659fa803e741333be5115aecf
>
> Diff: https://reviews.apache.org/r/42238/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 42238: Implemented the Docker URI fetcher plugin
based on curl.
Posted by Jie Yu <yu...@gmail.com>.
> On Jan. 14, 2016, 5:54 p.m., Jojy Varghese wrote:
> > One of the concerns for spawning shells for image fetching is that there will be a lot of forks per image. For example - docker image fetch will have 1 initial request, 1 token request, 1 manifest request, N layer requests, N validation (SHA calculation).
> >
> > I was wondering if we can have one bash script that does all of this and we launch that.
Are you concerned about performance? Let's optimize it once we have data to show that it's a problem.
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42238/#review114511
-----------------------------------------------------------
On Jan. 13, 2016, 11:14 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42238/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2016, 11:14 p.m.)
>
>
> Review request for mesos, Ben Mahler, Gilbert Song, Jojy Varghese, and Timothy Chen.
>
>
> Bugs: MESOS-4296
> https://issues.apache.org/jira/browse/MESOS-4296
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Implemented the Docker URI fetcher plugin based on curl.
>
>
> Diffs
> -----
>
> src/uri/fetchers/docker.cpp 3595f915cb4b305659fa803e741333be5115aecf
>
> Diff: https://reviews.apache.org/r/42238/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 42238: Implemented the Docker URI fetcher plugin
based on curl.
Posted by Jojy Varghese <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42238/#review114511
-----------------------------------------------------------
One of the concerns for spawning shells for image fetching is that there will be a lot of forks per image. For example - docker image fetch will have 1 initial request, 1 token request, 1 manifest request, N layer requests, N validation (SHA calculation).
I was wondering if we can have one bash script that does all of this and we launch that.
- Jojy Varghese
On Jan. 13, 2016, 11:14 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42238/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2016, 11:14 p.m.)
>
>
> Review request for mesos, Ben Mahler, Gilbert Song, Jojy Varghese, and Timothy Chen.
>
>
> Bugs: MESOS-4296
> https://issues.apache.org/jira/browse/MESOS-4296
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Implemented the Docker URI fetcher plugin based on curl.
>
>
> Diffs
> -----
>
> src/uri/fetchers/docker.cpp 3595f915cb4b305659fa803e741333be5115aecf
>
> Diff: https://reviews.apache.org/r/42238/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 42238: Implemented the Docker URI fetcher plugin
based on curl.
Posted by Jie Yu <yu...@gmail.com>.
> On Jan. 14, 2016, 12:42 a.m., Jojy Varghese wrote:
> > src/uri/fetchers/docker.cpp, line 375
> > <https://reviews.apache.org/r/42238/diff/2/?file=1196119#file1196119line375>
> >
> > recursive mkdir?
mkdir by default is recursive.
> On Jan. 14, 2016, 12:42 a.m., Jojy Varghese wrote:
> > src/uri/fetchers/docker.cpp, line 280
> > <https://reviews.apache.org/r/42238/diff/2/?file=1196119#file1196119line280>
> >
> > Why not use Path here instead of string? Here and other places.
Added a TODO.
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42238/#review114344
-----------------------------------------------------------
On Jan. 13, 2016, 11:14 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42238/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2016, 11:14 p.m.)
>
>
> Review request for mesos, Ben Mahler, Gilbert Song, Jojy Varghese, and Timothy Chen.
>
>
> Bugs: MESOS-4296
> https://issues.apache.org/jira/browse/MESOS-4296
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Implemented the Docker URI fetcher plugin based on curl.
>
>
> Diffs
> -----
>
> src/uri/fetchers/docker.cpp 3595f915cb4b305659fa803e741333be5115aecf
>
> Diff: https://reviews.apache.org/r/42238/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 42238: Implemented the Docker URI fetcher plugin
based on curl.
Posted by Jojy Varghese <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42238/#review114344
-----------------------------------------------------------
src/uri/fetchers/docker.cpp (line 280)
<https://reviews.apache.org/r/42238/#comment175183>
Why not use Path here instead of string? Here and other places.
src/uri/fetchers/docker.cpp (line 375)
<https://reviews.apache.org/r/42238/#comment175184>
recursive mkdir?
- Jojy Varghese
On Jan. 13, 2016, 11:14 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42238/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2016, 11:14 p.m.)
>
>
> Review request for mesos, Ben Mahler, Gilbert Song, Jojy Varghese, and Timothy Chen.
>
>
> Bugs: MESOS-4296
> https://issues.apache.org/jira/browse/MESOS-4296
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Implemented the Docker URI fetcher plugin based on curl.
>
>
> Diffs
> -----
>
> src/uri/fetchers/docker.cpp 3595f915cb4b305659fa803e741333be5115aecf
>
> Diff: https://reviews.apache.org/r/42238/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 42238: Implemented the Docker URI fetcher plugin
based on curl.
Posted by Jie Yu <yu...@gmail.com>.
> On Jan. 14, 2016, 12:29 a.m., Jojy Varghese wrote:
> > src/uri/fetchers/docker.cpp, line 219
> > <https://reviews.apache.org/r/42238/diff/2/?file=1196119#file1196119line219>
> >
> > Can be refactored to common function (and avoid duplicate code at L124).
There're some subtle differences. I'll add a TODO here. Basically, the await logic should go to Subprocess (i.e., we can introduce a method similar to Popen.communicate in python).
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42238/#review114342
-----------------------------------------------------------
On Jan. 13, 2016, 11:14 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42238/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2016, 11:14 p.m.)
>
>
> Review request for mesos, Ben Mahler, Gilbert Song, Jojy Varghese, and Timothy Chen.
>
>
> Bugs: MESOS-4296
> https://issues.apache.org/jira/browse/MESOS-4296
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Implemented the Docker URI fetcher plugin based on curl.
>
>
> Diffs
> -----
>
> src/uri/fetchers/docker.cpp 3595f915cb4b305659fa803e741333be5115aecf
>
> Diff: https://reviews.apache.org/r/42238/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 42238: Implemented the Docker URI fetcher plugin
based on curl.
Posted by Jojy Varghese <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42238/#review114342
-----------------------------------------------------------
src/uri/fetchers/docker.cpp (line 219)
<https://reviews.apache.org/r/42238/#comment175180>
Can be refactored to common function (and avoid duplicate code at L124).
- Jojy Varghese
On Jan. 13, 2016, 11:14 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42238/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2016, 11:14 p.m.)
>
>
> Review request for mesos, Ben Mahler, Gilbert Song, Jojy Varghese, and Timothy Chen.
>
>
> Bugs: MESOS-4296
> https://issues.apache.org/jira/browse/MESOS-4296
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Implemented the Docker URI fetcher plugin based on curl.
>
>
> Diffs
> -----
>
> src/uri/fetchers/docker.cpp 3595f915cb4b305659fa803e741333be5115aecf
>
> Diff: https://reviews.apache.org/r/42238/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 42238: Implemented the Docker URI fetcher plugin
based on curl.
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42238/#review114765
-----------------------------------------------------------
src/uri/fetchers/docker.cpp (lines 598 - 601)
<https://reviews.apache.org/r/42238/#comment175620>
I think we should leave a TODO that we need to support credentials to get auth, and even custom SSL certificates in the future.
- Timothy Chen
On Jan. 13, 2016, 11:14 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42238/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2016, 11:14 p.m.)
>
>
> Review request for mesos, Ben Mahler, Gilbert Song, Jojy Varghese, and Timothy Chen.
>
>
> Bugs: MESOS-4296
> https://issues.apache.org/jira/browse/MESOS-4296
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Implemented the Docker URI fetcher plugin based on curl.
>
>
> Diffs
> -----
>
> src/uri/fetchers/docker.cpp 3595f915cb4b305659fa803e741333be5115aecf
>
> Diff: https://reviews.apache.org/r/42238/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 42238: Implemented the Docker URI fetcher plugin
based on curl.
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42238/#review114766
-----------------------------------------------------------
Ship it!
Ship It!
- Timothy Chen
On Jan. 13, 2016, 11:14 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42238/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2016, 11:14 p.m.)
>
>
> Review request for mesos, Ben Mahler, Gilbert Song, Jojy Varghese, and Timothy Chen.
>
>
> Bugs: MESOS-4296
> https://issues.apache.org/jira/browse/MESOS-4296
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Implemented the Docker URI fetcher plugin based on curl.
>
>
> Diffs
> -----
>
> src/uri/fetchers/docker.cpp 3595f915cb4b305659fa803e741333be5115aecf
>
> Diff: https://reviews.apache.org/r/42238/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 42238: Implemented the Docker URI fetcher plugin
based on curl.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42238/#review114922
-----------------------------------------------------------
Ship it!
Ship It!
- Gilbert Song
On Jan. 13, 2016, 3:14 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42238/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2016, 3:14 p.m.)
>
>
> Review request for mesos, Ben Mahler, Gilbert Song, Jojy Varghese, and Timothy Chen.
>
>
> Bugs: MESOS-4296
> https://issues.apache.org/jira/browse/MESOS-4296
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Implemented the Docker URI fetcher plugin based on curl.
>
>
> Diffs
> -----
>
> src/uri/fetchers/docker.cpp 3595f915cb4b305659fa803e741333be5115aecf
>
> Diff: https://reviews.apache.org/r/42238/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 42238: Implemented the Docker URI fetcher plugin
based on curl.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42238/
-----------------------------------------------------------
(Updated Jan. 13, 2016, 11:14 p.m.)
Review request for mesos, Ben Mahler, Gilbert Song, Jojy Varghese, and Timothy Chen.
Changes
-------
Supported http. Also, supported no authentication case.
Bugs: MESOS-4296
https://issues.apache.org/jira/browse/MESOS-4296
Repository: mesos
Description
-------
Implemented the Docker URI fetcher plugin based on curl.
Diffs (updated)
-----
src/uri/fetchers/docker.cpp 3595f915cb4b305659fa803e741333be5115aecf
Diff: https://reviews.apache.org/r/42238/diff/
Testing
-------
make check
Thanks,
Jie Yu