You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "jingfengtan (JIRA)" <ji...@apache.org> on 2010/07/19 11:02:49 UTC

[jira] Created: (CASSANDRA-1297) commitlog recover bug

commitlog recover bug
---------------------

                 Key: CASSANDRA-1297
                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1297
             Project: Cassandra
          Issue Type: Bug
          Components: Core
    Affects Versions: 0.6
            Reporter: jingfengtan
             Fix For: 0.6.4


class CommitLog.java
when recover log files;
 if one log  file have no dirty , process is break;
{quote}
199  int lowPos = CommitLogHeader.getLowestPosition(clHeader);
 200 if (lowPos == 0)
 201    break;
{quote}

why not continue and read next log file
{quote}
199  int lowPos = CommitLogHeader.getLowestPosition(clHeader);
200 if (lowPos == 0)\{
201   reader.close();
202   continue;
203  \}
{quote}

i am not very sure about that. how can answer?




-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (CASSANDRA-1297) commitlog recover bug

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-1297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Ellis resolved CASSANDRA-1297.
---------------------------------------

    Resolution: Fixed

you're right, it should continue to the next segment.  fixed in r965457.

> commitlog recover bug
> ---------------------
>
>                 Key: CASSANDRA-1297
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1297
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>            Reporter: jingfengtan
>            Assignee: jingfengtan
>            Priority: Critical
>             Fix For: 0.6.4
>
>   Original Estimate: 72h
>  Remaining Estimate: 72h
>
> class CommitLog.java
> when recover log files;
>  if one log  file have no dirty , process is break;
> {quote}
> 199  int lowPos = CommitLogHeader.getLowestPosition(clHeader);
>  200 if (lowPos == 0)
>  201    break;
> {quote}
> why not continue and read next log file
> {quote}
> 199  int lowPos = CommitLogHeader.getLowestPosition(clHeader);
> 200 if (lowPos == 0)\{
> 201   reader.close();
> 202   continue;
> 203  \}
> {quote}
> i am not very sure about that. how can answer?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-1297) commitlog recover bug

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-1297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Ellis updated CASSANDRA-1297:
--------------------------------------

             Assignee: jingfengtan
    Affects Version/s:     (was: 0.6)
             Priority: Critical  (was: Major)

> commitlog recover bug
> ---------------------
>
>                 Key: CASSANDRA-1297
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1297
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>            Reporter: jingfengtan
>            Assignee: jingfengtan
>            Priority: Critical
>             Fix For: 0.6.4
>
>   Original Estimate: 72h
>  Remaining Estimate: 72h
>
> class CommitLog.java
> when recover log files;
>  if one log  file have no dirty , process is break;
> {quote}
> 199  int lowPos = CommitLogHeader.getLowestPosition(clHeader);
>  200 if (lowPos == 0)
>  201    break;
> {quote}
> why not continue and read next log file
> {quote}
> 199  int lowPos = CommitLogHeader.getLowestPosition(clHeader);
> 200 if (lowPos == 0)\{
> 201   reader.close();
> 202   continue;
> 203  \}
> {quote}
> i am not very sure about that. how can answer?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.