[GitHub] [superset] john-bodley commented on a diff in pull request #22085: chore: Change get_table_names/get_view_names return type

[GitBox <gi...@apache.org>]

john-bodley commented on code in PR #22085:
URL: https://github.com/apache/superset/pull/22085#discussion_r1024210494


##########
tests/integration_tests/db_engine_specs/base_engine_spec_tests.py:
##########
@@ -229,11 +229,11 @@ def test_get_table_names(self):
 
         """ Make sure base engine spec removes schema name from table name
         ie. when try_remove_schema_from_table_name == True. """
-        base_result_expected = ["table", "table_2"]
+        base_result_expected = {"table", "table_2"}
         base_result = BaseEngineSpec.get_table_names(
             database=mock.ANY, schema="schema", inspector=inspector
         )
-        self.assertListEqual(base_result_expected, base_result)
+        self.assertSetEqual(base_result_expected, base_result)

Review Comment:
   I agree. I didn't know if unittest supported this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org