You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@impala.apache.org by ta...@apache.org on 2018/07/19 14:53:04 UTC

[4/4] impala git commit: IMPALA-7315: fix test_update_with_clear_entries_flag race

IMPALA-7315: fix test_update_with_clear_entries_flag race

We need to wait for the subscriber to process the second update in order
to guarantee that the first update for that subscriber has been applied.
Otherwise there is a race window where the second subscriber may see the
older version of the statestore topic.

Change-Id: I2be2b61b6deb0228fbc5a242e43076beb8871454
Reviewed-on: http://gerrit.cloudera.org:8080/10986
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>


Project: http://git-wip-us.apache.org/repos/asf/impala/repo
Commit: http://git-wip-us.apache.org/repos/asf/impala/commit/70e2d57f
Tree: http://git-wip-us.apache.org/repos/asf/impala/tree/70e2d57f
Diff: http://git-wip-us.apache.org/repos/asf/impala/diff/70e2d57f

Branch: refs/heads/master
Commit: 70e2d57fc06499d3eb7c278c28daf51f782d93b3
Parents: c7d2c2e
Author: Tim Armstrong <ta...@cloudera.com>
Authored: Wed Jul 18 14:36:37 2018 -0700
Committer: Impala Public Jenkins <im...@cloudera.com>
Committed: Thu Jul 19 09:49:26 2018 +0000

----------------------------------------------------------------------
 tests/statestore/test_statestore.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/impala/blob/70e2d57f/tests/statestore/test_statestore.py
----------------------------------------------------------------------
diff --git a/tests/statestore/test_statestore.py b/tests/statestore/test_statestore.py
index 698a2a6..682a306 100644
--- a/tests/statestore/test_statestore.py
+++ b/tests/statestore/test_statestore.py
@@ -558,7 +558,7 @@ class TestStatestore():
         .wait_for_failure()
         .start()
         .register(topics=reg)
-        .wait_for_update(topic_name, 1)
+        .wait_for_update(topic_name, 2)
     )
 
     sub2 = StatestoreSubscriber(update_cb=check_entries)