You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/12/22 22:02:19 UTC

[GitHub] [spark] gengliangwang commented on a diff in pull request #39144: [SPARK-41637][SQL] ORDER BY ALL

gengliangwang commented on code in PR #39144:
URL: https://github.com/apache/spark/pull/39144#discussion_r1055890337


##########
sql/core/src/test/resources/sql-tests/inputs/order-by-all.sql:
##########
@@ -0,0 +1,44 @@
+create temporary view data as select * from values

Review Comment:
   nit: we can have a test case combining `group by all` and `order by all`. It should work, just for covering a testing scenario.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org