You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@drill.apache.org by chunhui-shi <gi...@git.apache.org> on 2018/02/05 19:55:31 UTC

[GitHub] drill pull request #1104: DRILL-6118: Handle item star columns during projec...

Github user chunhui-shi commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1104#discussion_r166066830
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/project/ProjectRecordBatch.java ---
    @@ -596,10 +596,10 @@ private void classifyExpr(final NamedExpression ex, final RecordBatch incoming,
         final NameSegment ref = ex.getRef().getRootSegment();
         final boolean exprHasPrefix = expr.getPath().contains(StarColumnHelper.PREFIX_DELIMITER);
         final boolean refHasPrefix = ref.getPath().contains(StarColumnHelper.PREFIX_DELIMITER);
    -    final boolean exprIsStar = expr.getPath().equals(SchemaPath.WILDCARD);
    -    final boolean refContainsStar = ref.getPath().contains(SchemaPath.WILDCARD);
    -    final boolean exprContainsStar = expr.getPath().contains(SchemaPath.WILDCARD);
    -    final boolean refEndsWithStar = ref.getPath().endsWith(SchemaPath.WILDCARD);
    +    final boolean exprIsStar = expr.getPath().equals(SchemaPath.DYNAMIC_STAR);
    --- End diff --
    
    Why don't we need to handle WILDCARD case anymore?


---