You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by GitBox <gi...@apache.org> on 2019/05/03 06:11:45 UTC
[GitHub] [guacamole-client] mike-jumper commented on issue #398:
GUACAMOLE-784: Tolerate port number within X-Forwarded-For header
mike-jumper commented on issue #398: GUACAMOLE-784: Tolerate port number within X-Forwarded-For header
URL: https://github.com/apache/guacamole-client/pull/398#issuecomment-488956574
I'd also like to highlight:
Regardless of whether you choose to rebase and squash things such that there is only one commit or prepend the JIRA issue to your existing commits, the commit messages need to describe the nature of the change being made, ideally at a high level. They should provide some context/justification that is not otherwise available through git itself.
A message like "Update AuthenticationService.java" does not provide any more information than git already has. It may as well say "potato". ;)
Your first and last commits, on the other hand, are quite nice. "Modify regex for X-Forwarded-For to parse IP:Port" is very clear and describes the nature of the change you're making, as does "Tolerate port number within X-Forwarded-For header" (though they really sound like they should be the same commit).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services