You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@thrift.apache.org by GitBox <gi...@apache.org> on 2022/05/21 20:07:49 UTC

[GitHub] [thrift] ctubbsii commented on pull request #2597: THRIFT-5576: fix old-style cast and redundant copy

ctubbsii commented on PR #2597:
URL: https://github.com/apache/thrift/pull/2597#issuecomment-1133761732

   For convenience, the diff between the two above are:
   
   ```diff
   @@ -7,10 +7,8 @@
      FU_LB& operator=(FU_LB&&) noexcept;
      FU_LB() noexcept
            : ctrl(0),
   -          op((FU_LIST_OP::type)0),
   +          op(static_cast<FU_LIST_OP::type>(0)),
              pos(0) {
   -    op = (FU_LIST_OP::type)0;
   -
      }
    
      virtual ~FU_LB() noexcept;
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org