You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by zentol <gi...@git.apache.org> on 2017/01/11 13:23:16 UTC

[GitHub] flink pull request #3092: [FLINK-5419] Make full TM metrics available throug...

GitHub user zentol opened a pull request:

    https://github.com/apache/flink/pull/3092

    [FLINK-5419] Make full TM metrics available through REST API

    This PR fixes the full set of TaskManager metrics not being available through the REST API. The issue was that multiple handlers were registered for the same URL ("/taskmanagers/:taskmanagerid/metrics").
    The relevant handlers are the ```TaskManagersHandler``` which provides a subset of metrics to the WebInterface (basically what is displayed in the metrics tab in the TM page) and the ```TaskManagerMetricsHandler``` which provides full access to metrics.
    
    The issue was fixed by making the metrics tab use the following URL: "/taskmanagers/:taskmanagerid". This is in fact a reversal of a previous change, which technically changed a public API.
    
    While fixing this i found a bug in the ```TaskManagerMetricsHandler```; it used the wrong constant to extract the TaskManagerID from the path ("tmid" instead of "taskmanagerid")

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zentol/flink 5419_tm_rest

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/3092.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3092
    
----
commit d88dc84100d6d53626c3cb13c5caff5a7bfacc55
Author: zentol <ch...@apache.org>
Date:   2017-01-11T13:07:03Z

    [FLINK-5419] Make full TM metrics available through REST API

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #3092: [FLINK-5419] Make full TM metrics available through REST ...

Posted by StephanEwen <gi...@git.apache.org>.

Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/3092
  
    +1 to merge this
    
    Looks like the web UI files need to be rebuilt when merging this...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #3092: [FLINK-5419] Make full TM metrics available through REST ...

Posted by zentol <gi...@git.apache.org>.

Github user zentol commented on the issue:

    https://github.com/apache/flink/pull/3092
  
    yes, I will rebuild the files while merging. I have other commits pending that require rebuilding, and figured i could do it in one swoop :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #3092: [FLINK-5419] Make full TM metrics available throug...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/3092


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---