You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2021/08/27 08:33:45 UTC
[GitHub] [hbase] Apache9 commented on a change in pull request #3630: HBASE-26147: Add a dry run mode to the balancer, where moves are calculated but not actually executed
Apache9 commented on a change in pull request #3630:
URL: https://github.com/apache/hbase/pull/3630#discussion_r697251503
##########
File path: hbase-protocol-shaded/src/main/protobuf/server/master/Master.proto
##########
@@ -293,11 +293,14 @@ message IsInMaintenanceModeResponse {
}
message BalanceRequest {
- optional bool force = 1;
+ optional bool ignore_rit = 1;
Review comment:
Will this break the wire compatibility?
##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java
##########
@@ -2494,10 +2516,20 @@ boolean snapshotCleanupSwitch(final boolean on, final boolean synchronous)
/**
* Balance regions in the given RegionServer group
* @param groupName the group name
- * @return boolean Whether balance ran or not
+ * @return BalanceResponse details about the balancer run
* @throws IOException if a remote or network exception occurs
*/
- boolean balanceRSGroup(String groupName) throws IOException;
+ default BalanceResponse balanceRSGroup(String groupName) throws IOException {
Review comment:
We will not include this on the current release branches right? IIRC the return value change could also break a compiled java code since the JVM record the return value type in the final generated method name for linking.
##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/BalanceResponse.java
##########
@@ -0,0 +1,129 @@
+/*
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.client;
+
+import org.apache.yetus.audience.InterfaceAudience;
+import org.apache.yetus.audience.InterfaceStability;
+
+/**
+ * Response returned from a balancer invocation
+ */
+@InterfaceAudience.Public
+@InterfaceStability.Evolving
Review comment:
Remove IS annotation.
##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/BalanceResponse.java
##########
@@ -0,0 +1,129 @@
+/*
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.client;
+
+import org.apache.yetus.audience.InterfaceAudience;
+import org.apache.yetus.audience.InterfaceStability;
+
+/**
+ * Response returned from a balancer invocation
+ */
+@InterfaceAudience.Public
+@InterfaceStability.Evolving
+public final class BalanceResponse {
+
+ /**
+ * Builds a {@link BalanceResponse} for returning results of a balance invocation to callers
+ */
+ @InterfaceAudience.Public
+ @InterfaceStability.Evolving
Review comment:
Ditto.
##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/BalanceRequest.java
##########
@@ -0,0 +1,117 @@
+/*
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.client;
+
+import org.apache.yetus.audience.InterfaceAudience;
+import org.apache.yetus.audience.InterfaceStability;
+
+/**
+ * Encapsulates options for executing a run of the Balancer.
+ */
+@InterfaceAudience.Public
+@InterfaceStability.Evolving
Review comment:
There is no IS.Evolving for IA.Public classes, it should always be IS.Stable implicitly, so we do not add IS annotation for IA.Public classes.
##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/BalanceRequest.java
##########
@@ -0,0 +1,117 @@
+/*
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.client;
+
+import org.apache.yetus.audience.InterfaceAudience;
+import org.apache.yetus.audience.InterfaceStability;
+
+/**
+ * Encapsulates options for executing a run of the Balancer.
+ */
+@InterfaceAudience.Public
+@InterfaceStability.Evolving
+public final class BalanceRequest {
+ private static final BalanceRequest DEFAULT = BalanceRequest.newBuilder().build();
+
+ /**
+ * Builder for constructing a {@link BalanceRequest}
+ */
+ @InterfaceAudience.Public
+ @InterfaceStability.Evolving
Review comment:
Ditto.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org