You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@falcon.apache.org by pa...@apache.org on 2016/01/22 12:48:46 UTC

[2/2] falcon git commit: FALCON-1716 API fails with CommunicationsException when mysql interaction time is longer than 53, 434, 939 milliseconds (By Pavan Kolamuri)

FALCON-1716 API fails with CommunicationsException when mysql interaction time is longer than 53,434,939 milliseconds (By Pavan Kolamuri)


Project: http://git-wip-us.apache.org/repos/asf/falcon/repo
Commit: http://git-wip-us.apache.org/repos/asf/falcon/commit/a86ddb0b
Tree: http://git-wip-us.apache.org/repos/asf/falcon/tree/a86ddb0b
Diff: http://git-wip-us.apache.org/repos/asf/falcon/diff/a86ddb0b

Branch: refs/heads/master
Commit: a86ddb0bd1c0f0e21ace590cc65f27f673cb7875
Parents: 32f1da6
Author: Pallavi Rao <pa...@inmobi.com>
Authored: Fri Jan 22 16:31:54 2016 +0530
Committer: Pallavi Rao <pa...@inmobi.com>
Committed: Fri Jan 22 16:31:54 2016 +0530

----------------------------------------------------------------------
 CHANGES.txt                                                       | 2 ++
 .../org/apache/falcon/state/store/service/FalconJPAService.java   | 2 +-
 src/conf/statestore.properties                                    | 3 ++-
 3 files changed, 5 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/falcon/blob/a86ddb0b/CHANGES.txt
----------------------------------------------------------------------
diff --git a/CHANGES.txt b/CHANGES.txt
index 23c8b99..54ab9b7 100755
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -120,6 +120,8 @@ Proposed Release Version: 0.9
   OPTIMIZATIONS
 
   BUG FIXES
+    FALCON-1716 API fails with CommunicationsException when mysql interaction time is longer than 53,434,939 milliseconds (Pavan Kolamuri via Pallavi Rao)
+
     FALCON-1757 EntityNotRegisteredException when entity is deleted from falcon (Pavan Kolamuri via Pallavi Rao)
 
     FALCON-1748 Client throws FalconWebException irrespective of type of error(Praveen Adlakha via Ajay Yadava)

http://git-wip-us.apache.org/repos/asf/falcon/blob/a86ddb0b/scheduler/src/main/java/org/apache/falcon/state/store/service/FalconJPAService.java
----------------------------------------------------------------------
diff --git a/scheduler/src/main/java/org/apache/falcon/state/store/service/FalconJPAService.java b/scheduler/src/main/java/org/apache/falcon/state/store/service/FalconJPAService.java
index f678a6f..027a8ef 100644
--- a/scheduler/src/main/java/org/apache/falcon/state/store/service/FalconJPAService.java
+++ b/scheduler/src/main/java/org/apache/falcon/state/store/service/FalconJPAService.java
@@ -139,7 +139,7 @@ public final class FalconJPAService implements FalconService {
             String interval = "timeBetweenEvictionRunsMillis=" + evictionInterval;
             String num = "numTestsPerEvictionRun=" + evictionNum;
             connProps += ",TestOnBorrow=true,TestOnReturn=true,TestWhileIdle=true," + interval + "," + num;
-            connProps += ",ValidationQuery=select count(*) from ENTITIES";
+            connProps += ",ValidationQuery=select 1";
             connProps = MessageFormat.format(connProps, dbSchema);
         } else {
             connProps += ",TestOnBorrow=false,TestOnReturn=false,TestWhileIdle=false";

http://git-wip-us.apache.org/repos/asf/falcon/blob/a86ddb0b/src/conf/statestore.properties
----------------------------------------------------------------------
diff --git a/src/conf/statestore.properties b/src/conf/statestore.properties
index 0c912ad..de5ad8f 100644
--- a/src/conf/statestore.properties
+++ b/src/conf/statestore.properties
@@ -42,4 +42,5 @@
 ## Creates Falcon DB.
 ## If set to true, it creates the DB schema if it does not exist. If the DB schema exists is a NOP.
 ## If set to false, it does not create the DB schema. If the DB schema does not exist it fails start up.
-#*.falcon.statestore.create.db.schema=true
\ No newline at end of file
+## In production environments it is recommended not to change this property,create schema using tool provided by falcon.
+#*.falcon.statestore.create.db.schema=false
\ No newline at end of file