You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "Pratyaksh Sharma (Jira)" <ji...@apache.org> on 2019/11/26 11:14:00 UTC

[jira] [Updated] (HUDI-368) Code clean up in TestAsyncCompaction class

     [ https://issues.apache.org/jira/browse/HUDI-368?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Pratyaksh Sharma updated HUDI-368:
----------------------------------
    Description: 
TestAsyncCompaction class has a lot of redundant method calls, or lambda functions which can be simplified further. 

 

For example -> 

assertFalse("Verify all file-slices have no log-files",
 fileSliceList.stream().filter(fs -> fs.getLogFiles().count() > 0).findAny().isPresent());

can be simplified as - 

assertFalse("Verify all file-slices have no log-files",
 fileSliceList.stream().anyMatch(fs -> fs.getLogFiles().count() > 0));

  was:TestAsyncCompaction class has a lot of redundant method calls, or lambda functions which can be simplified further. 


> Code clean up in TestAsyncCompaction class
> ------------------------------------------
>
>                 Key: HUDI-368
>                 URL: https://issues.apache.org/jira/browse/HUDI-368
>             Project: Apache Hudi (incubating)
>          Issue Type: Improvement
>          Components: Compaction
>            Reporter: Pratyaksh Sharma
>            Assignee: Pratyaksh Sharma
>            Priority: Major
>              Labels: newbie
>             Fix For: 0.5.1
>
>
> TestAsyncCompaction class has a lot of redundant method calls, or lambda functions which can be simplified further. 
>  
> For example -> 
> assertFalse("Verify all file-slices have no log-files",
>  fileSliceList.stream().filter(fs -> fs.getLogFiles().count() > 0).findAny().isPresent());
> can be simplified as - 
> assertFalse("Verify all file-slices have no log-files",
>  fileSliceList.stream().anyMatch(fs -> fs.getLogFiles().count() > 0));



--
This message was sent by Atlassian Jira
(v8.3.4#803005)