You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by Sijie Guo <gu...@gmail.com> on 2017/08/01 06:40:36 UTC
code freeze for 4.5.0
We've tried to clean up most of the issues marked for 4.5.0. I'd like to
call a code freeze for 4.5.0. So no more issues/jiras should be marked in
4.5.0, unless it is really needed (e.g. bug fixes).
Any new features should be marked as 4.6.0. I will work with JV to prepare
the 4.5 branch for release.
If I miss anything critical that needs to be in 4.5.0, please point them
out.
Thanks,
Sijie
Re: code freeze for 4.5.0
Posted by Sijie Guo <gu...@gmail.com>.
All the issues on jira are resolved for 4.5.0.
There are 10 issues on Github still open:
https://github.com/apache/bookkeeper/milestone/1
Most of them are documentation or release related tasks. There are
documentation need for highlighted features for 4.5.0 release, if you are
the feature contributor and have time, it would be great that you can help
write the documentation.
The hightlighted features in 4.5.0 are
public api
- LedgerHandleAdv
- Explicit LAC
- Long Poll
performance
- delay ensemble change
- parallel ledger recovery
- multiple journals
- netty 4 upgrade
extensions/operations
- LongHierarchicalLedgerManager
- weight-based placement policy
security
- encryption and authentication using TLS
- SASL authentication
- zookeeper authentication
- Sijie
On Mon, Jul 31, 2017 at 11:59 PM, Enrico Olivelli <eo...@gmail.com>
wrote:
> 2017-08-01 8:58 GMT+02:00 Sijie Guo <gu...@gmail.com>:
>
> > On Mon, Jul 31, 2017 at 11:53 PM, Enrico Olivelli <eo...@gmail.com>
> > wrote:
> >
> > > Thank you Sijie
> > > from my point of view the HttpServer is ready to go, will we include it
> > in
> > > 4.5 in your opinion ?
> > >
> >
> > It is an isolated feature and off by default. I think it can go in 4.5
> but
> > we probably don't announce it in 4.5, but anyone who want to try out can
> > enable it.
> >
>
>
> OK
> thank you
> -- Enrico
>
>
> >
> >
> > >
> > > -- Enrico
> > >
> > > 2017-08-01 8:51 GMT+02:00 Sijie Guo <gu...@gmail.com>:
> > >
> > > > On Mon, Jul 31, 2017 at 11:43 PM, Enrico Olivelli <
> eolivelli@gmail.com
> > >
> > > > wrote:
> > > >
> > > > > Great!
> > > > >
> > > > > some questions:
> > > > > - TLS support ? will this be in ?
> > > > >
> > > >
> > > > Yes. TLS will be in.
> > > >
> > > >
> > > > > - There are a lot of flaky or constantly failing tests, shall we
> fix
> > > all
> > > > of
> > > > > them before preparing switching the master to 4.6 ?
> > > > >
> > > >
> > > > Yes. We need to fix them. However cutting a 4.5 branch doesn't need
> to
> > be
> > > > blocked on it.
> > > >
> > > > If we cut 4.5, any fixes going forward has to be cherry-picked to 4.5
> > > > branch.
> > > >
> > > > Also, if the tests are only flaky on CI and passed most of time
> > locally,
> > > > I'd prefer not mark them as blockers.
> > > >
> > > >
> > > > >
> > > > > I hope that most of us are testing current 4.5 snapshots against
> > their
> > > > > applications in order to find regression
> > > > > I we switch the master to 4.6 I can take care of continuing to push
> > > > > manually the 4.5 snapshots
> > > > >
> > > >
> > > > I don't know if we need to do that, because we are anyway in 4.5
> > release
> > > > procedure.
> > > >
> > > >
> > > > >
> > > > > -- Enrico
> > > > >
> > > > >
> > > > > 2017-08-01 8:40 GMT+02:00 Sijie Guo <gu...@gmail.com>:
> > > > >
> > > > > > We've tried to clean up most of the issues marked for 4.5.0. I'd
> > like
> > > > to
> > > > > > call a code freeze for 4.5.0. So no more issues/jiras should be
> > > marked
> > > > in
> > > > > > 4.5.0, unless it is really needed (e.g. bug fixes).
> > > > > >
> > > > > > Any new features should be marked as 4.6.0. I will work with JV
> to
> > > > > prepare
> > > > > > the 4.5 branch for release.
> > > > > >
> > > > > > If I miss anything critical that needs to be in 4.5.0, please
> point
> > > > them
> > > > > > out.
> > > > > >
> > > > > > Thanks,
> > > > > >
> > > > > > Sijie
> > > > > >
> > > > >
> > > >
> > >
> >
>
Re: code freeze for 4.5.0
Posted by Enrico Olivelli <eo...@gmail.com>.
2017-08-01 8:58 GMT+02:00 Sijie Guo <gu...@gmail.com>:
> On Mon, Jul 31, 2017 at 11:53 PM, Enrico Olivelli <eo...@gmail.com>
> wrote:
>
> > Thank you Sijie
> > from my point of view the HttpServer is ready to go, will we include it
> in
> > 4.5 in your opinion ?
> >
>
> It is an isolated feature and off by default. I think it can go in 4.5 but
> we probably don't announce it in 4.5, but anyone who want to try out can
> enable it.
>
OK
thank you
-- Enrico
>
>
> >
> > -- Enrico
> >
> > 2017-08-01 8:51 GMT+02:00 Sijie Guo <gu...@gmail.com>:
> >
> > > On Mon, Jul 31, 2017 at 11:43 PM, Enrico Olivelli <eolivelli@gmail.com
> >
> > > wrote:
> > >
> > > > Great!
> > > >
> > > > some questions:
> > > > - TLS support ? will this be in ?
> > > >
> > >
> > > Yes. TLS will be in.
> > >
> > >
> > > > - There are a lot of flaky or constantly failing tests, shall we fix
> > all
> > > of
> > > > them before preparing switching the master to 4.6 ?
> > > >
> > >
> > > Yes. We need to fix them. However cutting a 4.5 branch doesn't need to
> be
> > > blocked on it.
> > >
> > > If we cut 4.5, any fixes going forward has to be cherry-picked to 4.5
> > > branch.
> > >
> > > Also, if the tests are only flaky on CI and passed most of time
> locally,
> > > I'd prefer not mark them as blockers.
> > >
> > >
> > > >
> > > > I hope that most of us are testing current 4.5 snapshots against
> their
> > > > applications in order to find regression
> > > > I we switch the master to 4.6 I can take care of continuing to push
> > > > manually the 4.5 snapshots
> > > >
> > >
> > > I don't know if we need to do that, because we are anyway in 4.5
> release
> > > procedure.
> > >
> > >
> > > >
> > > > -- Enrico
> > > >
> > > >
> > > > 2017-08-01 8:40 GMT+02:00 Sijie Guo <gu...@gmail.com>:
> > > >
> > > > > We've tried to clean up most of the issues marked for 4.5.0. I'd
> like
> > > to
> > > > > call a code freeze for 4.5.0. So no more issues/jiras should be
> > marked
> > > in
> > > > > 4.5.0, unless it is really needed (e.g. bug fixes).
> > > > >
> > > > > Any new features should be marked as 4.6.0. I will work with JV to
> > > > prepare
> > > > > the 4.5 branch for release.
> > > > >
> > > > > If I miss anything critical that needs to be in 4.5.0, please point
> > > them
> > > > > out.
> > > > >
> > > > > Thanks,
> > > > >
> > > > > Sijie
> > > > >
> > > >
> > >
> >
>
Re: code freeze for 4.5.0
Posted by Sijie Guo <gu...@gmail.com>.
On Mon, Jul 31, 2017 at 11:53 PM, Enrico Olivelli <eo...@gmail.com>
wrote:
> Thank you Sijie
> from my point of view the HttpServer is ready to go, will we include it in
> 4.5 in your opinion ?
>
It is an isolated feature and off by default. I think it can go in 4.5 but
we probably don't announce it in 4.5, but anyone who want to try out can
enable it.
>
> -- Enrico
>
> 2017-08-01 8:51 GMT+02:00 Sijie Guo <gu...@gmail.com>:
>
> > On Mon, Jul 31, 2017 at 11:43 PM, Enrico Olivelli <eo...@gmail.com>
> > wrote:
> >
> > > Great!
> > >
> > > some questions:
> > > - TLS support ? will this be in ?
> > >
> >
> > Yes. TLS will be in.
> >
> >
> > > - There are a lot of flaky or constantly failing tests, shall we fix
> all
> > of
> > > them before preparing switching the master to 4.6 ?
> > >
> >
> > Yes. We need to fix them. However cutting a 4.5 branch doesn't need to be
> > blocked on it.
> >
> > If we cut 4.5, any fixes going forward has to be cherry-picked to 4.5
> > branch.
> >
> > Also, if the tests are only flaky on CI and passed most of time locally,
> > I'd prefer not mark them as blockers.
> >
> >
> > >
> > > I hope that most of us are testing current 4.5 snapshots against their
> > > applications in order to find regression
> > > I we switch the master to 4.6 I can take care of continuing to push
> > > manually the 4.5 snapshots
> > >
> >
> > I don't know if we need to do that, because we are anyway in 4.5 release
> > procedure.
> >
> >
> > >
> > > -- Enrico
> > >
> > >
> > > 2017-08-01 8:40 GMT+02:00 Sijie Guo <gu...@gmail.com>:
> > >
> > > > We've tried to clean up most of the issues marked for 4.5.0. I'd like
> > to
> > > > call a code freeze for 4.5.0. So no more issues/jiras should be
> marked
> > in
> > > > 4.5.0, unless it is really needed (e.g. bug fixes).
> > > >
> > > > Any new features should be marked as 4.6.0. I will work with JV to
> > > prepare
> > > > the 4.5 branch for release.
> > > >
> > > > If I miss anything critical that needs to be in 4.5.0, please point
> > them
> > > > out.
> > > >
> > > > Thanks,
> > > >
> > > > Sijie
> > > >
> > >
> >
>
Re: code freeze for 4.5.0
Posted by Enrico Olivelli <eo...@gmail.com>.
Thank you Sijie
from my point of view the HttpServer is ready to go, will we include it in
4.5 in your opinion ?
-- Enrico
2017-08-01 8:51 GMT+02:00 Sijie Guo <gu...@gmail.com>:
> On Mon, Jul 31, 2017 at 11:43 PM, Enrico Olivelli <eo...@gmail.com>
> wrote:
>
> > Great!
> >
> > some questions:
> > - TLS support ? will this be in ?
> >
>
> Yes. TLS will be in.
>
>
> > - There are a lot of flaky or constantly failing tests, shall we fix all
> of
> > them before preparing switching the master to 4.6 ?
> >
>
> Yes. We need to fix them. However cutting a 4.5 branch doesn't need to be
> blocked on it.
>
> If we cut 4.5, any fixes going forward has to be cherry-picked to 4.5
> branch.
>
> Also, if the tests are only flaky on CI and passed most of time locally,
> I'd prefer not mark them as blockers.
>
>
> >
> > I hope that most of us are testing current 4.5 snapshots against their
> > applications in order to find regression
> > I we switch the master to 4.6 I can take care of continuing to push
> > manually the 4.5 snapshots
> >
>
> I don't know if we need to do that, because we are anyway in 4.5 release
> procedure.
>
>
> >
> > -- Enrico
> >
> >
> > 2017-08-01 8:40 GMT+02:00 Sijie Guo <gu...@gmail.com>:
> >
> > > We've tried to clean up most of the issues marked for 4.5.0. I'd like
> to
> > > call a code freeze for 4.5.0. So no more issues/jiras should be marked
> in
> > > 4.5.0, unless it is really needed (e.g. bug fixes).
> > >
> > > Any new features should be marked as 4.6.0. I will work with JV to
> > prepare
> > > the 4.5 branch for release.
> > >
> > > If I miss anything critical that needs to be in 4.5.0, please point
> them
> > > out.
> > >
> > > Thanks,
> > >
> > > Sijie
> > >
> >
>
Re: code freeze for 4.5.0
Posted by Sijie Guo <gu...@gmail.com>.
On Mon, Jul 31, 2017 at 11:43 PM, Enrico Olivelli <eo...@gmail.com>
wrote:
> Great!
>
> some questions:
> - TLS support ? will this be in ?
>
Yes. TLS will be in.
> - There are a lot of flaky or constantly failing tests, shall we fix all of
> them before preparing switching the master to 4.6 ?
>
Yes. We need to fix them. However cutting a 4.5 branch doesn't need to be
blocked on it.
If we cut 4.5, any fixes going forward has to be cherry-picked to 4.5
branch.
Also, if the tests are only flaky on CI and passed most of time locally,
I'd prefer not mark them as blockers.
>
> I hope that most of us are testing current 4.5 snapshots against their
> applications in order to find regression
> I we switch the master to 4.6 I can take care of continuing to push
> manually the 4.5 snapshots
>
I don't know if we need to do that, because we are anyway in 4.5 release
procedure.
>
> -- Enrico
>
>
> 2017-08-01 8:40 GMT+02:00 Sijie Guo <gu...@gmail.com>:
>
> > We've tried to clean up most of the issues marked for 4.5.0. I'd like to
> > call a code freeze for 4.5.0. So no more issues/jiras should be marked in
> > 4.5.0, unless it is really needed (e.g. bug fixes).
> >
> > Any new features should be marked as 4.6.0. I will work with JV to
> prepare
> > the 4.5 branch for release.
> >
> > If I miss anything critical that needs to be in 4.5.0, please point them
> > out.
> >
> > Thanks,
> >
> > Sijie
> >
>
Re: code freeze for 4.5.0
Posted by Enrico Olivelli <eo...@gmail.com>.
Great!
some questions:
- TLS support ? will this be in ?
- There are a lot of flaky or constantly failing tests, shall we fix all of
them before preparing switching the master to 4.6 ?
I hope that most of us are testing current 4.5 snapshots against their
applications in order to find regression
I we switch the master to 4.6 I can take care of continuing to push
manually the 4.5 snapshots
-- Enrico
2017-08-01 8:40 GMT+02:00 Sijie Guo <gu...@gmail.com>:
> We've tried to clean up most of the issues marked for 4.5.0. I'd like to
> call a code freeze for 4.5.0. So no more issues/jiras should be marked in
> 4.5.0, unless it is really needed (e.g. bug fixes).
>
> Any new features should be marked as 4.6.0. I will work with JV to prepare
> the 4.5 branch for release.
>
> If I miss anything critical that needs to be in 4.5.0, please point them
> out.
>
> Thanks,
>
> Sijie
>