You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/08/12 09:44:11 UTC
[GitHub] [skywalking] lujiajing1126 opened a new pull request #7448: Banyandb integration
lujiajing1126 opened a new pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448
- [x] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #7412
- [ ] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/CHANGES.md).
## New Design
After discussion with @hanahmily and @wu-sheng , I purpose the following new storage plugin,
The banyanDB client sits in the `org.apache.skywalking.banyandb.client` package,
1. Provide general API for query and write, which are not related to the underlying protobuf anymore,
2. Provide high level client which implementes `BanyanDBService` interface,
3. Also the client does not care about the schema defined
The plugin is now decoupled from H2/JDBC and other storage plugins. For those features unimplemented yet, blank APIs are given as stubs now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#issuecomment-897513283
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`banyandb-integration@6a241ae`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## banyandb-integration #7448 +/- ##
=======================================================
Coverage ? 58.83%
Complexity ? 4389
=======================================================
Files ? 1034
Lines ? 26565
Branches ? 2625
=======================================================
Hits ? 15630
Misses ? 9548
Partials ? 1387
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6a241ae...360972e](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#issuecomment-897513283
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`banyandb-integration@6a241ae`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
> :exclamation: Current head 8f64497 differs from pull request most recent head 6f8e95e. Consider uploading reports for the commit 6f8e95e to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## banyandb-integration #7448 +/- ##
=======================================================
Coverage ? 58.57%
Complexity ? 4370
=======================================================
Files ? 1034
Lines ? 26565
Branches ? 2625
=======================================================
Hits ? 15561
Misses ? 9632
Partials ? 1372
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6a241ae...6f8e95e](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#issuecomment-897513283
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`banyandb-integration@6a241ae`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
> :exclamation: Current head 2b48fc3 differs from pull request most recent head 738cf7c. Consider uploading reports for the commit 738cf7c to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## banyandb-integration #7448 +/- ##
=======================================================
Coverage ? 49.56%
Complexity ? 3166
=======================================================
Files ? 876
Lines ? 22570
Branches ? 2169
=======================================================
Hits ? 11187
Misses ? 10460
Partials ? 923
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6a241ae...738cf7c](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#issuecomment-897513283
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`banyandb-integration@6a241ae`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
> :exclamation: Current head 8f64497 differs from pull request most recent head 6f8e95e. Consider uploading reports for the commit 6f8e95e to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## banyandb-integration #7448 +/- ##
=======================================================
Coverage ? 55.37%
Complexity ? 4208
=======================================================
Files ? 1034
Lines ? 26563
Branches ? 2621
=======================================================
Hits ? 14710
Misses ? 10574
Partials ? 1279
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6a241ae...6f8e95e](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] lujiajing1126 commented on a change in pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
lujiajing1126 commented on a change in pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#discussion_r688263283
##########
File path: oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/banyandb/dao/BanyanDBRecordDAO.java
##########
@@ -0,0 +1,75 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.server.storage.plugin.banyandb.dao;
+
+import lombok.RequiredArgsConstructor;
+import org.apache.skywalking.banyandb.client.request.WriteValue;
+import org.apache.skywalking.oap.server.storage.plugin.banyandb.BanyanDBSchema;
+import org.apache.skywalking.banyandb.client.request.TraceWriteRequest;
+import org.apache.skywalking.oap.server.core.analysis.manual.segment.SegmentRecord;
+import org.apache.skywalking.oap.server.core.analysis.record.Record;
+import org.apache.skywalking.oap.server.core.storage.IRecordDAO;
+import org.apache.skywalking.oap.server.core.storage.StorageHashMapBuilder;
+import org.apache.skywalking.oap.server.core.storage.model.Model;
+import org.apache.skywalking.oap.server.library.client.request.InsertRequest;
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Map;
+
+@RequiredArgsConstructor
+public class BanyanDBRecordDAO implements IRecordDAO {
+ private final StorageHashMapBuilder<Record> storageBuilder;
+
+ @Override
+ public InsertRequest prepareBatchInsert(Model model, Record record) throws IOException {
+ if (SegmentRecord.INDEX_NAME.equals(model.getName())) {
+ SegmentRecord segmentRecord = (SegmentRecord) record;
+ TraceWriteRequest request = TraceWriteRequest.builder()
+ .dataBinary(segmentRecord.getDataBinary())
+ .timestampSeconds(record.getTimeBucket())
Review comment:
I see. Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#issuecomment-897513283
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`banyandb-integration@6a241ae`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
> :exclamation: Current head 2b48fc3 differs from pull request most recent head 738cf7c. Consider uploading reports for the commit 738cf7c to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## banyandb-integration #7448 +/- ##
=======================================================
Coverage ? 46.56%
Complexity ? 3021
=======================================================
Files ? 876
Lines ? 22474
Branches ? 2160
=======================================================
Hits ? 10464
Misses ? 11149
Partials ? 861
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6a241ae...738cf7c](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#issuecomment-897513283
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`banyandb-integration@6a241ae`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
> :exclamation: Current head 8f64497 differs from pull request most recent head d576aa9. Consider uploading reports for the commit d576aa9 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## banyandb-integration #7448 +/- ##
=======================================================
Coverage ? 58.64%
Complexity ? 4374
=======================================================
Files ? 1034
Lines ? 26565
Branches ? 2625
=======================================================
Hits ? 15580
Misses ? 9607
Partials ? 1378
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6a241ae...d576aa9](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#issuecomment-897513283
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`banyandb-integration@6a241ae`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
> :exclamation: Current head 8f64497 differs from pull request most recent head 6f8e95e. Consider uploading reports for the commit 6f8e95e to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## banyandb-integration #7448 +/- ##
=======================================================
Coverage ? 56.48%
Complexity ? 4261
=======================================================
Files ? 1034
Lines ? 26565
Branches ? 2625
=======================================================
Hits ? 15004
Misses ? 10234
Partials ? 1327
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6a241ae...6f8e95e](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#issuecomment-897513283
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`banyandb-integration@6a241ae`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## banyandb-integration #7448 +/- ##
=======================================================
Coverage ? 54.84%
Complexity ? 4184
=======================================================
Files ? 1034
Lines ? 26546
Branches ? 2620
=======================================================
Hits ? 14559
Misses ? 10690
Partials ? 1297
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6a241ae...360972e](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#issuecomment-897513283
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`banyandb-integration@6a241ae`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
> :exclamation: Current head e4dbd20 differs from pull request most recent head 0c80a8a. Consider uploading reports for the commit 0c80a8a to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## banyandb-integration #7448 +/- ##
=======================================================
Coverage ? 51.02%
Complexity ? 3957
=======================================================
Files ? 1034
Lines ? 26497
Branches ? 2614
=======================================================
Hits ? 13519
Misses ? 11785
Partials ? 1193
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6a241ae...0c80a8a](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] lujiajing1126 commented on a change in pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
lujiajing1126 commented on a change in pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#discussion_r688204668
##########
File path: oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/banyandb/client/impl/BanyanDBGrpcClient.java
##########
@@ -0,0 +1,173 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.banyandb.client.impl;
+
+import com.google.common.annotations.VisibleForTesting;
+import com.google.protobuf.ByteString;
+import com.google.protobuf.NullValue;
+import com.google.protobuf.Timestamp;
+import io.grpc.ManagedChannel;
+import io.grpc.stub.StreamObserver;
+import lombok.extern.slf4j.Slf4j;
+import org.apache.skywalking.banyandb.Database;
+import org.apache.skywalking.banyandb.Query;
+import org.apache.skywalking.banyandb.TraceServiceGrpc;
+import org.apache.skywalking.banyandb.Write;
+import org.apache.skywalking.banyandb.client.BanyanDBService;
+import org.apache.skywalking.banyandb.client.request.TraceFetchRequest;
+import org.apache.skywalking.banyandb.client.request.TraceSearchRequest;
+import org.apache.skywalking.banyandb.client.request.TraceWriteRequest;
+import org.apache.skywalking.banyandb.client.response.BanyanDBEntity;
+import org.apache.skywalking.banyandb.client.response.BanyanDBQueryResponse;
+
+import java.util.List;
+import java.util.concurrent.TimeUnit;
+import java.util.stream.Collectors;
+
+@Slf4j
+public class BanyanDBGrpcClient implements BanyanDBService {
+ private final TraceServiceGrpc.TraceServiceBlockingStub stub;
+ private final TraceServiceGrpc.TraceServiceStub asyncStub;
+
+ public BanyanDBGrpcClient(ManagedChannel managedChannel) {
+ this.stub = TraceServiceGrpc.newBlockingStub(managedChannel);
+ this.asyncStub = TraceServiceGrpc.newStub(managedChannel);
+ }
+
+ @Override
+ public BanyanDBQueryResponse queryBasicTraces(TraceSearchRequest request) {
+ Query.QueryRequest.Builder queryBuilder = Query.QueryRequest.newBuilder()
+ .setMetadata(Database.Metadata.newBuilder().setGroup(request.getGroup()).setName(request.getName()).build());
+
+ if (request.getTimeRange() != null && request.getTimeRange().getStartTime() != 0 && request.getTimeRange().getEndTime() != 0) {
+ queryBuilder.setTimeRange(Query.TimeRange.newBuilder()
+ .setBegin(Timestamp.newBuilder().setSeconds(request.getTimeRange().getStartTime()))
+ .setEnd(Timestamp.newBuilder().setSeconds(request.getTimeRange().getEndTime())).build());
+ }
+
+ request.getQueries().forEach(q -> queryBuilder.addFields(q.toPairQuery()));
+
+ queryBuilder.setOrderBy(Query.QueryOrder.newBuilder()
+ .setKeyName(request.getQueryOrderField())
+ .setSort(request.getQueryOrderSort().getSort())
+ .build());
+
+ queryBuilder.setProjection(Query.Projection.newBuilder()
+ .addAllKeyNames(request.getProjections())
+ .build());
+ queryBuilder.setLimit(request.getLimit());
+ queryBuilder.setOffset(request.getOffset());
+
+ return convertToResponse(this.stub.query(queryBuilder.build()));
+ }
+
+ @Override
+ public BanyanDBQueryResponse queryByTraceId(TraceFetchRequest traceFetchRequest) {
+ Query.QueryRequest.Builder queryBuilder = Query.QueryRequest.newBuilder()
+ .setMetadata(Database.Metadata.newBuilder().setGroup(traceFetchRequest.getGroup()).setName(traceFetchRequest.getName()).build())
+ .addFields(Query.PairQuery.newBuilder()
+ .setOp(Query.PairQuery.BinaryOp.BINARY_OP_EQ)
+ .setCondition(Query.TypedPair.newBuilder().setStrPair(Query.StrPair.newBuilder().setKey("trace_id").addValues(traceFetchRequest.getTraceId()).build()))
+ .build())
+ .setProjection(Query.Projection.newBuilder()
+ .addAllKeyNames(traceFetchRequest.getProjections())
+ .build());
+ return convertToResponse(this.stub.query(queryBuilder.build()));
+ }
+
+ static BanyanDBQueryResponse convertToResponse(Query.QueryResponse response) {
+ BanyanDBQueryResponse r = new BanyanDBQueryResponse();
+ r.setTotal(response.getEntitiesCount());
+ for (final Query.Entity entity : response.getEntitiesList()) {
+ BanyanDBEntity.BanyanDBEntityBuilder entityBuilder = BanyanDBEntity.builder();
+ for (final Query.TypedPair typedPair : entity.getFieldsList()) {
+ if (typedPair.hasIntPair()) {
+ final Query.IntPair pair = typedPair.getIntPair();
+ entityBuilder.field(pair.getKey(), pair.getValuesList().get(0));
+ } else if (typedPair.hasStrPair()) {
+ final Query.StrPair pair = typedPair.getStrPair();
+ entityBuilder.field(pair.getKey(), pair.getValuesList().get(0));
+ }
+ }
+ entityBuilder.entityId(entity.getEntityId());
+ entityBuilder.binaryData(entity.getDataBinary().toByteArray());
+ entityBuilder.timestampSeconds(entity.getTimestamp().getSeconds());
+ entityBuilder.timestampNanoSeconds(entity.getTimestamp().getNanos());
+ r.getEntities().add(entityBuilder.build());
+ }
+
+ return r;
+ }
+
+ @Override
+ public void writeEntity(List<TraceWriteRequest> data) {
+ StreamObserver<org.apache.skywalking.banyandb.Write.WriteRequest> observer = this.asyncStub.withDeadlineAfter(30, TimeUnit.SECONDS)
+ .write(new StreamObserver<Write.WriteResponse>() {
+ @Override
+ public void onNext(Write.WriteResponse writeResponse) {
+ }
+
+ @Override
+ public void onError(Throwable throwable) {
+ log.error("fail to send request", throwable);
+ }
+
+ @Override
+ public void onCompleted() {
+ }
+ });
+
+ for (final TraceWriteRequest entity : data) {
+ try {
+ Write.EntityValue entityValue = Write.EntityValue.newBuilder()
+ .addAllFields(buildWriteFields(entity.getFields()))
Review comment:
Done. Use typed API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#discussion_r687670855
##########
File path: oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/banyandb/client/impl/BanyanDBGrpcClient.java
##########
@@ -0,0 +1,173 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.banyandb.client.impl;
+
+import com.google.common.annotations.VisibleForTesting;
+import com.google.protobuf.ByteString;
+import com.google.protobuf.NullValue;
+import com.google.protobuf.Timestamp;
+import io.grpc.ManagedChannel;
+import io.grpc.stub.StreamObserver;
+import lombok.extern.slf4j.Slf4j;
+import org.apache.skywalking.banyandb.Database;
+import org.apache.skywalking.banyandb.Query;
+import org.apache.skywalking.banyandb.TraceServiceGrpc;
+import org.apache.skywalking.banyandb.Write;
+import org.apache.skywalking.banyandb.client.BanyanDBService;
+import org.apache.skywalking.banyandb.client.request.TraceFetchRequest;
+import org.apache.skywalking.banyandb.client.request.TraceSearchRequest;
+import org.apache.skywalking.banyandb.client.request.TraceWriteRequest;
+import org.apache.skywalking.banyandb.client.response.BanyanDBEntity;
+import org.apache.skywalking.banyandb.client.response.BanyanDBQueryResponse;
+
+import java.util.List;
+import java.util.concurrent.TimeUnit;
+import java.util.stream.Collectors;
+
+@Slf4j
+public class BanyanDBGrpcClient implements BanyanDBService {
+ private final TraceServiceGrpc.TraceServiceBlockingStub stub;
+ private final TraceServiceGrpc.TraceServiceStub asyncStub;
+
+ public BanyanDBGrpcClient(ManagedChannel managedChannel) {
+ this.stub = TraceServiceGrpc.newBlockingStub(managedChannel);
+ this.asyncStub = TraceServiceGrpc.newStub(managedChannel);
+ }
+
+ @Override
+ public BanyanDBQueryResponse queryBasicTraces(TraceSearchRequest request) {
+ Query.QueryRequest.Builder queryBuilder = Query.QueryRequest.newBuilder()
+ .setMetadata(Database.Metadata.newBuilder().setGroup(request.getGroup()).setName(request.getName()).build());
+
+ if (request.getTimeRange() != null && request.getTimeRange().getStartTime() != 0 && request.getTimeRange().getEndTime() != 0) {
+ queryBuilder.setTimeRange(Query.TimeRange.newBuilder()
+ .setBegin(Timestamp.newBuilder().setSeconds(request.getTimeRange().getStartTime()))
+ .setEnd(Timestamp.newBuilder().setSeconds(request.getTimeRange().getEndTime())).build());
+ }
+
+ request.getQueries().forEach(q -> queryBuilder.addFields(q.toPairQuery()));
+
+ queryBuilder.setOrderBy(Query.QueryOrder.newBuilder()
+ .setKeyName(request.getQueryOrderField())
+ .setSort(request.getQueryOrderSort().getSort())
+ .build());
+
+ queryBuilder.setProjection(Query.Projection.newBuilder()
+ .addAllKeyNames(request.getProjections())
+ .build());
+ queryBuilder.setLimit(request.getLimit());
+ queryBuilder.setOffset(request.getOffset());
+
+ return convertToResponse(this.stub.query(queryBuilder.build()));
+ }
+
+ @Override
+ public BanyanDBQueryResponse queryByTraceId(TraceFetchRequest traceFetchRequest) {
+ Query.QueryRequest.Builder queryBuilder = Query.QueryRequest.newBuilder()
+ .setMetadata(Database.Metadata.newBuilder().setGroup(traceFetchRequest.getGroup()).setName(traceFetchRequest.getName()).build())
+ .addFields(Query.PairQuery.newBuilder()
+ .setOp(Query.PairQuery.BinaryOp.BINARY_OP_EQ)
+ .setCondition(Query.TypedPair.newBuilder().setStrPair(Query.StrPair.newBuilder().setKey("trace_id").addValues(traceFetchRequest.getTraceId()).build()))
+ .build())
+ .setProjection(Query.Projection.newBuilder()
+ .addAllKeyNames(traceFetchRequest.getProjections())
+ .build());
+ return convertToResponse(this.stub.query(queryBuilder.build()));
+ }
+
+ static BanyanDBQueryResponse convertToResponse(Query.QueryResponse response) {
+ BanyanDBQueryResponse r = new BanyanDBQueryResponse();
+ r.setTotal(response.getEntitiesCount());
+ for (final Query.Entity entity : response.getEntitiesList()) {
+ BanyanDBEntity.BanyanDBEntityBuilder entityBuilder = BanyanDBEntity.builder();
+ for (final Query.TypedPair typedPair : entity.getFieldsList()) {
+ if (typedPair.hasIntPair()) {
+ final Query.IntPair pair = typedPair.getIntPair();
+ entityBuilder.field(pair.getKey(), pair.getValuesList().get(0));
+ } else if (typedPair.hasStrPair()) {
+ final Query.StrPair pair = typedPair.getStrPair();
+ entityBuilder.field(pair.getKey(), pair.getValuesList().get(0));
+ }
+ }
+ entityBuilder.entityId(entity.getEntityId());
+ entityBuilder.binaryData(entity.getDataBinary().toByteArray());
+ entityBuilder.timestampSeconds(entity.getTimestamp().getSeconds());
+ entityBuilder.timestampNanoSeconds(entity.getTimestamp().getNanos());
+ r.getEntities().add(entityBuilder.build());
+ }
+
+ return r;
+ }
+
+ @Override
+ public void writeEntity(List<TraceWriteRequest> data) {
+ StreamObserver<org.apache.skywalking.banyandb.Write.WriteRequest> observer = this.asyncStub.withDeadlineAfter(30, TimeUnit.SECONDS)
+ .write(new StreamObserver<Write.WriteResponse>() {
+ @Override
+ public void onNext(Write.WriteResponse writeResponse) {
+ }
+
+ @Override
+ public void onError(Throwable throwable) {
+ log.error("fail to send request", throwable);
+ }
+
+ @Override
+ public void onCompleted() {
+ }
+ });
+
+ for (final TraceWriteRequest entity : data) {
+ try {
+ Write.EntityValue entityValue = Write.EntityValue.newBuilder()
+ .addAllFields(buildWriteFields(entity.getFields()))
Review comment:
Don't use like this. `get whole list`, then `iterating`, and `instance of` for every element.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#issuecomment-897513283
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`banyandb-integration@6a241ae`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
> :exclamation: Current head 8f64497 differs from pull request most recent head 6f8e95e. Consider uploading reports for the commit 6f8e95e to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## banyandb-integration #7448 +/- ##
=======================================================
Coverage ? 58.64%
Complexity ? 4374
=======================================================
Files ? 1034
Lines ? 26565
Branches ? 2625
=======================================================
Hits ? 15580
Misses ? 9607
Partials ? 1378
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6a241ae...6f8e95e](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#issuecomment-897513283
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`banyandb-integration@6a241ae`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
> :exclamation: Current head e4dbd20 differs from pull request most recent head 0c80a8a. Consider uploading reports for the commit 0c80a8a to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## banyandb-integration #7448 +/- ##
=======================================================
Coverage ? 57.26%
Complexity ? 4309
=======================================================
Files ? 1034
Lines ? 26555
Branches ? 2624
=======================================================
Hits ? 15206
Misses ? 10006
Partials ? 1343
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6a241ae...0c80a8a](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#issuecomment-897610530
I put many comments, but not all. @hanahmily I am not sure what code style is required in BanyanDB codebase, but this PR is not ready from main repo's requirements.
All API level methods should have formal comments to describe usage, and meaning of parameters and return value. Even include how and where should use this APIs.
My major requirements are for BanyanDB package, I would like to be very strict about this API review. Feel free even to submit a PR to submit this. Also, I recommend to move all BanyanDB client source codes as the root module of `oap-server`. It should be `org.apache.skywalking:banyandb-java-client`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#issuecomment-897513283
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`banyandb-integration@6a241ae`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## banyandb-integration #7448 +/- ##
=======================================================
Coverage ? 28.22%
Complexity ? 1832
=======================================================
Files ? 844
Lines ? 21085
Branches ? 1981
=======================================================
Hits ? 5952
Misses ? 14686
Partials ? 447
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6a241ae...2b48fc3](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#issuecomment-897513283
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#issuecomment-897513283
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`banyandb-integration@6a241ae`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
> :exclamation: Current head e4dbd20 differs from pull request most recent head 19abf86. Consider uploading reports for the commit 19abf86 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## banyandb-integration #7448 +/- ##
=======================================================
Coverage ? 57.91%
Complexity ? 4341
=======================================================
Files ? 1034
Lines ? 26555
Branches ? 2624
=======================================================
Hits ? 15379
Misses ? 9810
Partials ? 1366
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6a241ae...19abf86](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#discussion_r688221581
##########
File path: oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/banyandb/dao/BanyanDBRecordDAO.java
##########
@@ -0,0 +1,75 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.server.storage.plugin.banyandb.dao;
+
+import lombok.RequiredArgsConstructor;
+import org.apache.skywalking.banyandb.client.request.WriteValue;
+import org.apache.skywalking.oap.server.storage.plugin.banyandb.BanyanDBSchema;
+import org.apache.skywalking.banyandb.client.request.TraceWriteRequest;
+import org.apache.skywalking.oap.server.core.analysis.manual.segment.SegmentRecord;
+import org.apache.skywalking.oap.server.core.analysis.record.Record;
+import org.apache.skywalking.oap.server.core.storage.IRecordDAO;
+import org.apache.skywalking.oap.server.core.storage.StorageHashMapBuilder;
+import org.apache.skywalking.oap.server.core.storage.model.Model;
+import org.apache.skywalking.oap.server.library.client.request.InsertRequest;
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Map;
+
+@RequiredArgsConstructor
+public class BanyanDBRecordDAO implements IRecordDAO {
+ private final StorageHashMapBuilder<Record> storageBuilder;
+
+ @Override
+ public InsertRequest prepareBatchInsert(Model model, Record record) throws IOException {
+ if (SegmentRecord.INDEX_NAME.equals(model.getName())) {
+ SegmentRecord segmentRecord = (SegmentRecord) record;
+ TraceWriteRequest request = TraceWriteRequest.builder()
+ .dataBinary(segmentRecord.getDataBinary())
+ .timestampSeconds(record.getTimeBucket())
Review comment:
Time bucket is never being timestamp.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#issuecomment-897513283
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`banyandb-integration@6a241ae`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
> :exclamation: Current head 2417819 differs from pull request most recent head 360972e. Consider uploading reports for the commit 360972e to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## banyandb-integration #7448 +/- ##
=======================================================
Coverage ? 57.75%
Complexity ? 4335
=======================================================
Files ? 1034
Lines ? 26565
Branches ? 2625
=======================================================
Hits ? 15343
Misses ? 9881
Partials ? 1341
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6a241ae...360972e](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#issuecomment-897513283
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`banyandb-integration@6a241ae`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
> :exclamation: Current head e4dbd20 differs from pull request most recent head 0c80a8a. Consider uploading reports for the commit 0c80a8a to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## banyandb-integration #7448 +/- ##
=======================================================
Coverage ? 48.79%
Complexity ? 3814
=======================================================
Files ? 1034
Lines ? 26411
Branches ? 2606
=======================================================
Hits ? 12888
Misses ? 12391
Partials ? 1132
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6a241ae...0c80a8a](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#issuecomment-897513283
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`banyandb-integration@6a241ae`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## banyandb-integration #7448 +/- ##
=======================================================
Coverage ? 56.36%
Complexity ? 4260
=======================================================
Files ? 1034
Lines ? 26548
Branches ? 2624
=======================================================
Hits ? 14964
Misses ? 10236
Partials ? 1348
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6a241ae...360972e](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] lujiajing1126 commented on a change in pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
lujiajing1126 commented on a change in pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#discussion_r688256572
##########
File path: oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/banyandb/BanyanDBClient.java
##########
@@ -0,0 +1,125 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.server.storage.plugin.banyandb;
+
+import com.google.common.annotations.VisibleForTesting;
+import io.grpc.ManagedChannel;
+import io.grpc.ManagedChannelBuilder;
+import io.grpc.netty.NettyChannelBuilder;
+import io.netty.handler.ssl.SslContext;
+import org.apache.skywalking.banyandb.client.BanyanDBService;
+import org.apache.skywalking.banyandb.client.impl.BanyanDBGrpcClient;
+import org.apache.skywalking.banyandb.client.request.TraceFetchRequest;
+import org.apache.skywalking.banyandb.client.request.TraceSearchRequest;
+import org.apache.skywalking.banyandb.client.request.TraceWriteRequest;
+import org.apache.skywalking.banyandb.client.response.BanyanDBQueryResponse;
+import org.apache.skywalking.oap.server.library.client.Client;
+import org.apache.skywalking.oap.server.library.client.healthcheck.DelegatedHealthChecker;
+import org.apache.skywalking.oap.server.library.client.healthcheck.HealthCheckable;
+import org.apache.skywalking.oap.server.library.util.HealthChecker;
+
+import java.io.IOException;
+import java.util.List;
+import java.util.concurrent.TimeUnit;
+
+public class BanyanDBClient implements Client, BanyanDBService, HealthCheckable {
Review comment:
Done. gRPC is no longer exposed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#issuecomment-897513283
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`banyandb-integration@6a241ae`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
> :exclamation: Current head e4dbd20 differs from pull request most recent head 0c80a8a. Consider uploading reports for the commit 0c80a8a to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## banyandb-integration #7448 +/- ##
=======================================================
Coverage ? 56.97%
Complexity ? 4290
=======================================================
Files ? 1034
Lines ? 26555
Branches ? 2624
=======================================================
Hits ? 15129
Misses ? 10089
Partials ? 1337
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6a241ae...0c80a8a](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#issuecomment-897513283
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`banyandb-integration@6a241ae`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
> :exclamation: Current head 8f64497 differs from pull request most recent head 6f8e95e. Consider uploading reports for the commit 6f8e95e to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## banyandb-integration #7448 +/- ##
=======================================================
Coverage ? 58.64%
Complexity ? 4374
=======================================================
Files ? 1034
Lines ? 26565
Branches ? 2625
=======================================================
Hits ? 15580
Misses ? 9607
Partials ? 1378
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6a241ae...6f8e95e](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#discussion_r687666370
##########
File path: oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/banyandb/client/request/TraceSearchQuery.java
##########
@@ -0,0 +1,82 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.banyandb.client.request;
+
+import lombok.AccessLevel;
+import lombok.AllArgsConstructor;
+import org.apache.skywalking.banyandb.Query;
+
+@AllArgsConstructor(access = AccessLevel.PRIVATE)
+public class TraceSearchQuery {
+ private final String key;
+ private final TraceSearchRequest.BinaryOperator op;
+ private final Object value;
+ private final Query.TypedPair.TypedCase typedCase;
+
+ public Query.PairQuery toPairQuery() {
+ switch (this.typedCase) {
+ case STR_PAIR:
+ return Query.PairQuery.newBuilder()
+ .setOp(this.op.getOp())
+ .setCondition(Query.TypedPair.newBuilder().setStrPair(Query.StrPair.newBuilder().setKey(key).addValues((String) this.value).build()).build())
+ .build();
+ case INT_PAIR:
+ return Query.PairQuery.newBuilder()
+ .setOp(this.op.getOp())
+ .setCondition(Query.TypedPair.newBuilder().setIntPair(Query.IntPair.newBuilder().setKey(key).addValues((Long) this.value).build()).build())
+ .build();
+ default:
+ throw new IllegalStateException("should not reach here");
+ }
+ }
+
+ // String
+ public static TraceSearchQuery Eq(String key, String val) {
Review comment:
The function naming should follow camel. The first level is lower case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] lujiajing1126 commented on a change in pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
lujiajing1126 commented on a change in pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#discussion_r688202865
##########
File path: oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/banyandb/client/request/TraceSearchQuery.java
##########
@@ -0,0 +1,82 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.banyandb.client.request;
+
+import lombok.AccessLevel;
+import lombok.AllArgsConstructor;
+import org.apache.skywalking.banyandb.Query;
+
+@AllArgsConstructor(access = AccessLevel.PRIVATE)
+public class TraceSearchQuery {
+ private final String key;
+ private final TraceSearchRequest.BinaryOperator op;
+ private final Object value;
+ private final Query.TypedPair.TypedCase typedCase;
+
+ public Query.PairQuery toPairQuery() {
Review comment:
No. It is not only used in tests
##########
File path: oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/banyandb/client/request/HasMetadata.java
##########
@@ -0,0 +1,31 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.banyandb.client.request;
+
+import lombok.EqualsAndHashCode;
+import lombok.Getter;
+import lombok.experimental.SuperBuilder;
+
+@SuperBuilder
+@Getter
+@EqualsAndHashCode
+public class HasMetadata {
Review comment:
Class removed
##########
File path: oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/banyandb/client/request/TraceFetchRequest.java
##########
@@ -0,0 +1,34 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.banyandb.client.request;
+
+import lombok.Getter;
+import lombok.Singular;
+import lombok.experimental.SuperBuilder;
+
+import java.util.List;
+
+@SuperBuilder
+@Getter
+public class TraceFetchRequest extends HasMetadata {
Review comment:
Metadata moved to client
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] sonatype-lift[bot] commented on a change in pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
sonatype-lift[bot] commented on a change in pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#discussion_r687612947
##########
File path: oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/banyandb/dao/BanyanDBTraceQueryDAO.java
##########
@@ -0,0 +1,154 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.server.storage.plugin.banyandb.dao;
+
+import com.google.common.base.Strings;
+import com.google.common.collect.ImmutableSet;
+import org.apache.skywalking.banyandb.client.request.TraceFetchRequest;
+import org.apache.skywalking.banyandb.client.request.TraceSearchQuery;
+import org.apache.skywalking.banyandb.client.request.TraceSearchRequest;
+import org.apache.skywalking.banyandb.client.response.BanyanDBQueryResponse;
+import org.apache.skywalking.oap.server.core.analysis.IDManager;
+import org.apache.skywalking.oap.server.core.analysis.manual.searchtag.Tag;
+import org.apache.skywalking.oap.server.core.analysis.manual.segment.SegmentRecord;
+import org.apache.skywalking.oap.server.core.query.type.BasicTrace;
+import org.apache.skywalking.oap.server.core.query.type.QueryOrder;
+import org.apache.skywalking.oap.server.core.query.type.Span;
+import org.apache.skywalking.oap.server.core.query.type.TraceBrief;
+import org.apache.skywalking.oap.server.core.query.type.TraceState;
+import org.apache.skywalking.oap.server.core.storage.AbstractDAO;
+import org.apache.skywalking.oap.server.core.storage.query.ITraceQueryDAO;
+import org.apache.skywalking.oap.server.storage.plugin.banyandb.BanyanDBClient;
+import org.apache.skywalking.oap.server.storage.plugin.banyandb.BanyanDBSchema;
+
+import java.io.IOException;
+import java.util.Collections;
+import java.util.List;
+import java.util.Set;
+import java.util.stream.Collectors;
+
+public class BanyanDBTraceQueryDAO extends AbstractDAO<BanyanDBClient> implements ITraceQueryDAO {
+ private static final Set<String> DEFAULT_PROJECTION = ImmutableSet.of("duration", "state", "start_time", "trace_id");
+
+ public BanyanDBTraceQueryDAO(BanyanDBClient client) {
+ super(client);
+ }
+
+ @Override
+ public TraceBrief queryBasicTraces(long startSecondTB, long endSecondTB, long minDuration, long maxDuration, String serviceId, String serviceInstanceId, String endpointId, String traceId, int limit, int from, TraceState traceState, QueryOrder queryOrder, List<Tag> tags) throws IOException {
+ TraceSearchRequest.TraceSearchRequestBuilder<?, ?> queryBuilder = TraceSearchRequest.builder().name(BanyanDBSchema.NAME).group(BanyanDBSchema.GROUP);
+ if (startSecondTB != 0 && endSecondTB != 0) {
+ queryBuilder.timeRange(TraceSearchRequest.TimeRange.builder()
+ .startTime(startSecondTB)
+ .endTime(endSecondTB).build());
+ }
+ if (minDuration != 0) {
+ // duration >= minDuration
+ queryBuilder.query(TraceSearchQuery.Ge("duration", minDuration));
+ }
+ if (maxDuration != 0) {
+ // duration <= maxDuration
+ queryBuilder.query(TraceSearchQuery.Le("duration", maxDuration));
+ }
+
+ if (!Strings.isNullOrEmpty(serviceId)) {
+ queryBuilder.query(TraceSearchQuery.Eq("service_id", serviceId));
+ }
+
+ if (!Strings.isNullOrEmpty(serviceInstanceId)) {
+ queryBuilder.query(TraceSearchQuery.Eq("service_instance_id", serviceInstanceId));
+ }
+
+ if (!Strings.isNullOrEmpty(endpointId)) {
+ queryBuilder.query(TraceSearchQuery.Eq("endpoint_id", endpointId));
+ }
+
+ switch (traceState) {
+ case ERROR:
+ queryBuilder.query(TraceSearchQuery.Eq("state", BanyanDBSchema.TraceState.ERROR.getState()));
+ break;
+ case SUCCESS:
+ queryBuilder.query(TraceSearchQuery.Eq("state", BanyanDBSchema.TraceState.SUCCESS.getState()));
+ break;
+ default:
+ queryBuilder.query(TraceSearchQuery.Eq("state", BanyanDBSchema.TraceState.ALL.getState()));
+ break;
+ }
+
+ switch (queryOrder) {
+ case BY_START_TIME:
+ queryBuilder.queryOrderField("start_time").queryOrderSort(TraceSearchRequest.SortOrder.DESC);
+ break;
+ case BY_DURATION:
+ queryBuilder.queryOrderField("duration").queryOrderSort(TraceSearchRequest.SortOrder.DESC);
+ break;
+ }
+
+ queryBuilder.projections(DEFAULT_PROJECTION);
+ queryBuilder.limit(limit);
+ queryBuilder.offset(from);
+
+ // build request
+ BanyanDBQueryResponse response = this.getClient().queryBasicTraces(queryBuilder.build());
+ TraceBrief brief = new TraceBrief();
+ brief.setTotal(response.getTotal());
+ brief.getTraces().addAll(response.getEntities().stream().map(entity -> {
+ BasicTrace trace = new BasicTrace();
+ trace.setDuration(((Long) entity.getFields().get("duration")).intValue());
+ trace.setStart(String.valueOf(entity.getFields().get(SegmentRecord.START_TIME)));
+ trace.setSegmentId(entity.getEntityId());
+ trace.setError(((Long) entity.getFields().get("state")).intValue() == 1);
+ trace.getTraceIds().add((String) entity.getFields().get(SegmentRecord.TRACE_ID));
Review comment:
*NULL_DEREFERENCE:* object returned by `getTraceIds(trace)` could be null and is dereferenced at line 117.
(at-me [in a reply](https://help.sonatype.com/lift) with `help` or `ignore`)
##########
File path: oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/banyandb/dao/BanyanDBTraceQueryDAO.java
##########
@@ -0,0 +1,154 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.server.storage.plugin.banyandb.dao;
+
+import com.google.common.base.Strings;
+import com.google.common.collect.ImmutableSet;
+import org.apache.skywalking.banyandb.client.request.TraceFetchRequest;
+import org.apache.skywalking.banyandb.client.request.TraceSearchQuery;
+import org.apache.skywalking.banyandb.client.request.TraceSearchRequest;
+import org.apache.skywalking.banyandb.client.response.BanyanDBQueryResponse;
+import org.apache.skywalking.oap.server.core.analysis.IDManager;
+import org.apache.skywalking.oap.server.core.analysis.manual.searchtag.Tag;
+import org.apache.skywalking.oap.server.core.analysis.manual.segment.SegmentRecord;
+import org.apache.skywalking.oap.server.core.query.type.BasicTrace;
+import org.apache.skywalking.oap.server.core.query.type.QueryOrder;
+import org.apache.skywalking.oap.server.core.query.type.Span;
+import org.apache.skywalking.oap.server.core.query.type.TraceBrief;
+import org.apache.skywalking.oap.server.core.query.type.TraceState;
+import org.apache.skywalking.oap.server.core.storage.AbstractDAO;
+import org.apache.skywalking.oap.server.core.storage.query.ITraceQueryDAO;
+import org.apache.skywalking.oap.server.storage.plugin.banyandb.BanyanDBClient;
+import org.apache.skywalking.oap.server.storage.plugin.banyandb.BanyanDBSchema;
+
+import java.io.IOException;
+import java.util.Collections;
+import java.util.List;
+import java.util.Set;
+import java.util.stream.Collectors;
+
+public class BanyanDBTraceQueryDAO extends AbstractDAO<BanyanDBClient> implements ITraceQueryDAO {
+ private static final Set<String> DEFAULT_PROJECTION = ImmutableSet.of("duration", "state", "start_time", "trace_id");
+
+ public BanyanDBTraceQueryDAO(BanyanDBClient client) {
+ super(client);
+ }
+
+ @Override
+ public TraceBrief queryBasicTraces(long startSecondTB, long endSecondTB, long minDuration, long maxDuration, String serviceId, String serviceInstanceId, String endpointId, String traceId, int limit, int from, TraceState traceState, QueryOrder queryOrder, List<Tag> tags) throws IOException {
+ TraceSearchRequest.TraceSearchRequestBuilder<?, ?> queryBuilder = TraceSearchRequest.builder().name(BanyanDBSchema.NAME).group(BanyanDBSchema.GROUP);
+ if (startSecondTB != 0 && endSecondTB != 0) {
+ queryBuilder.timeRange(TraceSearchRequest.TimeRange.builder()
+ .startTime(startSecondTB)
+ .endTime(endSecondTB).build());
+ }
+ if (minDuration != 0) {
+ // duration >= minDuration
+ queryBuilder.query(TraceSearchQuery.Ge("duration", minDuration));
+ }
+ if (maxDuration != 0) {
+ // duration <= maxDuration
+ queryBuilder.query(TraceSearchQuery.Le("duration", maxDuration));
+ }
+
+ if (!Strings.isNullOrEmpty(serviceId)) {
+ queryBuilder.query(TraceSearchQuery.Eq("service_id", serviceId));
+ }
+
+ if (!Strings.isNullOrEmpty(serviceInstanceId)) {
+ queryBuilder.query(TraceSearchQuery.Eq("service_instance_id", serviceInstanceId));
+ }
+
+ if (!Strings.isNullOrEmpty(endpointId)) {
+ queryBuilder.query(TraceSearchQuery.Eq("endpoint_id", endpointId));
+ }
+
+ switch (traceState) {
+ case ERROR:
+ queryBuilder.query(TraceSearchQuery.Eq("state", BanyanDBSchema.TraceState.ERROR.getState()));
+ break;
+ case SUCCESS:
+ queryBuilder.query(TraceSearchQuery.Eq("state", BanyanDBSchema.TraceState.SUCCESS.getState()));
+ break;
+ default:
+ queryBuilder.query(TraceSearchQuery.Eq("state", BanyanDBSchema.TraceState.ALL.getState()));
+ break;
+ }
+
+ switch (queryOrder) {
+ case BY_START_TIME:
+ queryBuilder.queryOrderField("start_time").queryOrderSort(TraceSearchRequest.SortOrder.DESC);
+ break;
+ case BY_DURATION:
+ queryBuilder.queryOrderField("duration").queryOrderSort(TraceSearchRequest.SortOrder.DESC);
+ break;
+ }
+
+ queryBuilder.projections(DEFAULT_PROJECTION);
+ queryBuilder.limit(limit);
+ queryBuilder.offset(from);
+
+ // build request
+ BanyanDBQueryResponse response = this.getClient().queryBasicTraces(queryBuilder.build());
+ TraceBrief brief = new TraceBrief();
+ brief.setTotal(response.getTotal());
+ brief.getTraces().addAll(response.getEntities().stream().map(entity -> {
Review comment:
*NULL_DEREFERENCE:* object returned by `getTraces(brief)` could be null and is dereferenced at line 111.
(at-me [in a reply](https://help.sonatype.com/lift) with `help` or `ignore`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] lujiajing1126 commented on pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
lujiajing1126 commented on pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#issuecomment-898444401
> @lujiajing1126 I open #7455 for you.
Sure. I will have a check. Thx
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#discussion_r687671345
##########
File path: oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/banyandb/client/impl/BanyanDBGrpcClient.java
##########
@@ -0,0 +1,173 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.banyandb.client.impl;
+
+import com.google.common.annotations.VisibleForTesting;
+import com.google.protobuf.ByteString;
+import com.google.protobuf.NullValue;
+import com.google.protobuf.Timestamp;
+import io.grpc.ManagedChannel;
+import io.grpc.stub.StreamObserver;
+import lombok.extern.slf4j.Slf4j;
+import org.apache.skywalking.banyandb.Database;
+import org.apache.skywalking.banyandb.Query;
+import org.apache.skywalking.banyandb.TraceServiceGrpc;
+import org.apache.skywalking.banyandb.Write;
+import org.apache.skywalking.banyandb.client.BanyanDBService;
+import org.apache.skywalking.banyandb.client.request.TraceFetchRequest;
+import org.apache.skywalking.banyandb.client.request.TraceSearchRequest;
+import org.apache.skywalking.banyandb.client.request.TraceWriteRequest;
+import org.apache.skywalking.banyandb.client.response.BanyanDBEntity;
+import org.apache.skywalking.banyandb.client.response.BanyanDBQueryResponse;
+
+import java.util.List;
+import java.util.concurrent.TimeUnit;
+import java.util.stream.Collectors;
+
+@Slf4j
+public class BanyanDBGrpcClient implements BanyanDBService {
+ private final TraceServiceGrpc.TraceServiceBlockingStub stub;
+ private final TraceServiceGrpc.TraceServiceStub asyncStub;
+
+ public BanyanDBGrpcClient(ManagedChannel managedChannel) {
+ this.stub = TraceServiceGrpc.newBlockingStub(managedChannel);
+ this.asyncStub = TraceServiceGrpc.newStub(managedChannel);
+ }
+
+ @Override
+ public BanyanDBQueryResponse queryBasicTraces(TraceSearchRequest request) {
+ Query.QueryRequest.Builder queryBuilder = Query.QueryRequest.newBuilder()
+ .setMetadata(Database.Metadata.newBuilder().setGroup(request.getGroup()).setName(request.getName()).build());
+
+ if (request.getTimeRange() != null && request.getTimeRange().getStartTime() != 0 && request.getTimeRange().getEndTime() != 0) {
+ queryBuilder.setTimeRange(Query.TimeRange.newBuilder()
+ .setBegin(Timestamp.newBuilder().setSeconds(request.getTimeRange().getStartTime()))
+ .setEnd(Timestamp.newBuilder().setSeconds(request.getTimeRange().getEndTime())).build());
+ }
+
+ request.getQueries().forEach(q -> queryBuilder.addFields(q.toPairQuery()));
+
+ queryBuilder.setOrderBy(Query.QueryOrder.newBuilder()
+ .setKeyName(request.getQueryOrderField())
+ .setSort(request.getQueryOrderSort().getSort())
+ .build());
+
+ queryBuilder.setProjection(Query.Projection.newBuilder()
+ .addAllKeyNames(request.getProjections())
+ .build());
+ queryBuilder.setLimit(request.getLimit());
+ queryBuilder.setOffset(request.getOffset());
+
+ return convertToResponse(this.stub.query(queryBuilder.build()));
+ }
+
+ @Override
+ public BanyanDBQueryResponse queryByTraceId(TraceFetchRequest traceFetchRequest) {
+ Query.QueryRequest.Builder queryBuilder = Query.QueryRequest.newBuilder()
+ .setMetadata(Database.Metadata.newBuilder().setGroup(traceFetchRequest.getGroup()).setName(traceFetchRequest.getName()).build())
+ .addFields(Query.PairQuery.newBuilder()
+ .setOp(Query.PairQuery.BinaryOp.BINARY_OP_EQ)
+ .setCondition(Query.TypedPair.newBuilder().setStrPair(Query.StrPair.newBuilder().setKey("trace_id").addValues(traceFetchRequest.getTraceId()).build()))
+ .build())
+ .setProjection(Query.Projection.newBuilder()
+ .addAllKeyNames(traceFetchRequest.getProjections())
+ .build());
+ return convertToResponse(this.stub.query(queryBuilder.build()));
+ }
+
+ static BanyanDBQueryResponse convertToResponse(Query.QueryResponse response) {
+ BanyanDBQueryResponse r = new BanyanDBQueryResponse();
+ r.setTotal(response.getEntitiesCount());
+ for (final Query.Entity entity : response.getEntitiesList()) {
+ BanyanDBEntity.BanyanDBEntityBuilder entityBuilder = BanyanDBEntity.builder();
+ for (final Query.TypedPair typedPair : entity.getFieldsList()) {
+ if (typedPair.hasIntPair()) {
+ final Query.IntPair pair = typedPair.getIntPair();
+ entityBuilder.field(pair.getKey(), pair.getValuesList().get(0));
+ } else if (typedPair.hasStrPair()) {
+ final Query.StrPair pair = typedPair.getStrPair();
+ entityBuilder.field(pair.getKey(), pair.getValuesList().get(0));
+ }
+ }
+ entityBuilder.entityId(entity.getEntityId());
+ entityBuilder.binaryData(entity.getDataBinary().toByteArray());
+ entityBuilder.timestampSeconds(entity.getTimestamp().getSeconds());
+ entityBuilder.timestampNanoSeconds(entity.getTimestamp().getNanos());
+ r.getEntities().add(entityBuilder.build());
+ }
+
+ return r;
+ }
+
+ @Override
+ public void writeEntity(List<TraceWriteRequest> data) {
+ StreamObserver<org.apache.skywalking.banyandb.Write.WriteRequest> observer = this.asyncStub.withDeadlineAfter(30, TimeUnit.SECONDS)
+ .write(new StreamObserver<Write.WriteResponse>() {
+ @Override
+ public void onNext(Write.WriteResponse writeResponse) {
+ }
+
+ @Override
+ public void onError(Throwable throwable) {
+ log.error("fail to send request", throwable);
+ }
+
+ @Override
+ public void onCompleted() {
+ }
+ });
+
+ for (final TraceWriteRequest entity : data) {
+ try {
+ Write.EntityValue entityValue = Write.EntityValue.newBuilder()
+ .addAllFields(buildWriteFields(entity.getFields()))
Review comment:
The recommended way is always type sensitive. Don't abuses `Object` in the API codes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#issuecomment-897513283
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`banyandb-integration@6a241ae`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## banyandb-integration #7448 +/- ##
=======================================================
Coverage ? 26.10%
Complexity ? 1715
=======================================================
Files ? 844
Lines ? 21085
Branches ? 1981
=======================================================
Hits ? 5504
Misses ? 15189
Partials ? 392
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6a241ae...360972e](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#discussion_r687665473
##########
File path: oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/banyandb/client/request/TraceSearchRequest.java
##########
@@ -0,0 +1,88 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.banyandb.client.request;
+
+import lombok.Builder;
+import lombok.Data;
+import lombok.EqualsAndHashCode;
+import lombok.Getter;
+import lombok.Singular;
+import lombok.experimental.SuperBuilder;
+import org.apache.skywalking.banyandb.Query;
+
+import java.util.List;
+
+@SuperBuilder
+@Data
+@EqualsAndHashCode(callSuper = true)
+public class TraceSearchRequest extends HasMetadata {
+ // timeRange
+ private final TimeRange timeRange;
+
+ // query parameters
+ @Singular
+ private final List<TraceSearchQuery> queries;
+
+ // paging parameters: limit & offset
+ private final int limit;
+ private final int offset;
+
+ // query order
+ private final String queryOrderField;
+ private final SortOrder queryOrderSort;
Review comment:
These should be exposed as `OrderBy` object with 2 fields as constructor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#issuecomment-897513283
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`banyandb-integration@6a241ae`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
> :exclamation: Current head e4dbd20 differs from pull request most recent head 0c80a8a. Consider uploading reports for the commit 0c80a8a to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## banyandb-integration #7448 +/- ##
=======================================================
Coverage ? 47.08%
Complexity ? 2931
=======================================================
Files ? 845
Lines ? 21562
Branches ? 2070
=======================================================
Hits ? 10152
Misses ? 10598
Partials ? 812
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6a241ae...0c80a8a](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] lujiajing1126 commented on pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
lujiajing1126 commented on pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#issuecomment-898168680
> I put many comments, but not all. @hanahmily I am not sure what code style is required in BanyanDB codebase, but this PR is not ready from main repo's requirements.
>
> All API level methods should have formal comments to describe usage, and meaning of parameters and return value. Even include how and where should use this APIs.
>
> My major requirements are for BanyanDB package, I would like to be very strict about this API review. Feel free even to submit a PR to submit this. Also, I recommend to move all BanyanDB client source codes as the root module of `oap-server`. It should be `org.apache.skywalking:banyandb-java-client`.
I have improved this PR following you comments.
1. The client package has been moved as a module in the `oap-server`
2. The typed API are introduced to avoid runtime type checking for performance issues
3. Docs are added to all interfaces and fields in the client package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#issuecomment-897513283
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`banyandb-integration@6a241ae`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
> :exclamation: Current head e4dbd20 differs from pull request most recent head 0c80a8a. Consider uploading reports for the commit 0c80a8a to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## banyandb-integration #7448 +/- ##
=======================================================
Coverage ? 42.55%
Complexity ? 2701
=======================================================
Files ? 845
Lines ? 21526
Branches ? 2069
=======================================================
Hits ? 9160
Misses ? 11654
Partials ? 712
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6a241ae...0c80a8a](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#issuecomment-897513283
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`banyandb-integration@6a241ae`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
> :exclamation: Current head 8f64497 differs from pull request most recent head 6f8e95e. Consider uploading reports for the commit 6f8e95e to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## banyandb-integration #7448 +/- ##
=======================================================
Coverage ? 55.20%
Complexity ? 4202
=======================================================
Files ? 1034
Lines ? 26563
Branches ? 2621
=======================================================
Hits ? 14664
Misses ? 10632
Partials ? 1267
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6a241ae...6f8e95e](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#issuecomment-897513283
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`banyandb-integration@6a241ae`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
> :exclamation: Current head 8f64497 differs from pull request most recent head 6f8e95e. Consider uploading reports for the commit 6f8e95e to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## banyandb-integration #7448 +/- ##
=======================================================
Coverage ? 58.59%
Complexity ? 4371
=======================================================
Files ? 1034
Lines ? 26565
Branches ? 2625
=======================================================
Hits ? 15567
Misses ? 9625
Partials ? 1373
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6a241ae...6f8e95e](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#issuecomment-897513283
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`banyandb-integration@6a241ae`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
> :exclamation: Current head e4dbd20 differs from pull request most recent head 0c80a8a. Consider uploading reports for the commit 0c80a8a to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## banyandb-integration #7448 +/- ##
=======================================================
Coverage ? 52.56%
Complexity ? 4054
=======================================================
Files ? 1034
Lines ? 26522
Branches ? 2615
=======================================================
Hits ? 13942
Misses ? 11329
Partials ? 1251
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6a241ae...0c80a8a](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#issuecomment-897513283
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`banyandb-integration@6a241ae`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
> :exclamation: Current head 8f64497 differs from pull request most recent head 6f8e95e. Consider uploading reports for the commit 6f8e95e to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## banyandb-integration #7448 +/- ##
=======================================================
Coverage ? 50.22%
Complexity ? 3183
=======================================================
Files ? 876
Lines ? 22609
Branches ? 2174
=======================================================
Hits ? 11356
Misses ? 10345
Partials ? 908
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6a241ae...6f8e95e](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#discussion_r687666926
##########
File path: oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/banyandb/client/request/TraceSearchQuery.java
##########
@@ -0,0 +1,82 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.banyandb.client.request;
+
+import lombok.AccessLevel;
+import lombok.AllArgsConstructor;
+import org.apache.skywalking.banyandb.Query;
+
+@AllArgsConstructor(access = AccessLevel.PRIVATE)
+public class TraceSearchQuery {
+ private final String key;
+ private final TraceSearchRequest.BinaryOperator op;
+ private final Object value;
+ private final Query.TypedPair.TypedCase typedCase;
+
+ public Query.PairQuery toPairQuery() {
Review comment:
This seems testing only? Please use `default` scope.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#issuecomment-897513283
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#issuecomment-897513283
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`banyandb-integration@6a241ae`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
> :exclamation: Current head 2417819 differs from pull request most recent head 360972e. Consider uploading reports for the commit 360972e to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## banyandb-integration #7448 +/- ##
=======================================================
Coverage ? 58.55%
Complexity ? 4374
=======================================================
Files ? 1034
Lines ? 26565
Branches ? 2625
=======================================================
Hits ? 15554
Misses ? 9640
Partials ? 1371
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6a241ae...360972e](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#issuecomment-897513283
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`banyandb-integration@6a241ae`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
> :exclamation: Current head 2417819 differs from pull request most recent head 360972e. Consider uploading reports for the commit 360972e to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## banyandb-integration #7448 +/- ##
=======================================================
Coverage ? 58.56%
Complexity ? 4376
=======================================================
Files ? 1034
Lines ? 26565
Branches ? 2625
=======================================================
Hits ? 15558
Misses ? 9636
Partials ? 1371
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6a241ae...360972e](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#issuecomment-897513283
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`banyandb-integration@6a241ae`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## banyandb-integration #7448 +/- ##
=======================================================
Coverage ? 48.64%
Complexity ? 3139
=======================================================
Files ? 876
Lines ? 22601
Branches ? 2174
=======================================================
Hits ? 10994
Misses ? 10717
Partials ? 890
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6a241ae...360972e](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] lujiajing1126 closed pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
lujiajing1126 closed pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#issuecomment-897513283
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`banyandb-integration@6a241ae`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
> :exclamation: Current head e4dbd20 differs from pull request most recent head 0c80a8a. Consider uploading reports for the commit 0c80a8a to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## banyandb-integration #7448 +/- ##
=======================================================
Coverage ? 36.51%
Complexity ? 2314
=======================================================
Files ? 845
Lines ? 21446
Branches ? 2061
=======================================================
Hits ? 7830
Misses ? 13026
Partials ? 590
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6a241ae...0c80a8a](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#issuecomment-897513283
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`banyandb-integration@6a241ae`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
> :exclamation: Current head e4dbd20 differs from pull request most recent head 2b48fc3. Consider uploading reports for the commit 2b48fc3 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## banyandb-integration #7448 +/- ##
=======================================================
Coverage ? 57.91%
Complexity ? 4341
=======================================================
Files ? 1034
Lines ? 26555
Branches ? 2624
=======================================================
Hits ? 15379
Misses ? 9810
Partials ? 1366
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6a241ae...2b48fc3](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#issuecomment-897513283
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`banyandb-integration@6a241ae`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
> :exclamation: Current head 2417819 differs from pull request most recent head 360972e. Consider uploading reports for the commit 360972e to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## banyandb-integration #7448 +/- ##
=======================================================
Coverage ? 57.57%
Complexity ? 4327
=======================================================
Files ? 1034
Lines ? 26565
Branches ? 2625
=======================================================
Hits ? 15294
Misses ? 9939
Partials ? 1332
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6a241ae...360972e](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] lujiajing1126 edited a comment on pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
lujiajing1126 edited a comment on pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#issuecomment-898168680
> I put many comments, but not all. @hanahmily I am not sure what code style is required in BanyanDB codebase, but this PR is not ready from main repo's requirements.
>
> All API level methods should have formal comments to describe usage, and meaning of parameters and return value. Even include how and where should use this APIs.
>
> My major requirements are for BanyanDB package, I would like to be very strict about this API review. Feel free even to submit a PR to submit this. Also, I recommend to move all BanyanDB client source codes as the root module of `oap-server`. It should be `org.apache.skywalking:banyandb-java-client`.
I have improved this PR following you comments.
1. The client package has been moved as a standalone module in the `oap-server`
2. The typed API are introduced to avoid runtime type checking for performance issues
3. Docs are added to all interfaces and fields in the client package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#issuecomment-897513283
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`banyandb-integration@6a241ae`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
> :exclamation: Current head e4dbd20 differs from pull request most recent head 6cff811. Consider uploading reports for the commit 6cff811 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## banyandb-integration #7448 +/- ##
=======================================================
Coverage ? 57.91%
Complexity ? 4341
=======================================================
Files ? 1034
Lines ? 26555
Branches ? 2624
=======================================================
Hits ? 15379
Misses ? 9810
Partials ? 1366
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6a241ae...6cff811](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#issuecomment-897513283
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`banyandb-integration@6a241ae`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
> :exclamation: Current head e4dbd20 differs from pull request most recent head 0c80a8a. Consider uploading reports for the commit 0c80a8a to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## banyandb-integration #7448 +/- ##
=======================================================
Coverage ? 57.90%
Complexity ? 4339
=======================================================
Files ? 1034
Lines ? 26555
Branches ? 2624
=======================================================
Hits ? 15376
Misses ? 9813
Partials ? 1366
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6a241ae...0c80a8a](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#issuecomment-897619956
I will try to build the `banyandb-java-client` client tomorrow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] lujiajing1126 commented on a change in pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
lujiajing1126 commented on a change in pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#discussion_r688202739
##########
File path: oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/banyandb/client/request/TraceSearchRequest.java
##########
@@ -0,0 +1,88 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.banyandb.client.request;
+
+import lombok.Builder;
+import lombok.Data;
+import lombok.EqualsAndHashCode;
+import lombok.Getter;
+import lombok.Singular;
+import lombok.experimental.SuperBuilder;
+import org.apache.skywalking.banyandb.Query;
+
+import java.util.List;
+
+@SuperBuilder
+@Data
+@EqualsAndHashCode(callSuper = true)
+public class TraceSearchRequest extends HasMetadata {
+ // timeRange
+ private final TimeRange timeRange;
+
+ // query parameters
+ @Singular
+ private final List<TraceSearchQuery> queries;
+
+ // paging parameters: limit & offset
+ private final int limit;
+ private final int offset;
+
+ // query order
+ private final String queryOrderField;
+ private final SortOrder queryOrderSort;
Review comment:
Done
##########
File path: oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/banyandb/client/request/TraceSearchQuery.java
##########
@@ -0,0 +1,82 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.banyandb.client.request;
+
+import lombok.AccessLevel;
+import lombok.AllArgsConstructor;
+import org.apache.skywalking.banyandb.Query;
+
+@AllArgsConstructor(access = AccessLevel.PRIVATE)
+public class TraceSearchQuery {
+ private final String key;
+ private final TraceSearchRequest.BinaryOperator op;
+ private final Object value;
+ private final Query.TypedPair.TypedCase typedCase;
+
+ public Query.PairQuery toPairQuery() {
+ switch (this.typedCase) {
+ case STR_PAIR:
+ return Query.PairQuery.newBuilder()
+ .setOp(this.op.getOp())
+ .setCondition(Query.TypedPair.newBuilder().setStrPair(Query.StrPair.newBuilder().setKey(key).addValues((String) this.value).build()).build())
+ .build();
+ case INT_PAIR:
+ return Query.PairQuery.newBuilder()
+ .setOp(this.op.getOp())
+ .setCondition(Query.TypedPair.newBuilder().setIntPair(Query.IntPair.newBuilder().setKey(key).addValues((Long) this.value).build()).build())
+ .build();
+ default:
+ throw new IllegalStateException("should not reach here");
+ }
+ }
+
+ // String
+ public static TraceSearchQuery Eq(String key, String val) {
Review comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#issuecomment-897513283
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`banyandb-integration@6a241ae`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## banyandb-integration #7448 +/- ##
=======================================================
Coverage ? 57.30%
Complexity ? 4310
=======================================================
Files ? 1034
Lines ? 26565
Branches ? 2625
=======================================================
Hits ? 15224
Misses ? 9998
Partials ? 1343
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6a241ae...360972e](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#issuecomment-897513283
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`banyandb-integration@6a241ae`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## banyandb-integration #7448 +/- ##
=======================================================
Coverage ? 50.45%
Complexity ? 3219
=======================================================
Files ? 876
Lines ? 22601
Branches ? 2174
=======================================================
Hits ? 11404
Misses ? 10268
Partials ? 929
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6a241ae...360972e](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#issuecomment-897513283
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`banyandb-integration@6a241ae`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
> :exclamation: Current head 2417819 differs from pull request most recent head 738cf7c. Consider uploading reports for the commit 738cf7c to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## banyandb-integration #7448 +/- ##
=======================================================
Coverage ? 56.61%
Complexity ? 4280
=======================================================
Files ? 1034
Lines ? 26565
Branches ? 2625
=======================================================
Hits ? 15040
Misses ? 10224
Partials ? 1301
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6a241ae...738cf7c](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] lujiajing1126 commented on a change in pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
lujiajing1126 commented on a change in pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#discussion_r688221049
##########
File path: oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/banyandb/client/BanyanDBTraceService.java
##########
@@ -0,0 +1,36 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.banyandb.client;
+
+import org.apache.skywalking.banyandb.client.request.TraceFetchRequest;
+import org.apache.skywalking.banyandb.client.request.TraceSearchRequest;
+import org.apache.skywalking.banyandb.client.request.TraceWriteRequest;
+import org.apache.skywalking.banyandb.client.response.BanyanDBQueryResponse;
+
+import java.util.List;
+
+public interface BanyanDBTraceService {
+ // read/query
Review comment:
Docs are added. all `//` simple comments are removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#issuecomment-897513283
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`banyandb-integration@6a241ae`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
> :exclamation: Current head 2417819 differs from pull request most recent head 738cf7c. Consider uploading reports for the commit 738cf7c to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## banyandb-integration #7448 +/- ##
=======================================================
Coverage ? 40.95%
Complexity ? 2593
=======================================================
Files ? 845
Lines ? 21498
Branches ? 2063
=======================================================
Hits ? 8804
Misses ? 11981
Partials ? 713
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6a241ae...738cf7c](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#issuecomment-897513283
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`banyandb-integration@6a241ae`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## banyandb-integration #7448 +/- ##
=======================================================
Coverage ? 58.65%
Complexity ? 4378
=======================================================
Files ? 1034
Lines ? 26565
Branches ? 2625
=======================================================
Hits ? 15583
Misses ? 9600
Partials ? 1382
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6a241ae...360972e](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#issuecomment-897513283
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`banyandb-integration@6a241ae`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
> :exclamation: Current head 8f64497 differs from pull request most recent head 6f8e95e. Consider uploading reports for the commit 6f8e95e to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## banyandb-integration #7448 +/- ##
=======================================================
Coverage ? 52.64%
Complexity ? 3323
=======================================================
Files ? 876
Lines ? 22634
Branches ? 2175
=======================================================
Hits ? 11915
Misses ? 9742
Partials ? 977
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6a241ae...6f8e95e](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#issuecomment-897513283
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`banyandb-integration@6a241ae`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## banyandb-integration #7448 +/- ##
=======================================================
Coverage ? 43.64%
Complexity ? 2871
=======================================================
Files ? 876
Lines ? 22477
Branches ? 2160
=======================================================
Hits ? 9810
Misses ? 11882
Partials ? 785
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6a241ae...360972e](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#issuecomment-897513283
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`banyandb-integration@6a241ae`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## banyandb-integration #7448 +/- ##
=======================================================
Coverage ? 39.11%
Complexity ? 2489
=======================================================
Files ? 845
Lines ? 21498
Branches ? 2063
=======================================================
Hits ? 8409
Misses ? 12400
Partials ? 689
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6a241ae...2b48fc3](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#issuecomment-897513283
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`banyandb-integration@6a241ae`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
> :exclamation: Current head e4dbd20 differs from pull request most recent head 0c80a8a. Consider uploading reports for the commit 0c80a8a to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## banyandb-integration #7448 +/- ##
=======================================================
Coverage ? 47.27%
Complexity ? 2937
=======================================================
Files ? 845
Lines ? 21562
Branches ? 2070
=======================================================
Hits ? 10193
Misses ? 10549
Partials ? 820
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6a241ae...0c80a8a](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#issuecomment-897513283
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`banyandb-integration@6a241ae`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## banyandb-integration #7448 +/- ##
=======================================================
Coverage ? 58.83%
Complexity ? 4389
=======================================================
Files ? 1034
Lines ? 26565
Branches ? 2625
=======================================================
Hits ? 15630
Misses ? 9548
Partials ? 1387
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6a241ae...360972e](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#issuecomment-897513283
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`banyandb-integration@6a241ae`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
> :exclamation: Current head 2417819 differs from pull request most recent head 738cf7c. Consider uploading reports for the commit 738cf7c to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## banyandb-integration #7448 +/- ##
=======================================================
Coverage ? 31.99%
Complexity ? 2039
=======================================================
Files ? 845
Lines ? 21327
Branches ? 2031
=======================================================
Hits ? 6823
Misses ? 13999
Partials ? 505
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6a241ae...738cf7c](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#discussion_r687667725
##########
File path: oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/banyandb/client/request/HasMetadata.java
##########
@@ -0,0 +1,31 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.banyandb.client.request;
+
+import lombok.EqualsAndHashCode;
+import lombok.Getter;
+import lombok.experimental.SuperBuilder;
+
+@SuperBuilder
+@Getter
+@EqualsAndHashCode
+public class HasMetadata {
Review comment:
This is an improper name. The verb. should not lead a class name. Verb is for method name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#issuecomment-897513283
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`banyandb-integration@6a241ae`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
> :exclamation: Current head 2417819 differs from pull request most recent head 360972e. Consider uploading reports for the commit 360972e to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## banyandb-integration #7448 +/- ##
=======================================================
Coverage ? 57.62%
Complexity ? 4331
=======================================================
Files ? 1034
Lines ? 26565
Branches ? 2625
=======================================================
Hits ? 15307
Misses ? 9926
Partials ? 1332
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6a241ae...360972e](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#issuecomment-897513283
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`banyandb-integration@6a241ae`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## banyandb-integration #7448 +/- ##
=======================================================
Coverage ? 25.78%
Complexity ? 1704
=======================================================
Files ? 844
Lines ? 21076
Branches ? 1981
=======================================================
Hits ? 5434
Misses ? 15232
Partials ? 410
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6a241ae...2b48fc3](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#issuecomment-898369609
I will provide a code prototype(most implementation) for you tonight.
You will see how we build official client jar.
I hope this could inspire you in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#issuecomment-897513283
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`banyandb-integration@6a241ae`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
> :exclamation: Current head 2417819 differs from pull request most recent head 360972e. Consider uploading reports for the commit 360972e to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## banyandb-integration #7448 +/- ##
=======================================================
Coverage ? 58.05%
Complexity ? 4344
=======================================================
Files ? 1034
Lines ? 26565
Branches ? 2625
=======================================================
Hits ? 15423
Misses ? 9783
Partials ? 1359
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6a241ae...360972e](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#issuecomment-897513283
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`banyandb-integration@6a241ae`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
> :exclamation: Current head e4dbd20 differs from pull request most recent head 0c80a8a. Consider uploading reports for the commit 0c80a8a to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## banyandb-integration #7448 +/- ##
=======================================================
Coverage ? 57.91%
Complexity ? 4341
=======================================================
Files ? 1034
Lines ? 26555
Branches ? 2624
=======================================================
Hits ? 15379
Misses ? 9810
Partials ? 1366
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6a241ae...0c80a8a](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#issuecomment-897513283
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`banyandb-integration@6a241ae`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
> :exclamation: Current head 8f64497 differs from pull request most recent head 6f8e95e. Consider uploading reports for the commit 6f8e95e to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## banyandb-integration #7448 +/- ##
=======================================================
Coverage ? 58.50%
Complexity ? 4365
=======================================================
Files ? 1034
Lines ? 26565
Branches ? 2625
=======================================================
Hits ? 15542
Misses ? 9651
Partials ? 1372
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6a241ae...6f8e95e](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#issuecomment-897513283
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`banyandb-integration@6a241ae`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## banyandb-integration #7448 +/- ##
=======================================================
Coverage ? 45.74%
Complexity ? 2987
=======================================================
Files ? 876
Lines ? 22515
Branches ? 2166
=======================================================
Hits ? 10299
Misses ? 11388
Partials ? 828
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6a241ae...360972e](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] commented on pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#issuecomment-897513283
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`banyandb-integration@6a241ae`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
> :exclamation: Current head 8f64497 differs from pull request most recent head 6f8e95e. Consider uploading reports for the commit 6f8e95e to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## banyandb-integration #7448 +/- ##
=======================================================
Coverage ? 26.45%
Complexity ? 1741
=======================================================
Files ? 844
Lines ? 21085
Branches ? 1981
=======================================================
Hits ? 5578
Misses ? 15111
Partials ? 396
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6a241ae...6f8e95e](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#issuecomment-897513283
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`banyandb-integration@6a241ae`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## banyandb-integration #7448 +/- ##
=======================================================
Coverage ? 44.00%
Complexity ? 2890
=======================================================
Files ? 876
Lines ? 22477
Branches ? 2160
=======================================================
Hits ? 9891
Misses ? 11788
Partials ? 798
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6a241ae...360972e](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#issuecomment-897513283
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`banyandb-integration@6a241ae`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
> :exclamation: Current head 8f64497 differs from pull request most recent head 6f8e95e. Consider uploading reports for the commit 6f8e95e to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## banyandb-integration #7448 +/- ##
=======================================================
Coverage ? 40.98%
Complexity ? 2708
=======================================================
Files ? 876
Lines ? 22535
Branches ? 2167
=======================================================
Hits ? 9235
Misses ? 12588
Partials ? 712
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6a241ae...6f8e95e](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#issuecomment-897513283
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`banyandb-integration@6a241ae`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
> :exclamation: Current head 8f64497 differs from pull request most recent head 6f8e95e. Consider uploading reports for the commit 6f8e95e to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## banyandb-integration #7448 +/- ##
=======================================================
Coverage ? 55.38%
Complexity ? 4208
=======================================================
Files ? 1034
Lines ? 26565
Branches ? 2625
=======================================================
Hits ? 14713
Misses ? 10574
Partials ? 1278
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6a241ae...6f8e95e](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#issuecomment-897513283
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`banyandb-integration@6a241ae`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
> :exclamation: Current head e4dbd20 differs from pull request most recent head 0c80a8a. Consider uploading reports for the commit 0c80a8a to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## banyandb-integration #7448 +/- ##
=======================================================
Coverage ? 52.89%
Complexity ? 4084
=======================================================
Files ? 1034
Lines ? 26550
Branches ? 2620
=======================================================
Hits ? 14044
Misses ? 11250
Partials ? 1256
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6a241ae...0c80a8a](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#discussion_r687669194
##########
File path: oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/banyandb/client/request/TraceFetchRequest.java
##########
@@ -0,0 +1,34 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.banyandb.client.request;
+
+import lombok.Getter;
+import lombok.Singular;
+import lombok.experimental.SuperBuilder;
+
+import java.util.List;
+
+@SuperBuilder
+@Getter
+public class TraceFetchRequest extends HasMetadata {
Review comment:
Please break the unnecessary inheritance. Metadata should be client's constructor. In the future, metadata is used for database or tenancy isolation, you should not let a client shared.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#issuecomment-897513283
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`banyandb-integration@6a241ae`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
> :exclamation: Current head 2417819 differs from pull request most recent head 738cf7c. Consider uploading reports for the commit 738cf7c to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## banyandb-integration #7448 +/- ##
=======================================================
Coverage ? 44.61%
Complexity ? 2901
=======================================================
Files ? 876
Lines ? 22476
Branches ? 2164
=======================================================
Hits ? 10027
Misses ? 11631
Partials ? 818
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6a241ae...738cf7c](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#issuecomment-897513283
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`banyandb-integration@6a241ae`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
> :exclamation: Current head 2417819 differs from pull request most recent head 360972e. Consider uploading reports for the commit 360972e to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## banyandb-integration #7448 +/- ##
=======================================================
Coverage ? 58.07%
Complexity ? 4346
=======================================================
Files ? 1034
Lines ? 26565
Branches ? 2625
=======================================================
Hits ? 15427
Misses ? 9779
Partials ? 1359
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6a241ae...360972e](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#issuecomment-897513283
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`banyandb-integration@6a241ae`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## banyandb-integration #7448 +/- ##
=======================================================
Coverage ? 52.67%
Complexity ? 4055
=======================================================
Files ? 1034
Lines ? 26527
Branches ? 2620
=======================================================
Hits ? 13972
Misses ? 11312
Partials ? 1243
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6a241ae...360972e](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#issuecomment-897513283
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`banyandb-integration@6a241ae`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## banyandb-integration #7448 +/- ##
=======================================================
Coverage ? 57.30%
Complexity ? 4309
=======================================================
Files ? 1034
Lines ? 26565
Branches ? 2625
=======================================================
Hits ? 15223
Misses ? 9999
Partials ? 1343
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6a241ae...360972e](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#issuecomment-897513283
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`banyandb-integration@6a241ae`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## banyandb-integration #7448 +/- ##
=======================================================
Coverage ? 28.22%
Complexity ? 1832
=======================================================
Files ? 844
Lines ? 21085
Branches ? 1981
=======================================================
Hits ? 5952
Misses ? 14686
Partials ? 447
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6a241ae...360972e](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#issuecomment-897513283
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`banyandb-integration@6a241ae`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## banyandb-integration #7448 +/- ##
=======================================================
Coverage ? 58.09%
Complexity ? 4346
=======================================================
Files ? 1034
Lines ? 26565
Branches ? 2625
=======================================================
Hits ? 15432
Misses ? 9769
Partials ? 1364
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6a241ae...360972e](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#issuecomment-897513283
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`banyandb-integration@6a241ae`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
> :exclamation: Current head e4dbd20 differs from pull request most recent head 0c80a8a. Consider uploading reports for the commit 0c80a8a to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## banyandb-integration #7448 +/- ##
=======================================================
Coverage ? 51.99%
Complexity ? 4031
=======================================================
Files ? 1034
Lines ? 26522
Branches ? 2615
=======================================================
Hits ? 13791
Misses ? 11507
Partials ? 1224
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6a241ae...0c80a8a](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] sonatype-lift[bot] commented on a change in pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
sonatype-lift[bot] commented on a change in pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#discussion_r688242831
##########
File path: oap-server/banyandb-client-java/pom.xml
##########
@@ -0,0 +1,75 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <parent>
+ <artifactId>oap-server</artifactId>
+ <groupId>org.apache.skywalking</groupId>
+ <version>8.8.0-SNAPSHOT</version>
+ </parent>
+ <modelVersion>4.0.0</modelVersion>
+
+ <artifactId>banyandb-client-java</artifactId>
+
+ <properties>
+ <maven.compiler.source>8</maven.compiler.source>
+ <maven.compiler.target>8</maven.compiler.target>
+ </properties>
+
+ <dependencies>
+ <dependency>
Review comment:
*Critical OSS Vulnerability:*
### pkg:maven/io.netty/netty-handler
1 Critical, 0 Severe, 0 Moderate and 0 Unknown vulnerabilities have been found in a direct dependency
<!-- Lift_Details -->
<details>
<summary><b>CRITICAL Vulnerabilities (1)</b></summary>
<ul>
***
> #### [CVE-2016-4970] handler/ssl/OpenSslEngine.java in Netty 4.0.x before 4.0.37.Final and 4.1.x befo...
> handler/ssl/OpenSslEngine.java in Netty 4.0.x before 4.0.37.Final and 4.1.x before 4.1.1.Final allows remote attackers to cause a denial of service (infinite loop).
>
> **CVSS Score:** 7.5
>
> **CVSS Vector:** CVSS:3.0/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:N/A:H
***
</ul>
</details>
(at-me [in a reply](https://help.sonatype.com/lift) with `help` or `ignore`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#issuecomment-897513283
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`banyandb-integration@6a241ae`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
> :exclamation: Current head 8f64497 differs from pull request most recent head 6f8e95e. Consider uploading reports for the commit 6f8e95e to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## banyandb-integration #7448 +/- ##
=======================================================
Coverage ? 47.24%
Complexity ? 3034
=======================================================
Files ? 876
Lines ? 22599
Branches ? 2173
=======================================================
Hits ? 10678
Misses ? 11073
Partials ? 848
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6a241ae...6f8e95e](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#issuecomment-897513283
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`banyandb-integration@6a241ae`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
> :exclamation: Current head 8f64497 differs from pull request most recent head 6f8e95e. Consider uploading reports for the commit 6f8e95e to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## banyandb-integration #7448 +/- ##
=======================================================
Coverage ? 58.64%
Complexity ? 4373
=======================================================
Files ? 1034
Lines ? 26565
Branches ? 2625
=======================================================
Hits ? 15578
Misses ? 9609
Partials ? 1378
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6a241ae...6f8e95e](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#discussion_r687672365
##########
File path: oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/banyandb/client/BanyanDBTraceService.java
##########
@@ -0,0 +1,36 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.banyandb.client;
+
+import org.apache.skywalking.banyandb.client.request.TraceFetchRequest;
+import org.apache.skywalking.banyandb.client.request.TraceSearchRequest;
+import org.apache.skywalking.banyandb.client.request.TraceWriteRequest;
+import org.apache.skywalking.banyandb.client.response.BanyanDBQueryResponse;
+
+import java.util.List;
+
+public interface BanyanDBTraceService {
+ // read/query
Review comment:
Your comments are incorrect, no matter from format or contents.
1. `/** */` is recommended way to comment methods, and all parameters should have contents.
2. Your comments are pointless.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#issuecomment-897513283
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`banyandb-integration@6a241ae`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
> :exclamation: Current head e4dbd20 differs from pull request most recent head 0c80a8a. Consider uploading reports for the commit 0c80a8a to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## banyandb-integration #7448 +/- ##
=======================================================
Coverage ? 56.96%
Complexity ? 4290
=======================================================
Files ? 1034
Lines ? 26553
Branches ? 2620
=======================================================
Hits ? 15126
Misses ? 10089
Partials ? 1338
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6a241ae...0c80a8a](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#issuecomment-897513283
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`banyandb-integration@6a241ae`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
> :exclamation: Current head 2417819 differs from pull request most recent head 360972e. Consider uploading reports for the commit 360972e to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## banyandb-integration #7448 +/- ##
=======================================================
Coverage ? 58.44%
Complexity ? 4370
=======================================================
Files ? 1034
Lines ? 26565
Branches ? 2625
=======================================================
Hits ? 15527
Misses ? 9672
Partials ? 1366
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6a241ae...360972e](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#issuecomment-897513283
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`banyandb-integration@6a241ae`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## banyandb-integration #7448 +/- ##
=======================================================
Coverage ? 57.49%
Complexity ? 4320
=======================================================
Files ? 1034
Lines ? 26565
Branches ? 2625
=======================================================
Hits ? 15273
Misses ? 9941
Partials ? 1351
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6a241ae...360972e](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] lujiajing1126 commented on a change in pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
lujiajing1126 commented on a change in pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#discussion_r688204597
##########
File path: oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/banyandb/client/impl/BanyanDBGrpcClient.java
##########
@@ -0,0 +1,173 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.banyandb.client.impl;
+
+import com.google.common.annotations.VisibleForTesting;
+import com.google.protobuf.ByteString;
+import com.google.protobuf.NullValue;
+import com.google.protobuf.Timestamp;
+import io.grpc.ManagedChannel;
+import io.grpc.stub.StreamObserver;
+import lombok.extern.slf4j.Slf4j;
+import org.apache.skywalking.banyandb.Database;
+import org.apache.skywalking.banyandb.Query;
+import org.apache.skywalking.banyandb.TraceServiceGrpc;
+import org.apache.skywalking.banyandb.Write;
+import org.apache.skywalking.banyandb.client.BanyanDBService;
+import org.apache.skywalking.banyandb.client.request.TraceFetchRequest;
+import org.apache.skywalking.banyandb.client.request.TraceSearchRequest;
+import org.apache.skywalking.banyandb.client.request.TraceWriteRequest;
+import org.apache.skywalking.banyandb.client.response.BanyanDBEntity;
+import org.apache.skywalking.banyandb.client.response.BanyanDBQueryResponse;
+
+import java.util.List;
+import java.util.concurrent.TimeUnit;
+import java.util.stream.Collectors;
+
+@Slf4j
+public class BanyanDBGrpcClient implements BanyanDBService {
+ private final TraceServiceGrpc.TraceServiceBlockingStub stub;
+ private final TraceServiceGrpc.TraceServiceStub asyncStub;
+
+ public BanyanDBGrpcClient(ManagedChannel managedChannel) {
+ this.stub = TraceServiceGrpc.newBlockingStub(managedChannel);
+ this.asyncStub = TraceServiceGrpc.newStub(managedChannel);
+ }
+
+ @Override
+ public BanyanDBQueryResponse queryBasicTraces(TraceSearchRequest request) {
+ Query.QueryRequest.Builder queryBuilder = Query.QueryRequest.newBuilder()
+ .setMetadata(Database.Metadata.newBuilder().setGroup(request.getGroup()).setName(request.getName()).build());
+
+ if (request.getTimeRange() != null && request.getTimeRange().getStartTime() != 0 && request.getTimeRange().getEndTime() != 0) {
+ queryBuilder.setTimeRange(Query.TimeRange.newBuilder()
+ .setBegin(Timestamp.newBuilder().setSeconds(request.getTimeRange().getStartTime()))
+ .setEnd(Timestamp.newBuilder().setSeconds(request.getTimeRange().getEndTime())).build());
+ }
+
+ request.getQueries().forEach(q -> queryBuilder.addFields(q.toPairQuery()));
+
+ queryBuilder.setOrderBy(Query.QueryOrder.newBuilder()
+ .setKeyName(request.getQueryOrderField())
+ .setSort(request.getQueryOrderSort().getSort())
+ .build());
+
+ queryBuilder.setProjection(Query.Projection.newBuilder()
+ .addAllKeyNames(request.getProjections())
+ .build());
+ queryBuilder.setLimit(request.getLimit());
+ queryBuilder.setOffset(request.getOffset());
+
+ return convertToResponse(this.stub.query(queryBuilder.build()));
+ }
+
+ @Override
+ public BanyanDBQueryResponse queryByTraceId(TraceFetchRequest traceFetchRequest) {
+ Query.QueryRequest.Builder queryBuilder = Query.QueryRequest.newBuilder()
+ .setMetadata(Database.Metadata.newBuilder().setGroup(traceFetchRequest.getGroup()).setName(traceFetchRequest.getName()).build())
+ .addFields(Query.PairQuery.newBuilder()
+ .setOp(Query.PairQuery.BinaryOp.BINARY_OP_EQ)
+ .setCondition(Query.TypedPair.newBuilder().setStrPair(Query.StrPair.newBuilder().setKey("trace_id").addValues(traceFetchRequest.getTraceId()).build()))
+ .build())
+ .setProjection(Query.Projection.newBuilder()
+ .addAllKeyNames(traceFetchRequest.getProjections())
+ .build());
+ return convertToResponse(this.stub.query(queryBuilder.build()));
+ }
+
+ static BanyanDBQueryResponse convertToResponse(Query.QueryResponse response) {
+ BanyanDBQueryResponse r = new BanyanDBQueryResponse();
+ r.setTotal(response.getEntitiesCount());
+ for (final Query.Entity entity : response.getEntitiesList()) {
+ BanyanDBEntity.BanyanDBEntityBuilder entityBuilder = BanyanDBEntity.builder();
+ for (final Query.TypedPair typedPair : entity.getFieldsList()) {
+ if (typedPair.hasIntPair()) {
+ final Query.IntPair pair = typedPair.getIntPair();
+ entityBuilder.field(pair.getKey(), pair.getValuesList().get(0));
+ } else if (typedPair.hasStrPair()) {
+ final Query.StrPair pair = typedPair.getStrPair();
+ entityBuilder.field(pair.getKey(), pair.getValuesList().get(0));
+ }
+ }
+ entityBuilder.entityId(entity.getEntityId());
+ entityBuilder.binaryData(entity.getDataBinary().toByteArray());
+ entityBuilder.timestampSeconds(entity.getTimestamp().getSeconds());
+ entityBuilder.timestampNanoSeconds(entity.getTimestamp().getNanos());
+ r.getEntities().add(entityBuilder.build());
+ }
+
+ return r;
+ }
+
+ @Override
+ public void writeEntity(List<TraceWriteRequest> data) {
+ StreamObserver<org.apache.skywalking.banyandb.Write.WriteRequest> observer = this.asyncStub.withDeadlineAfter(30, TimeUnit.SECONDS)
+ .write(new StreamObserver<Write.WriteResponse>() {
+ @Override
+ public void onNext(Write.WriteResponse writeResponse) {
+ }
+
+ @Override
+ public void onError(Throwable throwable) {
+ log.error("fail to send request", throwable);
+ }
+
+ @Override
+ public void onCompleted() {
+ }
+ });
+
+ for (final TraceWriteRequest entity : data) {
+ try {
+ Write.EntityValue entityValue = Write.EntityValue.newBuilder()
+ .addAllFields(buildWriteFields(entity.getFields()))
+ .setDataBinary(ByteString.copyFrom(entity.getDataBinary()))
+ .setTimestamp(Timestamp.newBuilder().setSeconds(entity.getTimestampSeconds()).setNanos(entity.getTimestampNanos()).build())
+ .setEntityId(entity.getEntityId()).build();
+ observer.onNext(Write.WriteRequest.newBuilder()
+ .setMetadata(Database.Metadata.newBuilder().setName(entity.getName()).setGroup(entity.getGroup()).build())
+ .setEntity(entityValue).build());
+ } catch (Throwable t) {
+ log.error("fail to convert entityValue and send data");
+ }
+ }
+
+ observer.onCompleted();
+ }
+
+ @VisibleForTesting
+ public static List<Write.Field> buildWriteFields(List<Object> fieldList) {
+ return fieldList.stream().map(BanyanDBGrpcClient::buildField).collect(Collectors.toList());
+ }
+
+ static Write.Field buildField(Object value) {
Review comment:
No `instanceof` now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#issuecomment-897513283
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`banyandb-integration@6a241ae`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
> :exclamation: Current head 8f64497 differs from pull request most recent head 6f8e95e. Consider uploading reports for the commit 6f8e95e to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## banyandb-integration #7448 +/- ##
=======================================================
Coverage ? 57.38%
Complexity ? 4314
=======================================================
Files ? 1034
Lines ? 26565
Branches ? 2625
=======================================================
Hits ? 15245
Misses ? 9983
Partials ? 1337
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6a241ae...6f8e95e](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#issuecomment-897513283
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`banyandb-integration@6a241ae`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## banyandb-integration #7448 +/- ##
=======================================================
Coverage ? 58.23%
Complexity ? 4360
=======================================================
Files ? 1034
Lines ? 26565
Branches ? 2625
=======================================================
Hits ? 15469
Misses ? 9733
Partials ? 1363
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6a241ae...360972e](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#issuecomment-897513283
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`banyandb-integration@6a241ae`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
> :exclamation: Current head e4dbd20 differs from pull request most recent head 0c80a8a. Consider uploading reports for the commit 0c80a8a to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## banyandb-integration #7448 +/- ##
=======================================================
Coverage ? 57.10%
Complexity ? 4297
=======================================================
Files ? 1034
Lines ? 26555
Branches ? 2624
=======================================================
Hits ? 15164
Misses ? 10049
Partials ? 1342
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6a241ae...0c80a8a](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#issuecomment-897513283
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`banyandb-integration@6a241ae`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
> :exclamation: Current head 8f64497 differs from pull request most recent head 2f8a712. Consider uploading reports for the commit 2f8a712 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## banyandb-integration #7448 +/- ##
=======================================================
Coverage ? 58.64%
Complexity ? 4374
=======================================================
Files ? 1034
Lines ? 26565
Branches ? 2625
=======================================================
Hits ? 15580
Misses ? 9607
Partials ? 1378
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6a241ae...2f8a712](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#issuecomment-897513283
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`banyandb-integration@6a241ae`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
> :exclamation: Current head 2417819 differs from pull request most recent head 360972e. Consider uploading reports for the commit 360972e to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## banyandb-integration #7448 +/- ##
=======================================================
Coverage ? 58.70%
Complexity ? 4384
=======================================================
Files ? 1034
Lines ? 26565
Branches ? 2625
=======================================================
Hits ? 15596
Misses ? 9587
Partials ? 1382
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6a241ae...360972e](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#issuecomment-897513283
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`banyandb-integration@6a241ae`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## banyandb-integration #7448 +/- ##
=======================================================
Coverage ? 46.26%
Complexity ? 2998
=======================================================
Files ? 876
Lines ? 22474
Branches ? 2160
=======================================================
Hits ? 10398
Misses ? 11215
Partials ? 861
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6a241ae...2b48fc3](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#issuecomment-898430471
@lujiajing1126 I open https://github.com/apache/skywalking/pull/7455/ for you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#issuecomment-897513283
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`banyandb-integration@6a241ae`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## banyandb-integration #7448 +/- ##
=======================================================
Coverage ? 40.59%
Complexity ? 2572
=======================================================
Files ? 845
Lines ? 21476
Branches ? 2062
=======================================================
Hits ? 8718
Misses ? 12070
Partials ? 688
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6a241ae...360972e](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#issuecomment-897513283
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`banyandb-integration@6a241ae`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## banyandb-integration #7448 +/- ##
=======================================================
Coverage ? 58.76%
Complexity ? 4384
=======================================================
Files ? 1034
Lines ? 26565
Branches ? 2625
=======================================================
Hits ? 15612
Misses ? 9566
Partials ? 1387
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6a241ae...360972e](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#issuecomment-897513283
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`banyandb-integration@6a241ae`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
> :exclamation: Current head e4dbd20 differs from pull request most recent head 0c80a8a. Consider uploading reports for the commit 0c80a8a to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## banyandb-integration #7448 +/- ##
=======================================================
Coverage ? 54.44%
Complexity ? 4152
=======================================================
Files ? 1034
Lines ? 26550
Branches ? 2620
=======================================================
Hits ? 14454
Misses ? 10796
Partials ? 1300
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6a241ae...0c80a8a](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#issuecomment-897513283
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`banyandb-integration@6a241ae`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
> :exclamation: Current head e4dbd20 differs from pull request most recent head 0c80a8a. Consider uploading reports for the commit 0c80a8a to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## banyandb-integration #7448 +/- ##
=======================================================
Coverage ? 37.97%
Complexity ? 2405
=======================================================
Files ? 845
Lines ? 21455
Branches ? 2061
=======================================================
Hits ? 8148
Misses ? 12695
Partials ? 612
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6a241ae...0c80a8a](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#issuecomment-897513283
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`banyandb-integration@6a241ae`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
> :exclamation: Current head 8f64497 differs from pull request most recent head 6f8e95e. Consider uploading reports for the commit 6f8e95e to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## banyandb-integration #7448 +/- ##
=======================================================
Coverage ? 46.12%
Complexity ? 2991
=======================================================
Files ? 876
Lines ? 22599
Branches ? 2173
=======================================================
Hits ? 10424
Misses ? 11350
Partials ? 825
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6a241ae...6f8e95e](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#issuecomment-897513283
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`banyandb-integration@6a241ae`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## banyandb-integration #7448 +/- ##
=======================================================
Coverage ? 57.47%
Complexity ? 4318
=======================================================
Files ? 1034
Lines ? 26565
Branches ? 2625
=======================================================
Hits ? 15269
Misses ? 9945
Partials ? 1351
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6a241ae...360972e](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#issuecomment-897513283
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#discussion_r687670044
##########
File path: oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/banyandb/client/impl/BanyanDBGrpcClient.java
##########
@@ -0,0 +1,173 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.banyandb.client.impl;
+
+import com.google.common.annotations.VisibleForTesting;
+import com.google.protobuf.ByteString;
+import com.google.protobuf.NullValue;
+import com.google.protobuf.Timestamp;
+import io.grpc.ManagedChannel;
+import io.grpc.stub.StreamObserver;
+import lombok.extern.slf4j.Slf4j;
+import org.apache.skywalking.banyandb.Database;
+import org.apache.skywalking.banyandb.Query;
+import org.apache.skywalking.banyandb.TraceServiceGrpc;
+import org.apache.skywalking.banyandb.Write;
+import org.apache.skywalking.banyandb.client.BanyanDBService;
+import org.apache.skywalking.banyandb.client.request.TraceFetchRequest;
+import org.apache.skywalking.banyandb.client.request.TraceSearchRequest;
+import org.apache.skywalking.banyandb.client.request.TraceWriteRequest;
+import org.apache.skywalking.banyandb.client.response.BanyanDBEntity;
+import org.apache.skywalking.banyandb.client.response.BanyanDBQueryResponse;
+
+import java.util.List;
+import java.util.concurrent.TimeUnit;
+import java.util.stream.Collectors;
+
+@Slf4j
+public class BanyanDBGrpcClient implements BanyanDBService {
+ private final TraceServiceGrpc.TraceServiceBlockingStub stub;
+ private final TraceServiceGrpc.TraceServiceStub asyncStub;
+
+ public BanyanDBGrpcClient(ManagedChannel managedChannel) {
+ this.stub = TraceServiceGrpc.newBlockingStub(managedChannel);
+ this.asyncStub = TraceServiceGrpc.newStub(managedChannel);
+ }
+
+ @Override
+ public BanyanDBQueryResponse queryBasicTraces(TraceSearchRequest request) {
+ Query.QueryRequest.Builder queryBuilder = Query.QueryRequest.newBuilder()
+ .setMetadata(Database.Metadata.newBuilder().setGroup(request.getGroup()).setName(request.getName()).build());
+
+ if (request.getTimeRange() != null && request.getTimeRange().getStartTime() != 0 && request.getTimeRange().getEndTime() != 0) {
+ queryBuilder.setTimeRange(Query.TimeRange.newBuilder()
+ .setBegin(Timestamp.newBuilder().setSeconds(request.getTimeRange().getStartTime()))
+ .setEnd(Timestamp.newBuilder().setSeconds(request.getTimeRange().getEndTime())).build());
+ }
+
+ request.getQueries().forEach(q -> queryBuilder.addFields(q.toPairQuery()));
+
+ queryBuilder.setOrderBy(Query.QueryOrder.newBuilder()
+ .setKeyName(request.getQueryOrderField())
+ .setSort(request.getQueryOrderSort().getSort())
+ .build());
+
+ queryBuilder.setProjection(Query.Projection.newBuilder()
+ .addAllKeyNames(request.getProjections())
+ .build());
+ queryBuilder.setLimit(request.getLimit());
+ queryBuilder.setOffset(request.getOffset());
+
+ return convertToResponse(this.stub.query(queryBuilder.build()));
+ }
+
+ @Override
+ public BanyanDBQueryResponse queryByTraceId(TraceFetchRequest traceFetchRequest) {
+ Query.QueryRequest.Builder queryBuilder = Query.QueryRequest.newBuilder()
+ .setMetadata(Database.Metadata.newBuilder().setGroup(traceFetchRequest.getGroup()).setName(traceFetchRequest.getName()).build())
+ .addFields(Query.PairQuery.newBuilder()
+ .setOp(Query.PairQuery.BinaryOp.BINARY_OP_EQ)
+ .setCondition(Query.TypedPair.newBuilder().setStrPair(Query.StrPair.newBuilder().setKey("trace_id").addValues(traceFetchRequest.getTraceId()).build()))
+ .build())
+ .setProjection(Query.Projection.newBuilder()
+ .addAllKeyNames(traceFetchRequest.getProjections())
+ .build());
+ return convertToResponse(this.stub.query(queryBuilder.build()));
+ }
+
+ static BanyanDBQueryResponse convertToResponse(Query.QueryResponse response) {
+ BanyanDBQueryResponse r = new BanyanDBQueryResponse();
+ r.setTotal(response.getEntitiesCount());
+ for (final Query.Entity entity : response.getEntitiesList()) {
+ BanyanDBEntity.BanyanDBEntityBuilder entityBuilder = BanyanDBEntity.builder();
+ for (final Query.TypedPair typedPair : entity.getFieldsList()) {
+ if (typedPair.hasIntPair()) {
+ final Query.IntPair pair = typedPair.getIntPair();
+ entityBuilder.field(pair.getKey(), pair.getValuesList().get(0));
+ } else if (typedPair.hasStrPair()) {
+ final Query.StrPair pair = typedPair.getStrPair();
+ entityBuilder.field(pair.getKey(), pair.getValuesList().get(0));
+ }
+ }
+ entityBuilder.entityId(entity.getEntityId());
+ entityBuilder.binaryData(entity.getDataBinary().toByteArray());
+ entityBuilder.timestampSeconds(entity.getTimestamp().getSeconds());
+ entityBuilder.timestampNanoSeconds(entity.getTimestamp().getNanos());
+ r.getEntities().add(entityBuilder.build());
+ }
+
+ return r;
+ }
+
+ @Override
+ public void writeEntity(List<TraceWriteRequest> data) {
+ StreamObserver<org.apache.skywalking.banyandb.Write.WriteRequest> observer = this.asyncStub.withDeadlineAfter(30, TimeUnit.SECONDS)
+ .write(new StreamObserver<Write.WriteResponse>() {
+ @Override
+ public void onNext(Write.WriteResponse writeResponse) {
+ }
+
+ @Override
+ public void onError(Throwable throwable) {
+ log.error("fail to send request", throwable);
+ }
+
+ @Override
+ public void onCompleted() {
+ }
+ });
+
+ for (final TraceWriteRequest entity : data) {
+ try {
+ Write.EntityValue entityValue = Write.EntityValue.newBuilder()
+ .addAllFields(buildWriteFields(entity.getFields()))
+ .setDataBinary(ByteString.copyFrom(entity.getDataBinary()))
+ .setTimestamp(Timestamp.newBuilder().setSeconds(entity.getTimestampSeconds()).setNanos(entity.getTimestampNanos()).build())
+ .setEntityId(entity.getEntityId()).build();
+ observer.onNext(Write.WriteRequest.newBuilder()
+ .setMetadata(Database.Metadata.newBuilder().setName(entity.getName()).setGroup(entity.getGroup()).build())
+ .setEntity(entityValue).build());
+ } catch (Throwable t) {
+ log.error("fail to convert entityValue and send data");
+ }
+ }
+
+ observer.onCompleted();
+ }
+
+ @VisibleForTesting
+ public static List<Write.Field> buildWriteFields(List<Object> fieldList) {
+ return fieldList.stream().map(BanyanDBGrpcClient::buildField).collect(Collectors.toList());
+ }
+
+ static Write.Field buildField(Object value) {
Review comment:
Don't use `instance of`, use overload for different types of parameters, which have much better performance and easier to read.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#issuecomment-897513283
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`banyandb-integration@6a241ae`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
> :exclamation: Current head 8f64497 differs from pull request most recent head 0c80a8a. Consider uploading reports for the commit 0c80a8a to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## banyandb-integration #7448 +/- ##
=======================================================
Coverage ? 58.64%
Complexity ? 4374
=======================================================
Files ? 1034
Lines ? 26565
Branches ? 2625
=======================================================
Hits ? 15580
Misses ? 9607
Partials ? 1378
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6a241ae...0c80a8a](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#issuecomment-897513283
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`banyandb-integration@6a241ae`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## banyandb-integration #7448 +/- ##
=======================================================
Coverage ? 42.36%
Complexity ? 2791
=======================================================
Files ? 876
Lines ? 22474
Branches ? 2160
=======================================================
Hits ? 9521
Misses ? 12173
Partials ? 780
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6a241ae...2b48fc3](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#issuecomment-897513283
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`banyandb-integration@6a241ae`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
> :exclamation: Current head 2417819 differs from pull request most recent head 738cf7c. Consider uploading reports for the commit 738cf7c to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## banyandb-integration #7448 +/- ##
=======================================================
Coverage ? 55.53%
Complexity ? 4193
=======================================================
Files ? 1034
Lines ? 26537
Branches ? 2620
=======================================================
Hits ? 14737
Misses ? 10521
Partials ? 1279
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6a241ae...738cf7c](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#issuecomment-897513283
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`banyandb-integration@6a241ae`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## banyandb-integration #7448 +/- ##
=======================================================
Coverage ? 57.53%
Complexity ? 4325
=======================================================
Files ? 1034
Lines ? 26565
Branches ? 2625
=======================================================
Hits ? 15285
Misses ? 9925
Partials ? 1355
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6a241ae...360972e](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#issuecomment-897513283
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`banyandb-integration@6a241ae`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
> :exclamation: Current head 8f64497 differs from pull request most recent head 6f8e95e. Consider uploading reports for the commit 6f8e95e to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## banyandb-integration #7448 +/- ##
=======================================================
Coverage ? 43.32%
Complexity ? 2855
=======================================================
Files ? 876
Lines ? 22563
Branches ? 2172
=======================================================
Hits ? 9776
Misses ? 12017
Partials ? 770
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6a241ae...6f8e95e](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#issuecomment-897513283
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`banyandb-integration@6a241ae`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
> :exclamation: Current head 8f64497 differs from pull request most recent head 6f8e95e. Consider uploading reports for the commit 6f8e95e to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## banyandb-integration #7448 +/- ##
=======================================================
Coverage ? 58.25%
Complexity ? 4347
=======================================================
Files ? 1034
Lines ? 26565
Branches ? 2625
=======================================================
Hits ? 15475
Misses ? 9735
Partials ? 1355
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6a241ae...6f8e95e](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#issuecomment-897513283
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`banyandb-integration@6a241ae`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
> :exclamation: Current head 8f64497 differs from pull request most recent head 6f8e95e. Consider uploading reports for the commit 6f8e95e to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## banyandb-integration #7448 +/- ##
=======================================================
Coverage ? 30.86%
Complexity ? 2086
=======================================================
Files ? 875
Lines ? 22200
Branches ? 2097
=======================================================
Hits ? 6853
Misses ? 14855
Partials ? 492
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6a241ae...6f8e95e](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#issuecomment-897513283
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`banyandb-integration@6a241ae`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
> :exclamation: Current head e4dbd20 differs from pull request most recent head 0c80a8a. Consider uploading reports for the commit 0c80a8a to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## banyandb-integration #7448 +/- ##
=======================================================
Coverage ? 57.38%
Complexity ? 4314
=======================================================
Files ? 1034
Lines ? 26555
Branches ? 2624
=======================================================
Hits ? 15239
Misses ? 9962
Partials ? 1354
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6a241ae...0c80a8a](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#issuecomment-897513283
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`banyandb-integration@6a241ae`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
> :exclamation: Current head 8f64497 differs from pull request most recent head 6f8e95e. Consider uploading reports for the commit 6f8e95e to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## banyandb-integration #7448 +/- ##
=======================================================
Coverage ? 57.29%
Complexity ? 4308
=======================================================
Files ? 1034
Lines ? 26565
Branches ? 2625
=======================================================
Hits ? 15221
Misses ? 10006
Partials ? 1338
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6a241ae...6f8e95e](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#issuecomment-897513283
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#issuecomment-897513283
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`banyandb-integration@6a241ae`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## banyandb-integration #7448 +/- ##
=======================================================
Coverage ? 32.32%
Complexity ? 2107
=======================================================
Files ? 844
Lines ? 21385
Branches ? 2053
=======================================================
Hits ? 6913
Misses ? 13923
Partials ? 549
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6a241ae...2b48fc3](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#issuecomment-897513283
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`banyandb-integration@6a241ae`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
> :exclamation: Current head 2417819 differs from pull request most recent head 738cf7c. Consider uploading reports for the commit 738cf7c to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## banyandb-integration #7448 +/- ##
=======================================================
Coverage ? 57.53%
Complexity ? 4326
=======================================================
Files ? 1034
Lines ? 26565
Branches ? 2625
=======================================================
Hits ? 15284
Misses ? 9950
Partials ? 1331
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6a241ae...738cf7c](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#issuecomment-897513283
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`banyandb-integration@6a241ae`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
> :exclamation: Current head e4dbd20 differs from pull request most recent head 2a4977f. Consider uploading reports for the commit 2a4977f to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## banyandb-integration #7448 +/- ##
=======================================================
Coverage ? 57.91%
Complexity ? 4341
=======================================================
Files ? 1034
Lines ? 26555
Branches ? 2624
=======================================================
Hits ? 15379
Misses ? 9810
Partials ? 1366
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6a241ae...2a4977f](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#issuecomment-897513283
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`banyandb-integration@6a241ae`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
> :exclamation: Current head e4dbd20 differs from pull request most recent head 0c80a8a. Consider uploading reports for the commit 0c80a8a to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## banyandb-integration #7448 +/- ##
=======================================================
Coverage ? 57.84%
Complexity ? 4335
=======================================================
Files ? 1034
Lines ? 26555
Branches ? 2624
=======================================================
Hits ? 15361
Misses ? 9833
Partials ? 1361
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6a241ae...0c80a8a](https://codecov.io/gh/apache/skywalking/pull/7448?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #7448: Banyandb integration
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#discussion_r687676447
##########
File path: oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/banyandb/BanyanDBClient.java
##########
@@ -0,0 +1,125 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.server.storage.plugin.banyandb;
+
+import com.google.common.annotations.VisibleForTesting;
+import io.grpc.ManagedChannel;
+import io.grpc.ManagedChannelBuilder;
+import io.grpc.netty.NettyChannelBuilder;
+import io.netty.handler.ssl.SslContext;
+import org.apache.skywalking.banyandb.client.BanyanDBService;
+import org.apache.skywalking.banyandb.client.impl.BanyanDBGrpcClient;
+import org.apache.skywalking.banyandb.client.request.TraceFetchRequest;
+import org.apache.skywalking.banyandb.client.request.TraceSearchRequest;
+import org.apache.skywalking.banyandb.client.request.TraceWriteRequest;
+import org.apache.skywalking.banyandb.client.response.BanyanDBQueryResponse;
+import org.apache.skywalking.oap.server.library.client.Client;
+import org.apache.skywalking.oap.server.library.client.healthcheck.DelegatedHealthChecker;
+import org.apache.skywalking.oap.server.library.client.healthcheck.HealthCheckable;
+import org.apache.skywalking.oap.server.library.util.HealthChecker;
+
+import java.io.IOException;
+import java.util.List;
+import java.util.concurrent.TimeUnit;
+
+public class BanyanDBClient implements Client, BanyanDBService, HealthCheckable {
Review comment:
Please separate this as 2 parts, one is BanyanDB API, the other is OAP DB client.
You still expose the gRPC here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org