You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by haosdent huang <ha...@gmail.com> on 2015/06/01 19:24:47 UTC

Re: Review Request 34645: Update existing lambdas to meet style guide

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34645/
-----------------------------------------------------------

(Updated June 1, 2015, 5:24 p.m.)


Review request for mesos, Benjamin Hindman and Joris Van Remoortere.


Bugs: MESOS-2670
    https://issues.apache.org/jira/browse/MESOS-2670


Repository: mesos


Description
-------

Update existing lambdas to meet style guide


Diffs (updated)
-----

  src/master/master.cpp 710b8149c9d855d0f47cb2952366be10bc78c74d 

Diff: https://reviews.apache.org/r/34645/diff/


Testing
-------


Thanks,

haosdent huang

Re: Review Request 34645: Update existing lambdas to meet style guide

Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34645/#review87149
-----------------------------------------------------------

Ship it!


Ship It!

- Benjamin Hindman


On June 1, 2015, 5:26 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34645/
> -----------------------------------------------------------
> 
> (Updated June 1, 2015, 5:26 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-2670
>     https://issues.apache.org/jira/browse/MESOS-2670
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Update existing lambdas to meet style guide
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp 710b8149c9d855d0f47cb2952366be10bc78c74d 
> 
> Diff: https://reviews.apache.org/r/34645/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 34645: Update existing lambdas to meet style guide

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34645/#review86056
-----------------------------------------------------------


Patch looks great!

Reviews applied: [34644, 34645]

All tests passed.

- Mesos ReviewBot


On June 1, 2015, 5:26 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34645/
> -----------------------------------------------------------
> 
> (Updated June 1, 2015, 5:26 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-2670
>     https://issues.apache.org/jira/browse/MESOS-2670
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Update existing lambdas to meet style guide
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp 710b8149c9d855d0f47cb2952366be10bc78c74d 
> 
> Diff: https://reviews.apache.org/r/34645/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 34645: Update existing lambdas to meet style guide

Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34645/#review87147
-----------------------------------------------------------

Ship it!


I'll get this and your other patch committed with BenH.
Thanks!


src/master/master.cpp
<https://reviews.apache.org/r/34645/#comment139466>

    We don't need the `this->`. That is a Java thing :-)


- Joris Van Remoortere


On June 1, 2015, 5:26 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34645/
> -----------------------------------------------------------
> 
> (Updated June 1, 2015, 5:26 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-2670
>     https://issues.apache.org/jira/browse/MESOS-2670
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Update existing lambdas to meet style guide
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp 710b8149c9d855d0f47cb2952366be10bc78c74d 
> 
> Diff: https://reviews.apache.org/r/34645/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 34645: Update existing lambdas to meet style guide

Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34645/
-----------------------------------------------------------

(Updated June 1, 2015, 5:26 p.m.)


Review request for mesos, Benjamin Hindman and Joris Van Remoortere.


Bugs: MESOS-2670
    https://issues.apache.org/jira/browse/MESOS-2670


Repository: mesos


Description
-------

Update existing lambdas to meet style guide


Diffs (updated)
-----

  src/master/master.cpp 710b8149c9d855d0f47cb2952366be10bc78c74d 

Diff: https://reviews.apache.org/r/34645/diff/


Testing
-------


Thanks,

haosdent huang