[jira] [Commented] (ZOOKEEPER-1847) Normalize line endings in repository

["Enis Soztutar (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13891187#comment-13891187 ] 

Enis Soztutar commented on ZOOKEEPER-1847:
------------------------------------------

bq. Yeah, -1 to doing this as a whole-scale change to the whole repo.
I fail to understand your reasoning. Do you suggest we do this file by file? I think we have to normalize on line endings and fix the ones in the repo. 
If you want to enforce standard line endings, the best practice is to enforce it from the source control. The gitattributes file introduced in this patch enforces this, and the patch fixes the endings to that a fresh checkout will contain normalized line endings which will ensure seamless setup in linux or windows dev environments. 

> Normalize line endings in repository
> ------------------------------------
>
>                 Key: ZOOKEEPER-1847
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1847
>             Project: ZooKeeper
>          Issue Type: Bug
>            Reporter: Enis Soztutar
>            Assignee: Enis Soztutar
>             Fix For: 3.5.0
>
>         Attachments: zookeeper-1847_v1.patch
>
>
> It is good practice to have all the code in the repository use the same line endings (LF) so that patches can be applied normally. We can add a gitattributes file so that checked out code can still have platform dependent line endings. 
> More readings: 
> https://help.github.com/articles/dealing-with-line-endings
> http://stackoverflow.com/questions/170961/whats-the-best-crlf-handling-strategy-with-git



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)