You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Brijesh Bhalala <br...@gmail.com> on 2023/06/13 06:21:21 UTC
Review Request 74475: RANGER-4272: Improvise services shown on the Left Sidebar
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74475/
-----------------------------------------------------------
Review request for ranger, Dhaval Rajpara, Dineshkumar Yadav, Madhan Neethiraj, Mehul Parikh, Mugdha Varadkar, Nikunj Pansuriya, and Nitin Galave.
Bugs: RANGER-4272
https://issues.apache.org/jira/browse/RANGER-4272
Repository: ranger
Description
-------
As a part of RANGER-4253, Ranger Admin UI with react code will have only left sidebar layout.
This is is tracking below review suggestions :
1)Show only those Service Types which are having the Services on the sidebar drawer.
2)UX improvement change to distinguish between the Service Type and the services.
Diffs
-----
security-admin/src/main/webapp/react-webapp/src/styles/style.css 893f428f1
security-admin/src/main/webapp/react-webapp/src/views/SideBar/ResourceTagContent.jsx 953612d48
security-admin/src/main/webapp/react-webapp/src/views/SideBar/SideBar.jsx 0a261348d
security-admin/src/main/webapp/react-webapp/src/views/SideBar/SideBarBody.jsx f97247148
security-admin/src/main/webapp/react-webapp/src/views/SideBar/TopNavBar.jsx 4cc072a7e
Diff: https://reviews.apache.org/r/74475/diff/1/
Testing
-------
1)Build and Verified Ranger Admin setup with this changes.
2)Verified the following things:-
1)CRUD Operation in service & policy mdoule.
2)Service & policy listing pages.
Thanks,
Brijesh Bhalala
Re: Review Request 74475: RANGER-4272: Improvise services shown on the Left Sidebar
Posted by Dhaval Rajpara <dh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74475/#review225542
-----------------------------------------------------------
Ship it!
Ship It!
- Dhaval Rajpara
On June 13, 2023, 1:12 p.m., Brijesh Bhalala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74475/
> -----------------------------------------------------------
>
> (Updated June 13, 2023, 1:12 p.m.)
>
>
> Review request for ranger, Dhaval Rajpara, Dineshkumar Yadav, Madhan Neethiraj, Mehul Parikh, Mugdha Varadkar, Nikunj Pansuriya, and Nitin Galave.
>
>
> Bugs: RANGER-4272
> https://issues.apache.org/jira/browse/RANGER-4272
>
>
> Repository: ranger
>
>
> Description
> -------
>
> As a part of RANGER-4253, Ranger Admin UI with react code will have only left sidebar layout.
> This is is tracking below review suggestions :
> 1)Show only those Service Types which are having the Services on the sidebar drawer.
> 2)UX improvement change to distinguish between the Service Type and the services.
>
>
> Diffs
> -----
>
> security-admin/src/main/webapp/react-webapp/src/styles/style.css 893f428f1
> security-admin/src/main/webapp/react-webapp/src/views/SideBar/ResourceTagContent.jsx 953612d48
> security-admin/src/main/webapp/react-webapp/src/views/SideBar/SideBar.jsx 0a261348d
> security-admin/src/main/webapp/react-webapp/src/views/SideBar/SideBarBody.jsx f97247148
> security-admin/src/main/webapp/react-webapp/src/views/SideBar/TopNavBar.jsx 4cc072a7e
>
>
> Diff: https://reviews.apache.org/r/74475/diff/2/
>
>
> Testing
> -------
>
> 1)Build and Verified Ranger Admin setup with this changes.
> 2)Verified the following things:-
> 1)CRUD Operation in service & policy module.
> 2)Service & policy listing pages.
>
>
> Thanks,
>
> Brijesh Bhalala
>
>
Re: Review Request 74475: RANGER-4272: Improvise services shown on the Left Sidebar
Posted by Mugdha Varadkar <mu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74475/#review225540
-----------------------------------------------------------
Ship it!
Ship It!
- Mugdha Varadkar
On June 13, 2023, 1:12 p.m., Brijesh Bhalala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74475/
> -----------------------------------------------------------
>
> (Updated June 13, 2023, 1:12 p.m.)
>
>
> Review request for ranger, Dhaval Rajpara, Dineshkumar Yadav, Madhan Neethiraj, Mehul Parikh, Mugdha Varadkar, Nikunj Pansuriya, and Nitin Galave.
>
>
> Bugs: RANGER-4272
> https://issues.apache.org/jira/browse/RANGER-4272
>
>
> Repository: ranger
>
>
> Description
> -------
>
> As a part of RANGER-4253, Ranger Admin UI with react code will have only left sidebar layout.
> This is is tracking below review suggestions :
> 1)Show only those Service Types which are having the Services on the sidebar drawer.
> 2)UX improvement change to distinguish between the Service Type and the services.
>
>
> Diffs
> -----
>
> security-admin/src/main/webapp/react-webapp/src/styles/style.css 893f428f1
> security-admin/src/main/webapp/react-webapp/src/views/SideBar/ResourceTagContent.jsx 953612d48
> security-admin/src/main/webapp/react-webapp/src/views/SideBar/SideBar.jsx 0a261348d
> security-admin/src/main/webapp/react-webapp/src/views/SideBar/SideBarBody.jsx f97247148
> security-admin/src/main/webapp/react-webapp/src/views/SideBar/TopNavBar.jsx 4cc072a7e
>
>
> Diff: https://reviews.apache.org/r/74475/diff/2/
>
>
> Testing
> -------
>
> 1)Build and Verified Ranger Admin setup with this changes.
> 2)Verified the following things:-
> 1)CRUD Operation in service & policy module.
> 2)Service & policy listing pages.
>
>
> Thanks,
>
> Brijesh Bhalala
>
>
Re: Review Request 74475: RANGER-4272: Improvise services shown on the Left Sidebar
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74475/#review225544
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On June 13, 2023, 1:12 p.m., Brijesh Bhalala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74475/
> -----------------------------------------------------------
>
> (Updated June 13, 2023, 1:12 p.m.)
>
>
> Review request for ranger, Dhaval Rajpara, Dineshkumar Yadav, Madhan Neethiraj, Mehul Parikh, Mugdha Varadkar, Nikunj Pansuriya, and Nitin Galave.
>
>
> Bugs: RANGER-4272
> https://issues.apache.org/jira/browse/RANGER-4272
>
>
> Repository: ranger
>
>
> Description
> -------
>
> As a part of RANGER-4253, Ranger Admin UI with react code will have only left sidebar layout.
> This is is tracking below review suggestions :
> 1)Show only those Service Types which are having the Services on the sidebar drawer.
> 2)UX improvement change to distinguish between the Service Type and the services.
>
>
> Diffs
> -----
>
> security-admin/src/main/webapp/react-webapp/src/styles/style.css 893f428f1
> security-admin/src/main/webapp/react-webapp/src/views/SideBar/ResourceTagContent.jsx 953612d48
> security-admin/src/main/webapp/react-webapp/src/views/SideBar/SideBar.jsx 0a261348d
> security-admin/src/main/webapp/react-webapp/src/views/SideBar/SideBarBody.jsx f97247148
> security-admin/src/main/webapp/react-webapp/src/views/SideBar/TopNavBar.jsx 4cc072a7e
>
>
> Diff: https://reviews.apache.org/r/74475/diff/2/
>
>
> Testing
> -------
>
> 1)Build and Verified Ranger Admin setup with this changes.
> 2)Verified the following things:-
> 1)CRUD Operation in service & policy module.
> 2)Service & policy listing pages.
>
>
> Thanks,
>
> Brijesh Bhalala
>
>
Re: Review Request 74475: RANGER-4272: Improvise services shown on the Left Sidebar
Posted by Brijesh Bhalala <br...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74475/
-----------------------------------------------------------
(Updated June 13, 2023, 1:12 p.m.)
Review request for ranger, Dhaval Rajpara, Dineshkumar Yadav, Madhan Neethiraj, Mehul Parikh, Mugdha Varadkar, Nikunj Pansuriya, and Nitin Galave.
Bugs: RANGER-4272
https://issues.apache.org/jira/browse/RANGER-4272
Repository: ranger
Description
-------
As a part of RANGER-4253, Ranger Admin UI with react code will have only left sidebar layout.
This is is tracking below review suggestions :
1)Show only those Service Types which are having the Services on the sidebar drawer.
2)UX improvement change to distinguish between the Service Type and the services.
Diffs (updated)
-----
security-admin/src/main/webapp/react-webapp/src/styles/style.css 893f428f1
security-admin/src/main/webapp/react-webapp/src/views/SideBar/ResourceTagContent.jsx 953612d48
security-admin/src/main/webapp/react-webapp/src/views/SideBar/SideBar.jsx 0a261348d
security-admin/src/main/webapp/react-webapp/src/views/SideBar/SideBarBody.jsx f97247148
security-admin/src/main/webapp/react-webapp/src/views/SideBar/TopNavBar.jsx 4cc072a7e
Diff: https://reviews.apache.org/r/74475/diff/2/
Changes: https://reviews.apache.org/r/74475/diff/1-2/
Testing
-------
1)Build and Verified Ranger Admin setup with this changes.
2)Verified the following things:-
1)CRUD Operation in service & policy module.
2)Service & policy listing pages.
Thanks,
Brijesh Bhalala
Re: Review Request 74475: RANGER-4272: Improvise services shown on the Left Sidebar
Posted by Brijesh Bhalala <br...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74475/
-----------------------------------------------------------
(Updated June 13, 2023, 9:58 a.m.)
Review request for ranger, Dhaval Rajpara, Dineshkumar Yadav, Madhan Neethiraj, Mehul Parikh, Mugdha Varadkar, Nikunj Pansuriya, and Nitin Galave.
Bugs: RANGER-4272
https://issues.apache.org/jira/browse/RANGER-4272
Repository: ranger
Description
-------
As a part of RANGER-4253, Ranger Admin UI with react code will have only left sidebar layout.
This is is tracking below review suggestions :
1)Show only those Service Types which are having the Services on the sidebar drawer.
2)UX improvement change to distinguish between the Service Type and the services.
Diffs
-----
security-admin/src/main/webapp/react-webapp/src/styles/style.css 893f428f1
security-admin/src/main/webapp/react-webapp/src/views/SideBar/ResourceTagContent.jsx 953612d48
security-admin/src/main/webapp/react-webapp/src/views/SideBar/SideBar.jsx 0a261348d
security-admin/src/main/webapp/react-webapp/src/views/SideBar/SideBarBody.jsx f97247148
security-admin/src/main/webapp/react-webapp/src/views/SideBar/TopNavBar.jsx 4cc072a7e
Diff: https://reviews.apache.org/r/74475/diff/1/
Testing (updated)
-------
1)Build and Verified Ranger Admin setup with this changes.
2)Verified the following things:-
1)CRUD Operation in service & policy module.
2)Service & policy listing pages.
Thanks,
Brijesh Bhalala