You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gilbert Song <so...@gmail.com> on 2018/03/01 08:14:29 UTC
Re: Review Request 65759: Added inspect retries to the Docker
executor.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65759/#review198438
-----------------------------------------------------------
Ship it!
Ship It!
- Gilbert Song
On Feb. 28, 2018, 10:05 a.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65759/
> -----------------------------------------------------------
>
> (Updated Feb. 28, 2018, 10:05 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Gilbert Song, Greg Mann, and Michael Park.
>
>
> Bugs: MESOS-8574
> https://issues.apache.org/jira/browse/MESOS-8574
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds retries for `inspect` command to workaround docker
> daemon hangs. We assume that the docker daemon can be temporarily
> unresponsive. If it's unresponsive, then any started docker cli
> command hangs. To address the issue, we retry `inspect` in the loop.
>
>
> Diffs
> -----
>
> src/docker/executor.cpp 93c3e1d1e86814e34cbe5b045f6e61911266c535
>
>
> Diff: https://reviews.apache.org/r/65759/diff/6/
>
>
> Testing
> -------
>
> internal CI
>
> Manually, described in /r/65713
>
>
> Thanks,
>
> Andrei Budnik
>
>