You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/03/27 08:46:05 UTC
[GitHub] [flink] matriv opened a new pull request #19249: [FLINK-26092][table-runtime] Fix `JSON_OBJECTAGG` when emitting `NULL`
matriv opened a new pull request #19249:
URL: https://github.com/apache/flink/pull/19249
## What is the purpose of the change
Previously, when the Json aggregation is taking place, and id
JsonOnNull.NULL is selected, which means that we still want to emit
a `null` JSON node, .i.e `{.... "myField" : null ... }` when no values
get accumulated, we used a null `StringData` object. When
`state.backend.changelog.enabled` is enabled, the contents of the map
accumulating the aggregated records, gets serialized leading to NPE,
since `null` is not supported by `StringDataSerilizer`.
To solve this, we instead create a StringData with an empty `byte[]`,
which denotes the null, and when the aggregation ends and we create
the final JSON result, we check for a `byte[]` of `length` `0` in
order to write the JSON `null` node.
## Verifying this change
This change added tests and can be verified as follows:
- Change the parent class: `BuiltInAggregateFunctionTestBase` of `JsonAggregationFunctionsITCase` to run the whole set of tests with `state.backend.changelog.enabled` both `true` and `false`.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): **no**
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: **no**
- The serializers: **no**
- The runtime per-record code paths (performance sensitive): **no**
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: **no**
- The S3 file system connector: **no**
## Documentation
- Does this pull request introduce a new feature? **no**
- If yes, how is the feature documented? **not applicable**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19249: [FLINK-26092][table-runtime] Fix `JSON_OBJECTAGG` when emitting `NULL`
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19249:
URL: https://github.com/apache/flink/pull/19249#issuecomment-1079884730
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "42c8b7d3793c949b54aba0899089d745721a0f34",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33783",
"triggerID" : "42c8b7d3793c949b54aba0899089d745721a0f34",
"triggerType" : "PUSH"
}, {
"hash" : "46c05b37929a49451a6a7c029ba75366b30b7aef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33813",
"triggerID" : "46c05b37929a49451a6a7c029ba75366b30b7aef",
"triggerType" : "PUSH"
}, {
"hash" : "7c18a73b0a5e082593c9d87e94527a177791d5ba",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33900",
"triggerID" : "7c18a73b0a5e082593c9d87e94527a177791d5ba",
"triggerType" : "PUSH"
}, {
"hash" : "19917b9ec232b1732889e7923f77901d9139df34",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33914",
"triggerID" : "19917b9ec232b1732889e7923f77901d9139df34",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "1082134441",
"triggerType" : "MANUAL"
}, {
"hash" : "8904cf64426dc053a2636b0e9567deb7550eb931",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8904cf64426dc053a2636b0e9567deb7550eb931",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* Unknown: [CANCELED](TBD)
* 8904cf64426dc053a2636b0e9567deb7550eb931 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19249: [FLINK-26092][table-runtime] Fix `JSON_OBJECTAGG` when emitting `NULL`
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19249:
URL: https://github.com/apache/flink/pull/19249#issuecomment-1079884730
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "42c8b7d3793c949b54aba0899089d745721a0f34",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33783",
"triggerID" : "42c8b7d3793c949b54aba0899089d745721a0f34",
"triggerType" : "PUSH"
}, {
"hash" : "46c05b37929a49451a6a7c029ba75366b30b7aef",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33813",
"triggerID" : "46c05b37929a49451a6a7c029ba75366b30b7aef",
"triggerType" : "PUSH"
}, {
"hash" : "7c18a73b0a5e082593c9d87e94527a177791d5ba",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33900",
"triggerID" : "7c18a73b0a5e082593c9d87e94527a177791d5ba",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 46c05b37929a49451a6a7c029ba75366b30b7aef Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33813)
* 7c18a73b0a5e082593c9d87e94527a177791d5ba Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33900)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19249: [FLINK-26092][table-runtime] Fix `JSON_OBJECTAGG` when emitting `NULL`
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19249:
URL: https://github.com/apache/flink/pull/19249#issuecomment-1079884730
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "42c8b7d3793c949b54aba0899089d745721a0f34",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33783",
"triggerID" : "42c8b7d3793c949b54aba0899089d745721a0f34",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 42c8b7d3793c949b54aba0899089d745721a0f34 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33783)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #19249: [FLINK-26092][table-runtime] Fix `JSON_OBJECTAGG` when emitting `NULL`
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #19249:
URL: https://github.com/apache/flink/pull/19249#issuecomment-1079884730
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "42c8b7d3793c949b54aba0899089d745721a0f34",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "42c8b7d3793c949b54aba0899089d745721a0f34",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 42c8b7d3793c949b54aba0899089d745721a0f34 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19249: [FLINK-26092][table-runtime] Fix `JSON_OBJECTAGG` when emitting `NULL`
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19249:
URL: https://github.com/apache/flink/pull/19249#issuecomment-1079884730
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "42c8b7d3793c949b54aba0899089d745721a0f34",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33783",
"triggerID" : "42c8b7d3793c949b54aba0899089d745721a0f34",
"triggerType" : "PUSH"
}, {
"hash" : "46c05b37929a49451a6a7c029ba75366b30b7aef",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33813",
"triggerID" : "46c05b37929a49451a6a7c029ba75366b30b7aef",
"triggerType" : "PUSH"
}, {
"hash" : "7c18a73b0a5e082593c9d87e94527a177791d5ba",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7c18a73b0a5e082593c9d87e94527a177791d5ba",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 46c05b37929a49451a6a7c029ba75366b30b7aef Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33813)
* 7c18a73b0a5e082593c9d87e94527a177791d5ba UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19249: [FLINK-26092][table-runtime] Fix `JSON_OBJECTAGG` when emitting `NULL`
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19249:
URL: https://github.com/apache/flink/pull/19249#issuecomment-1079884730
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "42c8b7d3793c949b54aba0899089d745721a0f34",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33783",
"triggerID" : "42c8b7d3793c949b54aba0899089d745721a0f34",
"triggerType" : "PUSH"
}, {
"hash" : "46c05b37929a49451a6a7c029ba75366b30b7aef",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "46c05b37929a49451a6a7c029ba75366b30b7aef",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 42c8b7d3793c949b54aba0899089d745721a0f34 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33783)
* 46c05b37929a49451a6a7c029ba75366b30b7aef UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19249: [FLINK-26092][table-runtime] Fix `JSON_OBJECTAGG` when emitting `NULL`
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19249:
URL: https://github.com/apache/flink/pull/19249#issuecomment-1079884730
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "42c8b7d3793c949b54aba0899089d745721a0f34",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33783",
"triggerID" : "42c8b7d3793c949b54aba0899089d745721a0f34",
"triggerType" : "PUSH"
}, {
"hash" : "46c05b37929a49451a6a7c029ba75366b30b7aef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33813",
"triggerID" : "46c05b37929a49451a6a7c029ba75366b30b7aef",
"triggerType" : "PUSH"
}, {
"hash" : "7c18a73b0a5e082593c9d87e94527a177791d5ba",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33900",
"triggerID" : "7c18a73b0a5e082593c9d87e94527a177791d5ba",
"triggerType" : "PUSH"
}, {
"hash" : "19917b9ec232b1732889e7923f77901d9139df34",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33914",
"triggerID" : "19917b9ec232b1732889e7923f77901d9139df34",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "1082134441",
"triggerType" : "MANUAL"
}, {
"hash" : "8904cf64426dc053a2636b0e9567deb7550eb931",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8904cf64426dc053a2636b0e9567deb7550eb931",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* Unknown: [CANCELED](TBD)
* 8904cf64426dc053a2636b0e9567deb7550eb931 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19249: [FLINK-26092][table-runtime] Fix `JSON_OBJECTAGG` when emitting `NULL`
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19249:
URL: https://github.com/apache/flink/pull/19249#issuecomment-1079884730
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "42c8b7d3793c949b54aba0899089d745721a0f34",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33783",
"triggerID" : "42c8b7d3793c949b54aba0899089d745721a0f34",
"triggerType" : "PUSH"
}, {
"hash" : "46c05b37929a49451a6a7c029ba75366b30b7aef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33813",
"triggerID" : "46c05b37929a49451a6a7c029ba75366b30b7aef",
"triggerType" : "PUSH"
}, {
"hash" : "7c18a73b0a5e082593c9d87e94527a177791d5ba",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33900",
"triggerID" : "7c18a73b0a5e082593c9d87e94527a177791d5ba",
"triggerType" : "PUSH"
}, {
"hash" : "19917b9ec232b1732889e7923f77901d9139df34",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33914",
"triggerID" : "19917b9ec232b1732889e7923f77901d9139df34",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "1082134441",
"triggerType" : "MANUAL"
}, {
"hash" : "8904cf64426dc053a2636b0e9567deb7550eb931",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8904cf64426dc053a2636b0e9567deb7550eb931",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* Unknown: [CANCELED](TBD)
* 8904cf64426dc053a2636b0e9567deb7550eb931 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] matriv commented on pull request #19249: [FLINK-26092][table-runtime] Fix `JSON_OBJECTAGG` when emitting `NULL`
Posted by GitBox <gi...@apache.org>.
matriv commented on pull request #19249:
URL: https://github.com/apache/flink/pull/19249#issuecomment-1082134441
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rkhachatryan commented on pull request #19249: [FLINK-26092][table-runtime] Fix `JSON_OBJECTAGG` when emitting `NULL`
Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on pull request #19249:
URL: https://github.com/apache/flink/pull/19249#issuecomment-1082412095
The test failure is likely unrelated:
```
Mar 29 18:37:08 [ERROR] pure virtual method called
Mar 29 18:37:08 [ERROR] terminate called without an active exception
Mar 29 18:37:12 [ERROR] Aborted (core dumped)
```
The private branch [passed](https://dev.azure.com/matriv/Flink/_build/results?buildId=464&view=results) the tests. Merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19249: [FLINK-26092][table-runtime] Fix `JSON_OBJECTAGG` when emitting `NULL`
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19249:
URL: https://github.com/apache/flink/pull/19249#issuecomment-1079884730
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "42c8b7d3793c949b54aba0899089d745721a0f34",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33783",
"triggerID" : "42c8b7d3793c949b54aba0899089d745721a0f34",
"triggerType" : "PUSH"
}, {
"hash" : "46c05b37929a49451a6a7c029ba75366b30b7aef",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33813",
"triggerID" : "46c05b37929a49451a6a7c029ba75366b30b7aef",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 42c8b7d3793c949b54aba0899089d745721a0f34 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33783)
* 46c05b37929a49451a6a7c029ba75366b30b7aef Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33813)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19249: [FLINK-26092][table-runtime] Fix `JSON_OBJECTAGG` when emitting `NULL`
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19249:
URL: https://github.com/apache/flink/pull/19249#issuecomment-1079884730
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "42c8b7d3793c949b54aba0899089d745721a0f34",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33783",
"triggerID" : "42c8b7d3793c949b54aba0899089d745721a0f34",
"triggerType" : "PUSH"
}, {
"hash" : "46c05b37929a49451a6a7c029ba75366b30b7aef",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33813",
"triggerID" : "46c05b37929a49451a6a7c029ba75366b30b7aef",
"triggerType" : "PUSH"
}, {
"hash" : "7c18a73b0a5e082593c9d87e94527a177791d5ba",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33900",
"triggerID" : "7c18a73b0a5e082593c9d87e94527a177791d5ba",
"triggerType" : "PUSH"
}, {
"hash" : "19917b9ec232b1732889e7923f77901d9139df34",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "19917b9ec232b1732889e7923f77901d9139df34",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 46c05b37929a49451a6a7c029ba75366b30b7aef Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33813)
* 7c18a73b0a5e082593c9d87e94527a177791d5ba Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33900)
* 19917b9ec232b1732889e7923f77901d9139df34 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19249: [FLINK-26092][table-runtime] Fix `JSON_OBJECTAGG` when emitting `NULL`
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19249:
URL: https://github.com/apache/flink/pull/19249#issuecomment-1079884730
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "42c8b7d3793c949b54aba0899089d745721a0f34",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33783",
"triggerID" : "42c8b7d3793c949b54aba0899089d745721a0f34",
"triggerType" : "PUSH"
}, {
"hash" : "46c05b37929a49451a6a7c029ba75366b30b7aef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33813",
"triggerID" : "46c05b37929a49451a6a7c029ba75366b30b7aef",
"triggerType" : "PUSH"
}, {
"hash" : "7c18a73b0a5e082593c9d87e94527a177791d5ba",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33900",
"triggerID" : "7c18a73b0a5e082593c9d87e94527a177791d5ba",
"triggerType" : "PUSH"
}, {
"hash" : "19917b9ec232b1732889e7923f77901d9139df34",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33914",
"triggerID" : "19917b9ec232b1732889e7923f77901d9139df34",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "1082134441",
"triggerType" : "MANUAL"
}, {
"hash" : "8904cf64426dc053a2636b0e9567deb7550eb931",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33920",
"triggerID" : "8904cf64426dc053a2636b0e9567deb7550eb931",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* Unknown: [CANCELED](TBD)
* 8904cf64426dc053a2636b0e9567deb7550eb931 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33920)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] matriv commented on a change in pull request #19249: [FLINK-26092][table-runtime] Fix `JSON_OBJECTAGG` when emitting `NULL`
Posted by GitBox <gi...@apache.org>.
matriv commented on a change in pull request #19249:
URL: https://github.com/apache/flink/pull/19249#discussion_r837673114
##########
File path: flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/BuiltInAggregateFunctionTestBase.java
##########
@@ -204,25 +205,39 @@ TestSpec testResult(
return this;
}
- private Executable createTestItemExecutable(TestItem testItem) {
+ private Executable createTestItemExecutable(
+ TestItem testItem, boolean stateBackendChangelogEnabled) {
return () -> {
+ Configuration conf = new Configuration();
+ conf.set(
+ StateChangelogOptions.ENABLE_STATE_CHANGE_LOG,
+ stateBackendChangelogEnabled);
Review comment:
Thank you!, pushed the change.
Indeed without the fix, when `rocksdb` is used it fails with NPE during `StringData` serialization.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19249: [FLINK-26092][table-runtime] Fix `JSON_OBJECTAGG` when emitting `NULL`
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19249:
URL: https://github.com/apache/flink/pull/19249#issuecomment-1079884730
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "42c8b7d3793c949b54aba0899089d745721a0f34",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33783",
"triggerID" : "42c8b7d3793c949b54aba0899089d745721a0f34",
"triggerType" : "PUSH"
}, {
"hash" : "46c05b37929a49451a6a7c029ba75366b30b7aef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33813",
"triggerID" : "46c05b37929a49451a6a7c029ba75366b30b7aef",
"triggerType" : "PUSH"
}, {
"hash" : "7c18a73b0a5e082593c9d87e94527a177791d5ba",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33900",
"triggerID" : "7c18a73b0a5e082593c9d87e94527a177791d5ba",
"triggerType" : "PUSH"
}, {
"hash" : "19917b9ec232b1732889e7923f77901d9139df34",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33914",
"triggerID" : "19917b9ec232b1732889e7923f77901d9139df34",
"triggerType" : "PUSH"
}, {
"hash" : "8904cf64426dc053a2636b0e9567deb7550eb931",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1082134441",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "1082134441",
"triggerType" : "MANUAL"
}, {
"hash" : "8904cf64426dc053a2636b0e9567deb7550eb931",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8904cf64426dc053a2636b0e9567deb7550eb931",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* Unknown: [CANCELED](TBD)
* 8904cf64426dc053a2636b0e9567deb7550eb931 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19249: [FLINK-26092][table-runtime] Fix `JSON_OBJECTAGG` when emitting `NULL`
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19249:
URL: https://github.com/apache/flink/pull/19249#issuecomment-1079884730
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "42c8b7d3793c949b54aba0899089d745721a0f34",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33783",
"triggerID" : "42c8b7d3793c949b54aba0899089d745721a0f34",
"triggerType" : "PUSH"
}, {
"hash" : "46c05b37929a49451a6a7c029ba75366b30b7aef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33813",
"triggerID" : "46c05b37929a49451a6a7c029ba75366b30b7aef",
"triggerType" : "PUSH"
}, {
"hash" : "7c18a73b0a5e082593c9d87e94527a177791d5ba",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33900",
"triggerID" : "7c18a73b0a5e082593c9d87e94527a177791d5ba",
"triggerType" : "PUSH"
}, {
"hash" : "19917b9ec232b1732889e7923f77901d9139df34",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33914",
"triggerID" : "19917b9ec232b1732889e7923f77901d9139df34",
"triggerType" : "PUSH"
}, {
"hash" : "8904cf64426dc053a2636b0e9567deb7550eb931",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33920",
"triggerID" : "8904cf64426dc053a2636b0e9567deb7550eb931",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1082134441",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 8904cf64426dc053a2636b0e9567deb7550eb931 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33920)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rkhachatryan merged pull request #19249: [FLINK-26092][table-runtime] Fix `JSON_OBJECTAGG` when emitting `NULL`
Posted by GitBox <gi...@apache.org>.
rkhachatryan merged pull request #19249:
URL: https://github.com/apache/flink/pull/19249
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19249: [FLINK-26092][table-runtime] Fix `JSON_OBJECTAGG` when emitting `NULL`
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19249:
URL: https://github.com/apache/flink/pull/19249#issuecomment-1079884730
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "42c8b7d3793c949b54aba0899089d745721a0f34",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33783",
"triggerID" : "42c8b7d3793c949b54aba0899089d745721a0f34",
"triggerType" : "PUSH"
}, {
"hash" : "46c05b37929a49451a6a7c029ba75366b30b7aef",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33813",
"triggerID" : "46c05b37929a49451a6a7c029ba75366b30b7aef",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 46c05b37929a49451a6a7c029ba75366b30b7aef Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33813)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rkhachatryan commented on a change in pull request #19249: [FLINK-26092][table-runtime] Fix `JSON_OBJECTAGG` when emitting `NULL`
Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on a change in pull request #19249:
URL: https://github.com/apache/flink/pull/19249#discussion_r837632461
##########
File path: flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/BuiltInAggregateFunctionTestBase.java
##########
@@ -204,25 +205,39 @@ TestSpec testResult(
return this;
}
- private Executable createTestItemExecutable(TestItem testItem) {
+ private Executable createTestItemExecutable(
+ TestItem testItem, boolean stateBackendChangelogEnabled) {
return () -> {
+ Configuration conf = new Configuration();
+ conf.set(
+ StateChangelogOptions.ENABLE_STATE_CHANGE_LOG,
+ stateBackendChangelogEnabled);
Review comment:
The changelog is enabled randomly from `flink/pom.xml` unless explicitly disabled (currently, it **is** disabled for this test). So there is no need to enable it explicitly.
Instead, it probably makes sense to parameterize the test with the type of backend (currently it uses HEAP, but would fail with ROCKSDB), ideally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19249: [FLINK-26092][table-runtime] Fix `JSON_OBJECTAGG` when emitting `NULL`
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19249:
URL: https://github.com/apache/flink/pull/19249#issuecomment-1079884730
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "42c8b7d3793c949b54aba0899089d745721a0f34",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33783",
"triggerID" : "42c8b7d3793c949b54aba0899089d745721a0f34",
"triggerType" : "PUSH"
}, {
"hash" : "46c05b37929a49451a6a7c029ba75366b30b7aef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33813",
"triggerID" : "46c05b37929a49451a6a7c029ba75366b30b7aef",
"triggerType" : "PUSH"
}, {
"hash" : "7c18a73b0a5e082593c9d87e94527a177791d5ba",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33900",
"triggerID" : "7c18a73b0a5e082593c9d87e94527a177791d5ba",
"triggerType" : "PUSH"
}, {
"hash" : "19917b9ec232b1732889e7923f77901d9139df34",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33914",
"triggerID" : "19917b9ec232b1732889e7923f77901d9139df34",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "1082134441",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* Unknown: [CANCELED](TBD)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19249: [FLINK-26092][table-runtime] Fix `JSON_OBJECTAGG` when emitting `NULL`
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19249:
URL: https://github.com/apache/flink/pull/19249#issuecomment-1079884730
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "42c8b7d3793c949b54aba0899089d745721a0f34",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33783",
"triggerID" : "42c8b7d3793c949b54aba0899089d745721a0f34",
"triggerType" : "PUSH"
}, {
"hash" : "46c05b37929a49451a6a7c029ba75366b30b7aef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33813",
"triggerID" : "46c05b37929a49451a6a7c029ba75366b30b7aef",
"triggerType" : "PUSH"
}, {
"hash" : "7c18a73b0a5e082593c9d87e94527a177791d5ba",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33900",
"triggerID" : "7c18a73b0a5e082593c9d87e94527a177791d5ba",
"triggerType" : "PUSH"
}, {
"hash" : "19917b9ec232b1732889e7923f77901d9139df34",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33914",
"triggerID" : "19917b9ec232b1732889e7923f77901d9139df34",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 19917b9ec232b1732889e7923f77901d9139df34 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33914)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19249: [FLINK-26092][table-runtime] Fix `JSON_OBJECTAGG` when emitting `NULL`
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19249:
URL: https://github.com/apache/flink/pull/19249#issuecomment-1079884730
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "42c8b7d3793c949b54aba0899089d745721a0f34",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33783",
"triggerID" : "42c8b7d3793c949b54aba0899089d745721a0f34",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 42c8b7d3793c949b54aba0899089d745721a0f34 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33783)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19249: [FLINK-26092][table-runtime] Fix `JSON_OBJECTAGG` when emitting `NULL`
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19249:
URL: https://github.com/apache/flink/pull/19249#issuecomment-1079884730
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "42c8b7d3793c949b54aba0899089d745721a0f34",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33783",
"triggerID" : "42c8b7d3793c949b54aba0899089d745721a0f34",
"triggerType" : "PUSH"
}, {
"hash" : "46c05b37929a49451a6a7c029ba75366b30b7aef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33813",
"triggerID" : "46c05b37929a49451a6a7c029ba75366b30b7aef",
"triggerType" : "PUSH"
}, {
"hash" : "7c18a73b0a5e082593c9d87e94527a177791d5ba",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33900",
"triggerID" : "7c18a73b0a5e082593c9d87e94527a177791d5ba",
"triggerType" : "PUSH"
}, {
"hash" : "19917b9ec232b1732889e7923f77901d9139df34",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33914",
"triggerID" : "19917b9ec232b1732889e7923f77901d9139df34",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7c18a73b0a5e082593c9d87e94527a177791d5ba Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33900)
* 19917b9ec232b1732889e7923f77901d9139df34 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33914)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rkhachatryan commented on a change in pull request #19249: [FLINK-26092][table-runtime] Fix `JSON_OBJECTAGG` when emitting `NULL`
Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on a change in pull request #19249:
URL: https://github.com/apache/flink/pull/19249#discussion_r837686216
##########
File path: flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/BuiltInAggregateFunctionTestBase.java
##########
@@ -204,25 +205,39 @@ TestSpec testResult(
return this;
}
- private Executable createTestItemExecutable(TestItem testItem) {
+ private Executable createTestItemExecutable(
+ TestItem testItem, boolean stateBackendChangelogEnabled) {
return () -> {
+ Configuration conf = new Configuration();
+ conf.set(
+ StateChangelogOptions.ENABLE_STATE_CHANGE_LOG,
+ stateBackendChangelogEnabled);
Review comment:
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19249: [FLINK-26092][table-runtime] Fix `JSON_OBJECTAGG` when emitting `NULL`
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19249:
URL: https://github.com/apache/flink/pull/19249#issuecomment-1079884730
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "42c8b7d3793c949b54aba0899089d745721a0f34",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33783",
"triggerID" : "42c8b7d3793c949b54aba0899089d745721a0f34",
"triggerType" : "PUSH"
}, {
"hash" : "46c05b37929a49451a6a7c029ba75366b30b7aef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33813",
"triggerID" : "46c05b37929a49451a6a7c029ba75366b30b7aef",
"triggerType" : "PUSH"
}, {
"hash" : "7c18a73b0a5e082593c9d87e94527a177791d5ba",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33900",
"triggerID" : "7c18a73b0a5e082593c9d87e94527a177791d5ba",
"triggerType" : "PUSH"
}, {
"hash" : "19917b9ec232b1732889e7923f77901d9139df34",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33914",
"triggerID" : "19917b9ec232b1732889e7923f77901d9139df34",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "1082134441",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* Unknown: [CANCELED](TBD)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19249: [FLINK-26092][table-runtime] Fix `JSON_OBJECTAGG` when emitting `NULL`
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19249:
URL: https://github.com/apache/flink/pull/19249#issuecomment-1079884730
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "42c8b7d3793c949b54aba0899089d745721a0f34",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33783",
"triggerID" : "42c8b7d3793c949b54aba0899089d745721a0f34",
"triggerType" : "PUSH"
}, {
"hash" : "46c05b37929a49451a6a7c029ba75366b30b7aef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33813",
"triggerID" : "46c05b37929a49451a6a7c029ba75366b30b7aef",
"triggerType" : "PUSH"
}, {
"hash" : "7c18a73b0a5e082593c9d87e94527a177791d5ba",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33900",
"triggerID" : "7c18a73b0a5e082593c9d87e94527a177791d5ba",
"triggerType" : "PUSH"
}, {
"hash" : "19917b9ec232b1732889e7923f77901d9139df34",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33914",
"triggerID" : "19917b9ec232b1732889e7923f77901d9139df34",
"triggerType" : "PUSH"
}, {
"hash" : "8904cf64426dc053a2636b0e9567deb7550eb931",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8904cf64426dc053a2636b0e9567deb7550eb931",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7c18a73b0a5e082593c9d87e94527a177791d5ba Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33900)
* 19917b9ec232b1732889e7923f77901d9139df34 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33914)
* 8904cf64426dc053a2636b0e9567deb7550eb931 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19249: [FLINK-26092][table-runtime] Fix `JSON_OBJECTAGG` when emitting `NULL`
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19249:
URL: https://github.com/apache/flink/pull/19249#issuecomment-1079884730
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "42c8b7d3793c949b54aba0899089d745721a0f34",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33783",
"triggerID" : "42c8b7d3793c949b54aba0899089d745721a0f34",
"triggerType" : "PUSH"
}, {
"hash" : "46c05b37929a49451a6a7c029ba75366b30b7aef",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33813",
"triggerID" : "46c05b37929a49451a6a7c029ba75366b30b7aef",
"triggerType" : "PUSH"
}, {
"hash" : "7c18a73b0a5e082593c9d87e94527a177791d5ba",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33900",
"triggerID" : "7c18a73b0a5e082593c9d87e94527a177791d5ba",
"triggerType" : "PUSH"
}, {
"hash" : "19917b9ec232b1732889e7923f77901d9139df34",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33914",
"triggerID" : "19917b9ec232b1732889e7923f77901d9139df34",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "1082134441",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* Unknown: [CANCELED](TBD)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org