[jira] [Work logged] (ARTEMIS-3964) Windows ping IPv4/6 commands have wrong time unit

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/ARTEMIS-3964?focusedWorklogId=805107&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-805107 ]

ASF GitHub Bot logged work on ARTEMIS-3964:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 31/Aug/22 06:48
            Start Date: 31/Aug/22 06:48
    Worklog Time Spent: 10m 
      Work Description: brusdev opened a new pull request, #4199:
URL: https://github.com/apache/activemq-artemis/pull/4199

   The ping command on Windows uses -w timeout in milliseconds.




Issue Time Tracking
-------------------

            Worklog Id:     (was: 805107)
    Remaining Estimate: 0h
            Time Spent: 10m

> Windows ping IPv4/6 commands have wrong time unit
> -------------------------------------------------
>
>                 Key: ARTEMIS-3964
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-3964
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>            Reporter: Domenico Francesco Bruscino
>            Assignee: Domenico Francesco Bruscino
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> The ping command on Windows uses
> -w timeout Timeout in milliseconds to wait for each reply. while in code is used seconds.
> {code:java}
> String IPV6_DEFAULT_COMMAND = Env.isWindowsOs() ? "ping -n 1 -w %d %s" : 
> ....
> // default int networkTimeout = 1000;
>  long timeout = Math.max(1, TimeUnit.MILLISECONDS.toSeconds(networkTimeout));
> ...
> processBuilder = buildProcess(ipv6Command, timeout, address.getCanonicalHostName()
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)