You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by zhangminglei <gi...@git.apache.org> on 2018/04/16 08:28:31 UTC

[GitHub] flink pull request #5851: [FLINK-9176] [build] Re-introduce category to sure...

GitHub user zhangminglei opened a pull request:

    https://github.com/apache/flink/pull/5851

    [FLINK-9176] [build] Re-introduce category to surefire configuration

     ## What is the purpose of the change
    
    The LegacyAndNew and New annotations, that were previously used to disable tests based on whether the legacyCode profile is active, are effectively unused. So, I re-introduce category to surefire configuration to make them work.
    
    ## Brief change log
    Update parent pom.xml file.
    
    ## Verifying this change
    This change is a trivial rework / code cleanup without any test coverage.
    
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (yes)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
      - The S3 file system connector: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (not documented)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zhangminglei/flink flink-9176-lei

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5851.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5851
    
----
commit 1a053ea7c3511cd97a41681cc4d77f1e11145b93
Author: zhangminglei <zm...@...>
Date:   2018-04-16T08:22:34Z

    [FLINK-9176] [build] Re-introduce category to surefire configuration

----


---

[GitHub] flink issue #5851: [FLINK-9176] [build] Re-introduce category to surefire co...

Posted by zhangminglei <gi...@git.apache.org>.
Github user zhangminglei commented on the issue:

    https://github.com/apache/flink/pull/5851
  
    @zentol Could you also review this ? Thanks.


---

[GitHub] flink pull request #5851: [FLINK-9176] [build] Re-introduce category to sure...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/5851


---