You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "paul-rogers (via GitHub)" <gi...@apache.org> on 2023/03/20 21:27:02 UTC
[GitHub] [druid] paul-rogers opened a new pull request, #13954: Fix typos, add tests for http() function
paul-rogers opened a new pull request, #13954:
URL: https://github.com/apache/druid/pull/13954
Fixes some URL typos and add a few more variations for the `http()` table function tests.
It turns out that the Calcite tests make use of the `toString()` functions to convert a native query to a string for comparison. The `HttpInputSource` is missing the `toString()` function and so generated a unique string for each object, which causes comparisons to fail. This PR also fixes a few of these nit issues.
#### Release note
No user-visible changes.
<hr>
This PR has:
- [X] been self-reviewed.
- [X] a release note entry in the PR description.
- [X] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] paul-rogers commented on pull request #13954: Fix typos, add tests for http() function
Posted by "paul-rogers (via GitHub)" <gi...@apache.org>.
paul-rogers commented on PR #13954:
URL: https://github.com/apache/druid/pull/13954#issuecomment-1483216844
This PR (and others) are failing due to a Kafka IT. The code here cannot have affected that ID. So, progress on this PR is stalled until someone sorts out the Kafka issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] paul-rogers merged pull request #13954: Fix typos, add tests for http() function
Posted by "paul-rogers (via GitHub)" <gi...@apache.org>.
paul-rogers merged PR #13954:
URL: https://github.com/apache/druid/pull/13954
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org