[GitHub] [superset] simchaNielsen commented on a change in pull request #12662: feat(cross-filters): add cross filters

[GitBox <gi...@apache.org>]

simchaNielsen commented on a change in pull request #12662:
URL: https://github.com/apache/superset/pull/12662#discussion_r563775241



##########
File path: superset-frontend/src/explore/components/controls/VizTypeControl.jsx
##########
@@ -166,15 +167,23 @@ const VizTypeControl = props => {
   const filterString = filter.toLowerCase();
 
   const filteredTypes = DEFAULT_ORDER.filter(type => registry.has(type))
-    .filter(type => !registry.get(type).isNativeFilter)
+    .filter(
+      type =>
+        isFeatureEnabled(FeatureFlag.DASHBOARD_CROSS_FILTERS) ||

Review comment:
       @agatapst `FeatureFlag.DASHBOARD_NATIVE_FILTERS` feature flag filter out native filter charts from the view that responsible for creation of charts, because if they will be created as charts they will not can filter other charts, but with new feature of cross-filter functionality they will can to do it, so no need any more filter out them from this view.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org