You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/10/31 20:36:25 UTC
[GitHub] [arrow-datafusion] tustvold opened a new pull request, #4048: Fix multicolumn parquet predicate pushdown (#4046)
tustvold opened a new pull request, #4048:
URL: https://github.com/apache/arrow-datafusion/pull/4048
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #4046
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
The first incarnation of this in #4021 computed the mapping from the projected schema to the file schema and not the other way round. For the case of two columns these are always the same thing and so it worked for the two column case, but more columns requires additional shenanigans.
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #4048: Fix multicolumn parquet predicate pushdown (#4046)
Posted by GitBox <gi...@apache.org>.
alamb commented on code in PR #4048:
URL: https://github.com/apache/arrow-datafusion/pull/4048#discussion_r1010385914
##########
datafusion/core/src/physical_plan/file_format/row_filter.rs:
##########
@@ -278,6 +274,32 @@ impl<'a> ExprRewriter for FilterCandidateBuilder<'a> {
}
}
+/// Computes the projection required to go from the file's schema order to the projected
Review Comment:
Thank you for these comments
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] ursabot commented on pull request #4048: Fix multicolumn parquet predicate pushdown (#4046)
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #4048:
URL: https://github.com/apache/arrow-datafusion/pull/4048#issuecomment-1298475451
Benchmark runs are scheduled for baseline = c92a38fe5b2a17b8f9a1cd29d181b99793bd26fc and contender = ea31da9ab1c7e5ba9627b799e3a57657f38caf53. ea31da9ab1c7e5ba9627b799e3a57657f38caf53 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/e9e4cf8acdab46a1aafbdfc190805c77...853982cddd8447ec9068a09db0e6eeeb/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/a9e27781a72041b1b971a9b61928cc84...a8b9d813ba7447d3b47be68c5806b73a/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/cd06a652a0eb462eaa32b7d9958d2d1a...061dea773c90400684228483a3001b86/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/05b5d8c6a5bf45d3a998a504f50e6b7d...f724cdeb8a484b6d8835fee7cd813395/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #4048: Fix multicolumn parquet predicate pushdown (#4046)
Posted by GitBox <gi...@apache.org>.
alamb commented on PR #4048:
URL: https://github.com/apache/arrow-datafusion/pull/4048#issuecomment-1298465841
I verified this fixes the issue in my test harness in https://github.com/apache/arrow-datafusion/pull/3976 -- given this is a non controversial bug fix I am merging it in now to keep that project chugging along
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #4048: Fix multicolumn parquet predicate pushdown (#4046)
Posted by GitBox <gi...@apache.org>.
alamb merged PR #4048:
URL: https://github.com/apache/arrow-datafusion/pull/4048
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org