You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@struts.apache.org by "Richard Harding (JIRA)" <ji...@apache.org> on 2006/10/10 11:50:15 UTC
[jira] Created: (STR-2959) File upload has 2GB limit
File upload has 2GB limit
-------------------------
Key: STR-2959
URL: http://issues.apache.org/struts/browse/STR-2959
Project: Struts 1
Issue Type: Bug
Components: Core
Affects Versions: 1.3.5, 1.2.9, 1.2.8, 1.2.7
Environment: Websphere Application Server 6.0
Reporter: Richard Harding
Priority: Minor
Struts currently has a 2GB limit on file upload.
org.apache.struts.upload has an artificial limit of 2GB.
org.apache.commons.fileupload does not have this limit since 'long' is used in place of 'int'
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (STR-2959) File upload has 2GB limit
Posted by "Paul Benedict (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/STR-2959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul Benedict resolved STR-2959.
--------------------------------
Resolution: Fixed
Firefox has a 2GB - 1 limit like IE so this cannot be tested. However, the FormFile interface signature is now ready for this feature. Based on committer feedback, here's what has changed:
1) Binary compatibility has been preserved.
2) fileSize property methods have been deprecated but still function. If the actual file size is larger than an int, an IllegalStateException is thrown.
3) New fileLength property that return a long.
The word "length" was chosen to fit into common nomenclature: File.length, ServletRequest.getContentLength, etc.
> File upload has 2GB limit
> -------------------------
>
> Key: STR-2959
> URL: https://issues.apache.org/struts/browse/STR-2959
> Project: Struts 1
> Issue Type: Bug
> Components: Core
> Affects Versions: 1.2.7, 1.2.8, 1.2.9, 1.3.5
> Environment: Websphere Application Server 6.0
> Reporter: Richard Harding
> Assignee: Paul Benedict
> Priority: Minor
> Fix For: 1.4.0
>
>
> Struts currently has a 2GB limit on file upload.
> org.apache.struts.upload has an artificial limit of 2GB.
> org.apache.commons.fileupload does not have this limit since 'long' is used in place of 'int'
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (STR-2959) File upload has 2GB limit
Posted by "Paul Benedict (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/STR-2959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_41264 ]
Paul Benedict commented on STR-2959:
------------------------------------
If there is going to be an overhaul, I'd still like the current uploading interface to be fixed. If you find no real difference between changing the signature vs. adding method, I will prefer the former.
> File upload has 2GB limit
> -------------------------
>
> Key: STR-2959
> URL: https://issues.apache.org/struts/browse/STR-2959
> Project: Struts 1
> Issue Type: Bug
> Components: Core
> Affects Versions: 1.2.7, 1.2.8, 1.2.9, 1.3.5
> Environment: Websphere Application Server 6.0
> Reporter: Richard Harding
> Priority: Minor
> Fix For: 1.4.0
>
>
> Struts currently has a 2GB limit on file upload.
> org.apache.struts.upload has an artificial limit of 2GB.
> org.apache.commons.fileupload does not have this limit since 'long' is used in place of 'int'
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (STR-2959) File upload has 2GB limit
Posted by "Peter Fassev (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/STR-2959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_41285 ]
Peter Fassev commented on STR-2959:
-----------------------------------
Just a side note: Currently there is no browser which supports more than 4 GByte upload or download. The Internet Explorer for instance has a 2 GB Limitation. If you try to upload more the 2 GB, the IE will silently upload only the part of the last 2 GB without any comment or error notification. And you can not check with java script what the use has selected.
Firefox may upload or download up to 4 GB, but only when the Server does not keep alive. If you try to upload more then 4 GB, Firefox does refuses to send the form. But there is no message why, actually there is no message at all.
So someone has to use some other client but not a browser to send and receive such big files. But files up to 2 GBytes are OK.
Regards
Peter
> File upload has 2GB limit
> -------------------------
>
> Key: STR-2959
> URL: https://issues.apache.org/struts/browse/STR-2959
> Project: Struts 1
> Issue Type: Bug
> Components: Core
> Affects Versions: 1.2.7, 1.2.8, 1.2.9, 1.3.5
> Environment: Websphere Application Server 6.0
> Reporter: Richard Harding
> Assignee: Paul Benedict
> Priority: Minor
> Fix For: 1.4.0
>
>
> Struts currently has a 2GB limit on file upload.
> org.apache.struts.upload has an artificial limit of 2GB.
> org.apache.commons.fileupload does not have this limit since 'long' is used in place of 'int'
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (STR-2959) File upload has 2GB limit
Posted by "Paul Benedict (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/STR-2959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_41353 ]
Paul Benedict commented on STR-2959:
------------------------------------
In the debugger, if I dynamically increase the size limit of DiskFileUpload, everything works fine.
> File upload has 2GB limit
> -------------------------
>
> Key: STR-2959
> URL: https://issues.apache.org/struts/browse/STR-2959
> Project: Struts 1
> Issue Type: Bug
> Components: Core
> Affects Versions: 1.2.7, 1.2.8, 1.2.9, 1.3.5
> Environment: Websphere Application Server 6.0
> Reporter: Richard Harding
> Assignee: Paul Benedict
> Priority: Minor
> Fix For: 1.4.0
>
>
> Struts currently has a 2GB limit on file upload.
> org.apache.struts.upload has an artificial limit of 2GB.
> org.apache.commons.fileupload does not have this limit since 'long' is used in place of 'int'
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (STR-2959) File upload has 2GB limit
Posted by "Richard Harding (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/STR-2959?page=comments#action_38917 ]
Richard Harding commented on STR-2959:
--------------------------------------
Not being able to get the file size is the issue I am referring to. I am unable to confirm that struts.upload can infact deal with a larger file whilst not being able to find the size of the file.
org.apache.struts.upload simply wraps org.apache.commons.fileupload but changes the signature of the getFileSize() method to return an int. Which, as Paul mentions, has an upper limit of about 2GB. A long however, as used by the commons.fileupload does not have this limit.
> File upload has 2GB limit
> -------------------------
>
> Key: STR-2959
> URL: http://issues.apache.org/struts/browse/STR-2959
> Project: Struts 1
> Issue Type: Bug
> Components: Core
> Affects Versions: 1.3.5, 1.2.9, 1.2.8, 1.2.7
> Environment: Websphere Application Server 6.0
> Reporter: Richard Harding
> Priority: Minor
>
> Struts currently has a 2GB limit on file upload.
> org.apache.struts.upload has an artificial limit of 2GB.
> org.apache.commons.fileupload does not have this limit since 'long' is used in place of 'int'
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (STR-2959) File upload has 2GB limit
Posted by "Paul Benedict (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/STR-2959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_41360 ]
Paul Benedict commented on STR-2959:
------------------------------------
This issue also relates to https://issues.apache.org/jira/browse/FILEUPLOAD-102
> File upload has 2GB limit
> -------------------------
>
> Key: STR-2959
> URL: https://issues.apache.org/struts/browse/STR-2959
> Project: Struts 1
> Issue Type: Bug
> Components: Core
> Affects Versions: 1.2.7, 1.2.8, 1.2.9, 1.3.5
> Environment: Websphere Application Server 6.0
> Reporter: Richard Harding
> Assignee: Paul Benedict
> Priority: Minor
> Fix For: 1.4.0
>
>
> Struts currently has a 2GB limit on file upload.
> org.apache.struts.upload has an artificial limit of 2GB.
> org.apache.commons.fileupload does not have this limit since 'long' is used in place of 'int'
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (STR-2959) File upload has 2GB limit
Posted by "Paul Benedict (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/STR-2959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul Benedict updated STR-2959:
-------------------------------
Comment: was deleted
> File upload has 2GB limit
> -------------------------
>
> Key: STR-2959
> URL: https://issues.apache.org/struts/browse/STR-2959
> Project: Struts 1
> Issue Type: Bug
> Components: Core
> Affects Versions: 1.2.7, 1.2.8, 1.2.9, 1.3.5
> Environment: Websphere Application Server 6.0
> Reporter: Richard Harding
> Assignee: Paul Benedict
> Priority: Minor
> Fix For: 1.4.0
>
>
> Struts currently has a 2GB limit on file upload.
> org.apache.struts.upload has an artificial limit of 2GB.
> org.apache.commons.fileupload does not have this limit since 'long' is used in place of 'int'
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (STR-2959) File upload has 2GB limit
Posted by "Paul Benedict (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/STR-2959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_40141 ]
Paul Benedict commented on STR-2959:
------------------------------------
Henri, want to lead the way? The problem is resides in Jakarta Commons.
> File upload has 2GB limit
> -------------------------
>
> Key: STR-2959
> URL: https://issues.apache.org/struts/browse/STR-2959
> Project: Struts 1
> Issue Type: Bug
> Components: Core
> Affects Versions: 1.2.7, 1.2.8, 1.2.9, 1.3.5
> Environment: Websphere Application Server 6.0
> Reporter: Richard Harding
> Priority: Minor
> Fix For: 1.4.0
>
>
> Struts currently has a 2GB limit on file upload.
> org.apache.struts.upload has an artificial limit of 2GB.
> org.apache.commons.fileupload does not have this limit since 'long' is used in place of 'int'
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (STR-2959) File upload has 2GB limit
Posted by "Paul Benedict (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/STR-2959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_41283 ]
Paul Benedict commented on STR-2959:
------------------------------------
After some more discussion with Niall, this approach was amicable to the both of us:
1) Deprecate the first method
2) Add second method that returns a long
3) Delegate the first to the second
4) Throw IllegalStateException if first method finds a file bigger than 2GB
> File upload has 2GB limit
> -------------------------
>
> Key: STR-2959
> URL: https://issues.apache.org/struts/browse/STR-2959
> Project: Struts 1
> Issue Type: Bug
> Components: Core
> Affects Versions: 1.2.7, 1.2.8, 1.2.9, 1.3.5
> Environment: Websphere Application Server 6.0
> Reporter: Richard Harding
> Assignee: Paul Benedict
> Priority: Minor
> Fix For: 1.4.0
>
>
> Struts currently has a 2GB limit on file upload.
> org.apache.struts.upload has an artificial limit of 2GB.
> org.apache.commons.fileupload does not have this limit since 'long' is used in place of 'int'
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (STR-2959) File upload has 2GB limit
Posted by "Paul Benedict (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/STR-2959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_41247 ]
Paul Benedict commented on STR-2959:
------------------------------------
I forgot about deprecation. Good point, Niall.
> File upload has 2GB limit
> -------------------------
>
> Key: STR-2959
> URL: https://issues.apache.org/struts/browse/STR-2959
> Project: Struts 1
> Issue Type: Bug
> Components: Core
> Affects Versions: 1.2.7, 1.2.8, 1.2.9, 1.3.5
> Environment: Websphere Application Server 6.0
> Reporter: Richard Harding
> Priority: Minor
> Fix For: 1.4.0
>
>
> Struts currently has a 2GB limit on file upload.
> org.apache.struts.upload has an artificial limit of 2GB.
> org.apache.commons.fileupload does not have this limit since 'long' is used in place of 'int'
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (STR-2959) File upload has 2GB limit
Posted by "Niall Pemberton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/STR-2959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_41276 ]
Niall Pemberton commented on STR-2959:
--------------------------------------
Actually this is a mis-representation of my view - I qualifed the "no real difference" with "for anyone implementing the FormFile interface" - but as I also said I think the majority use the default implementation. If I'm right about that then this solution breaks compatibility for the majority (if they use getFileSize) - as well as the few that implement FormFile themselves - rather than just the few.
The real issue is whether we should break compatibility with Struts 1.3 though - it makes me uneasy and I haven't yet decided how I would vote on a release containing this change. Would be good to hear other opinions on whether its OK or not.
> File upload has 2GB limit
> -------------------------
>
> Key: STR-2959
> URL: https://issues.apache.org/struts/browse/STR-2959
> Project: Struts 1
> Issue Type: Bug
> Components: Core
> Affects Versions: 1.2.7, 1.2.8, 1.2.9, 1.3.5
> Environment: Websphere Application Server 6.0
> Reporter: Richard Harding
> Priority: Minor
> Fix For: 1.4.0
>
>
> Struts currently has a 2GB limit on file upload.
> org.apache.struts.upload has an artificial limit of 2GB.
> org.apache.commons.fileupload does not have this limit since 'long' is used in place of 'int'
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (STR-2959) File upload has 2GB limit
Posted by "Wendy Smoak (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/STR-2959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_41277 ]
Wendy Smoak commented on STR-2959:
----------------------------------
I'm not familiar with this issue, but echoing Niall's concerns, Struts has always followed a deprecate-release-remove cycle and if this does break compatiblity IMO there would have to be a really good (probably security related) reason to do it.
> File upload has 2GB limit
> -------------------------
>
> Key: STR-2959
> URL: https://issues.apache.org/struts/browse/STR-2959
> Project: Struts 1
> Issue Type: Bug
> Components: Core
> Affects Versions: 1.2.7, 1.2.8, 1.2.9, 1.3.5
> Environment: Websphere Application Server 6.0
> Reporter: Richard Harding
> Priority: Minor
> Fix For: 1.4.0
>
>
> Struts currently has a 2GB limit on file upload.
> org.apache.struts.upload has an artificial limit of 2GB.
> org.apache.commons.fileupload does not have this limit since 'long' is used in place of 'int'
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (STR-2959) File upload has 2GB limit
Posted by "Paul Benedict (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/STR-2959?page=comments#action_38913 ]
Paul Benedict commented on STR-2959:
------------------------------------
Isn't 2GB the upper limit of a signed integer, which is what Java uses?
> File upload has 2GB limit
> -------------------------
>
> Key: STR-2959
> URL: http://issues.apache.org/struts/browse/STR-2959
> Project: Struts 1
> Issue Type: Bug
> Components: Core
> Affects Versions: 1.3.5, 1.2.9, 1.2.8, 1.2.7
> Environment: Websphere Application Server 6.0
> Reporter: Richard Harding
> Priority: Minor
>
> Struts currently has a 2GB limit on file upload.
> org.apache.struts.upload has an artificial limit of 2GB.
> org.apache.commons.fileupload does not have this limit since 'long' is used in place of 'int'
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Reopened: (STR-2959) File upload has 2GB limit
Posted by "Paul Benedict (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/STR-2959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul Benedict reopened STR-2959:
--------------------------------
Assignee: Paul Benedict
I am re-opening the issue. Wendy, see my above comments. Because FormFile is an interface, any change to it breaks backwards compatibility. If we ever want to move above the 2GB limit, we have to add a new method or change the method signature. Deprecating an interface method is semi-worthless because it would have to be supplemented by another method for the user to implement. There's really no way around it except to break it. However, I find this change extremely minor and appropriate for an upgrade.
> File upload has 2GB limit
> -------------------------
>
> Key: STR-2959
> URL: https://issues.apache.org/struts/browse/STR-2959
> Project: Struts 1
> Issue Type: Bug
> Components: Core
> Affects Versions: 1.2.7, 1.2.8, 1.2.9, 1.3.5
> Environment: Websphere Application Server 6.0
> Reporter: Richard Harding
> Assignee: Paul Benedict
> Priority: Minor
> Fix For: 1.4.0
>
>
> Struts currently has a 2GB limit on file upload.
> org.apache.struts.upload has an artificial limit of 2GB.
> org.apache.commons.fileupload does not have this limit since 'long' is used in place of 'int'
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (STR-2959) File upload has 2GB limit
Posted by "Niall Pemberton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/STR-2959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_41246 ]
Niall Pemberton commented on STR-2959:
--------------------------------------
We have generally been pretty careful about backwards incompatible changes using deprecate/remove cycles giving users advance warning. I see no reason not to follow that approach in this case - i.e. Add a new method that returns a long and deprecate the old method. The answer to the question "why the original one still exists" should of course be in the deprecation message (i.e. use the new method). Changing the method signature will of course beg the question "why did you break compatibility with 1.3 without warning?"
> File upload has 2GB limit
> -------------------------
>
> Key: STR-2959
> URL: https://issues.apache.org/struts/browse/STR-2959
> Project: Struts 1
> Issue Type: Bug
> Components: Core
> Affects Versions: 1.2.7, 1.2.8, 1.2.9, 1.3.5
> Environment: Websphere Application Server 6.0
> Reporter: Richard Harding
> Priority: Minor
> Fix For: 1.4.0
>
>
> Struts currently has a 2GB limit on file upload.
> org.apache.struts.upload has an artificial limit of 2GB.
> org.apache.commons.fileupload does not have this limit since 'long' is used in place of 'int'
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (STR-2959) File upload has 2GB limit
Posted by "Paul Benedict (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/STR-2959?page=comments#action_38926 ]
Paul Benedict commented on STR-2959:
------------------------------------
You raise a great point. I'd like to see this changed too.
> File upload has 2GB limit
> -------------------------
>
> Key: STR-2959
> URL: http://issues.apache.org/struts/browse/STR-2959
> Project: Struts 1
> Issue Type: Bug
> Components: Core
> Affects Versions: 1.3.5, 1.2.9, 1.2.8, 1.2.7
> Environment: Websphere Application Server 6.0
> Reporter: Richard Harding
> Priority: Minor
>
> Struts currently has a 2GB limit on file upload.
> org.apache.struts.upload has an artificial limit of 2GB.
> org.apache.commons.fileupload does not have this limit since 'long' is used in place of 'int'
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (STR-2959) File upload has 2GB limit
Posted by "Niall Pemberton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/STR-2959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_41251 ]
Niall Pemberton commented on STR-2959:
--------------------------------------
Hmmm had forgotten this was an interface :( but I suspect in practice most people use the default CommonsFormFile implementation and wouldn't be affected. IMO theres no real difference breaking compatibility either by changing the method signature or adding a method for anyone implementing the FormFile interface. Whatever the solution though the issue still remains about breaking compatibility between versions.
At one point (2-3 years ago!) Martin was talking about enhancements to Commons FileUpload then would make the struts file upload features redundant - unfortunatley he moved on to pastures new without it coming to fruition. Anyway, from memory, there are a number of deficiencies in the file upload implementation (?multiple files with the same name, content encoding, and perhaps/probably more?) - each of which probably require at least breaking compatibility if not a new clean implementation. My question is - are we going to just address this deficiency or are others going to come along/be fixed in dribs and drabs? I would hate to see us repeatedly having this conversation. The best approach would be to review all the outstanding issues and consider them all togteher - but that sounds like a much bigger job and would need someone interested in working on it.
> File upload has 2GB limit
> -------------------------
>
> Key: STR-2959
> URL: https://issues.apache.org/struts/browse/STR-2959
> Project: Struts 1
> Issue Type: Bug
> Components: Core
> Affects Versions: 1.2.7, 1.2.8, 1.2.9, 1.3.5
> Environment: Websphere Application Server 6.0
> Reporter: Richard Harding
> Priority: Minor
> Fix For: 1.4.0
>
>
> Struts currently has a 2GB limit on file upload.
> org.apache.struts.upload has an artificial limit of 2GB.
> org.apache.commons.fileupload does not have this limit since 'long' is used in place of 'int'
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (STR-2959) File upload has 2GB limit
Posted by "Paul Benedict (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/STR-2959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul Benedict closed STR-2959.
------------------------------
Resolution: Fixed
> File upload has 2GB limit
> -------------------------
>
> Key: STR-2959
> URL: https://issues.apache.org/struts/browse/STR-2959
> Project: Struts 1
> Issue Type: Bug
> Components: Core
> Affects Versions: 1.2.7, 1.2.8, 1.2.9, 1.3.5
> Environment: Websphere Application Server 6.0
> Reporter: Richard Harding
> Priority: Minor
> Fix For: 1.4.0
>
>
> Struts currently has a 2GB limit on file upload.
> org.apache.struts.upload has an artificial limit of 2GB.
> org.apache.commons.fileupload does not have this limit since 'long' is used in place of 'int'
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (STR-2959) File upload has 2GB limit
Posted by "Paul Benedict (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/STR-2959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_41245 ]
Paul Benedict commented on STR-2959:
------------------------------------
I believe the signature should be changed. Adding a second method begs the question why the original one still exists, and what happens if you use it when the file is bigger than 2GB? 1.4 should be able to correct limitations of past versions. Niall, do you feel strongly about your viewpoint? Otherwise, I'd like to commit a change.
> File upload has 2GB limit
> -------------------------
>
> Key: STR-2959
> URL: https://issues.apache.org/struts/browse/STR-2959
> Project: Struts 1
> Issue Type: Bug
> Components: Core
> Affects Versions: 1.2.7, 1.2.8, 1.2.9, 1.3.5
> Environment: Websphere Application Server 6.0
> Reporter: Richard Harding
> Priority: Minor
> Fix For: 1.4.0
>
>
> Struts currently has a 2GB limit on file upload.
> org.apache.struts.upload has an artificial limit of 2GB.
> org.apache.commons.fileupload does not have this limit since 'long' is used in place of 'int'
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (STR-2959) File upload has 2GB limit
Posted by "Niall Pemberton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/STR-2959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_40574 ]
Niall Pemberton commented on STR-2959:
--------------------------------------
+1 to fixing in 1.4 but I would prefer we add new methods that sets/gets the size as a long and deprecate the existing ones - which would minimize the pain for the majority.
> File upload has 2GB limit
> -------------------------
>
> Key: STR-2959
> URL: https://issues.apache.org/struts/browse/STR-2959
> Project: Struts 1
> Issue Type: Bug
> Components: Core
> Affects Versions: 1.2.7, 1.2.8, 1.2.9, 1.3.5
> Environment: Websphere Application Server 6.0
> Reporter: Richard Harding
> Priority: Minor
> Fix For: 1.4.0
>
>
> Struts currently has a 2GB limit on file upload.
> org.apache.struts.upload has an artificial limit of 2GB.
> org.apache.commons.fileupload does not have this limit since 'long' is used in place of 'int'
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (STR-2959) File upload has 2GB limit
Posted by "Paul Benedict (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/STR-2959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_41248 ]
Paul Benedict commented on STR-2959:
------------------------------------
On second thoughts, I still think changing the signature is better. I have this difference of opinion because FormFile is an interface and any additional methods will require an implementation change. If this was a concrete subclass, simply adding a method would be transparent and pretty non-invasive. But in this case, I see the work of adding the method is worse than the work of changing the signature.
> File upload has 2GB limit
> -------------------------
>
> Key: STR-2959
> URL: https://issues.apache.org/struts/browse/STR-2959
> Project: Struts 1
> Issue Type: Bug
> Components: Core
> Affects Versions: 1.2.7, 1.2.8, 1.2.9, 1.3.5
> Environment: Websphere Application Server 6.0
> Reporter: Richard Harding
> Priority: Minor
> Fix For: 1.4.0
>
>
> Struts currently has a 2GB limit on file upload.
> org.apache.struts.upload has an artificial limit of 2GB.
> org.apache.commons.fileupload does not have this limit since 'long' is used in place of 'int'
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (STR-2959) File upload has 2GB limit
Posted by "Henri Yandell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/STR-2959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Henri Yandell updated STR-2959:
-------------------------------
Fix Version/s: 1.4.0
I'm presuming that this isn't something that would go in 1.3, but can go in 1.4? Seems like an easy fix once we can have an API change.
> File upload has 2GB limit
> -------------------------
>
> Key: STR-2959
> URL: https://issues.apache.org/struts/browse/STR-2959
> Project: Struts 1
> Issue Type: Bug
> Components: Core
> Affects Versions: 1.2.7, 1.2.8, 1.2.9, 1.3.5
> Environment: Websphere Application Server 6.0
> Reporter: Richard Harding
> Priority: Minor
> Fix For: 1.4.0
>
>
> Struts currently has a 2GB limit on file upload.
> org.apache.struts.upload has an artificial limit of 2GB.
> org.apache.commons.fileupload does not have this limit since 'long' is used in place of 'int'
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (STR-2959) File upload has 2GB limit
Posted by "Niall Pemberton (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/STR-2959?page=comments#action_38903 ]
Niall Pemberton commented on STR-2959:
--------------------------------------
Can you be specific - are you talking about the FormFile's getFileSize() method? Or was there somewhere else? I don't think this limits it to 2GB, just limits whether you can get the correct size of file
> File upload has 2GB limit
> -------------------------
>
> Key: STR-2959
> URL: http://issues.apache.org/struts/browse/STR-2959
> Project: Struts 1
> Issue Type: Bug
> Components: Core
> Affects Versions: 1.3.5, 1.2.9, 1.2.8, 1.2.7
> Environment: Websphere Application Server 6.0
> Reporter: Richard Harding
> Priority: Minor
>
> Struts currently has a 2GB limit on file upload.
> org.apache.struts.upload has an artificial limit of 2GB.
> org.apache.commons.fileupload does not have this limit since 'long' is used in place of 'int'
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira