You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/04/14 22:32:36 UTC

[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #36161: [SPARK-38870][SQL][PYSPARK] Make SparkSession.builder return new builder

dongjoon-hyun commented on code in PR #36161:
URL: https://github.com/apache/spark/pull/36161#discussion_r850855035


##########
python/pyspark/sql/session.py:
##########
@@ -104,6 +104,38 @@ def toDF(self, schema=None, sampleRatio=None):
     RDD.toDF = toDF  # type: ignore[assignment]
 
 
+# TODO: This method can be dropped once support for Python 3.8 is dropped

Review Comment:
   Could you make it as an IDed TODO, @FurcyPin ?
   For example, we recommend to use a pattern `TODO(SPARK-XXX)` with a concrete JIRA ID.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org