You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Michael Park <mc...@gmail.com> on 2015/06/22 07:59:53 UTC

Review Request 35722: Really removed from stout.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35722/
-----------------------------------------------------------

Review request for mesos, Benjamin Hindman and Till Toenshoff.


Bugs: MESOS-2662
    https://issues.apache.org/jira/browse/MESOS-2662


Repository: mesos


Description
-------

Turns out only the references to `<stout/memory.hpp>` were removed in [r33564](https://reviews.apache.org/r/33564/)


Diffs
-----

  3rdparty/libprocess/3rdparty/stout/include/stout/memory.hpp dfaef77fa1af857c13e5d8705505dd86f5108578 

Diff: https://reviews.apache.org/r/35722/diff/


Testing
-------

`make check`


Thanks,

Michael Park


Re: Review Request 35722: Really removed from stout.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35722/#review88741
-----------------------------------------------------------


Patch looks great!

Reviews applied: [35722]

All tests passed.

- Mesos ReviewBot


On June 22, 2015, 5:59 a.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35722/
> -----------------------------------------------------------
> 
> (Updated June 22, 2015, 5:59 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Till Toenshoff.
> 
> 
> Bugs: MESOS-2662
>     https://issues.apache.org/jira/browse/MESOS-2662
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Turns out only the references to `<stout/memory.hpp>` were removed in [r33564](https://reviews.apache.org/r/33564/)
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/memory.hpp dfaef77fa1af857c13e5d8705505dd86f5108578 
> 
> Diff: https://reviews.apache.org/r/35722/diff/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Re: Review Request 35722: Really removed from stout.

Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35722/#review88749
-----------------------------------------------------------

Ship it!


- Joerg Schad


On June 22, 2015, 5:59 a.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35722/
> -----------------------------------------------------------
> 
> (Updated June 22, 2015, 5:59 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Till Toenshoff.
> 
> 
> Bugs: MESOS-2662
>     https://issues.apache.org/jira/browse/MESOS-2662
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Turns out only the references to `<stout/memory.hpp>` were removed in [r33564](https://reviews.apache.org/r/33564/)
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/memory.hpp dfaef77fa1af857c13e5d8705505dd86f5108578 
> 
> Diff: https://reviews.apache.org/r/35722/diff/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Re: Review Request 35722: Really removed from stout.

Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35722/#review88785
-----------------------------------------------------------

Ship it!


Ship It!

- Till Toenshoff


On June 22, 2015, 5:59 a.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35722/
> -----------------------------------------------------------
> 
> (Updated June 22, 2015, 5:59 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Till Toenshoff.
> 
> 
> Bugs: MESOS-2662
>     https://issues.apache.org/jira/browse/MESOS-2662
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Turns out only the references to `<stout/memory.hpp>` were removed in [r33564](https://reviews.apache.org/r/33564/)
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/memory.hpp dfaef77fa1af857c13e5d8705505dd86f5108578 
> 
> Diff: https://reviews.apache.org/r/35722/diff/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Re: Review Request 35722: Really removed from stout.

Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35722/#review88752
-----------------------------------------------------------

Ship it!


Ship It!

- Alexander Rukletsov


On June 22, 2015, 5:59 a.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35722/
> -----------------------------------------------------------
> 
> (Updated June 22, 2015, 5:59 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Till Toenshoff.
> 
> 
> Bugs: MESOS-2662
>     https://issues.apache.org/jira/browse/MESOS-2662
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Turns out only the references to `<stout/memory.hpp>` were removed in [r33564](https://reviews.apache.org/r/33564/)
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/memory.hpp dfaef77fa1af857c13e5d8705505dd86f5108578 
> 
> Diff: https://reviews.apache.org/r/35722/diff/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Michael Park
> 
>