You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/08/18 12:27:39 UTC

[GitHub] [nifi] exceptionfactory commented on a diff in pull request #6281: NIFI-10312 - Fix MiNiFi C2 integration

exceptionfactory commented on code in PR #6281:
URL: https://github.com/apache/nifi/pull/6281#discussion_r949069069


##########
c2/c2-protocol/c2-protocol-api/pom.xml:
##########
@@ -33,5 +33,9 @@ limitations under the License.
             <artifactId>c2-protocol-component-api</artifactId>
             <version>1.18.0-SNAPSHOT</version>
         </dependency>
+        <dependency>
+            <groupId>com.fasterxml.jackson.core</groupId>

Review Comment:
   Concurring with @bejancsaba, although the Jackson annotations are convenient, the `c2-protocol-api` dependencies should be kept at a minimum, so writing a custom deserializer would be preferred in this particular case.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org