You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@helix.apache.org by Kanak Biscuitwala <ka...@apache.org> on 2014/05/29 00:39:13 UTC
Review Request 21993: [HELIX-448] Call onCallback for
CustomCodeCallbackHandler for FINALIZE
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21993/
-----------------------------------------------------------
Review request for helix, Zhen Zhang, Kishore Gopalakrishna, and Shi Lu.
Bugs: HELIX-448
Repository: helix-git
Description
-------
commit 3d8042266195290596866eb50c6752e46c2528f1
Author: Kanak Biscuitwala <ka...@apache.org>
Date: Wed May 28 15:37:48 2014 -0700
[HELIX-448] Call onCallback for CustomCodeCallbackHandler for FINALIZE
:100644 100644 04375f1... a736d71... M helix-core/src/main/java/org/apache/helix/participant/CustomCodeInvoker.java
:100644 100644 3223e48... b9097b3... M helix-core/src/test/java/org/apache/helix/integration/TestDisableCustomCodeRunner.java
Diffs
-----
helix-core/src/main/java/org/apache/helix/participant/CustomCodeInvoker.java 04375f1
helix-core/src/test/java/org/apache/helix/integration/TestDisableCustomCodeRunner.java 3223e48
Diff: https://reviews.apache.org/r/21993/diff/
Testing
-------
Added a check to an existing test, all tests pass locally.
Thanks,
Kanak Biscuitwala
Re: Review Request 21993: [HELIX-448] Call onCallback for
CustomCodeCallbackHandler for FINALIZE
Posted by Kishore Gopalakrishna <ki...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21993/#review44188
-----------------------------------------------------------
Ship it!
Ship It!
- Kishore Gopalakrishna
On May 28, 2014, 10:39 p.m., Kanak Biscuitwala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21993/
> -----------------------------------------------------------
>
> (Updated May 28, 2014, 10:39 p.m.)
>
>
> Review request for helix, Zhen Zhang, Kishore Gopalakrishna, and Shi Lu.
>
>
> Bugs: HELIX-448
>
>
> Repository: helix-git
>
>
> Description
> -------
>
> commit 3d8042266195290596866eb50c6752e46c2528f1
> Author: Kanak Biscuitwala <ka...@apache.org>
> Date: Wed May 28 15:37:48 2014 -0700
>
> [HELIX-448] Call onCallback for CustomCodeCallbackHandler for FINALIZE
>
> :100644 100644 04375f1... a736d71... M helix-core/src/main/java/org/apache/helix/participant/CustomCodeInvoker.java
> :100644 100644 3223e48... b9097b3... M helix-core/src/test/java/org/apache/helix/integration/TestDisableCustomCodeRunner.java
>
>
> Diffs
> -----
>
> helix-core/src/main/java/org/apache/helix/participant/CustomCodeInvoker.java 04375f1
> helix-core/src/test/java/org/apache/helix/integration/TestDisableCustomCodeRunner.java 3223e48
>
> Diff: https://reviews.apache.org/r/21993/diff/
>
>
> Testing
> -------
>
> Added a check to an existing test, all tests pass locally.
>
>
> Thanks,
>
> Kanak Biscuitwala
>
>