You are viewing a plain text version of this content. The canonical link for it is here.
Posted to bugs@httpd.apache.org by bu...@apache.org on 2016/05/25 01:06:31 UTC

[Bug 59630] New: Fix VC14 build of abs.exe

https://bz.apache.org/bugzilla/show_bug.cgi?id=59630

            Bug ID: 59630
           Summary: Fix VC14 build of abs.exe
           Product: Apache httpd-2
           Version: 2.4.20
          Hardware: PC
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Build
          Assignee: bugs@httpd.apache.org
          Reporter: phpdev@ehrhardt.nl

Created attachment 33886
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=33886&action=edit
patch for 2.4.x and trunk

Building abs.exe with VC14 fails with an error message
OPENSSL_Uplink(000007FEDF828000,08): no OPENSSL_Applink

More details: https://www.apachelounge.com/viewtopic.php?p=33450

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org

[Bug 59630] Fix VC14 build of abs.exe

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=59630

--- Comment #2 from Jan Ehrhardt <ph...@ehrhardt.nl> ---
@Steffen: the added lines are already inside a block with 

#if defined(HAVE_OPENSSL) 

That block starts at line 159 and ends just after the addition.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org

[Bug 59630] Fix VC14 build of abs.exe

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=59630

--- Comment #3 from Steffen <in...@apachelounge.com> ---
I see now, looks ok.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org

[Bug 59630] Fix VC14 build of abs.exe

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=59630

Gregg L. Smith <gl...@gknw.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #5 from Gregg L. Smith <gl...@gknw.net> ---
Committed to 2.4 r1748449

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org

[Bug 59630] Fix VC14 build of abs.exe

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=59630

--- Comment #4 from Gregg L. Smith <gl...@gknw.net> ---
Committed to trunk: r1745767
Proposed for 2.4: r1745768

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org

[Bug 59630] Fix VC14 build of abs.exe

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=59630

--- Comment #6 from William A. Rowe Jr. <wr...@apache.org> ---
Becomes available in 2.4.21 and later, also backported for 2.2.32, marking
resolved.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org

[Bug 59630] Fix VC14 build of abs.exe

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=59630

Steffen <in...@apachelounge.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 OS|                            |All

--- Comment #1 from Steffen <in...@apachelounge.com> ---

Jan_E, your proposed patch with abs is: 

+#if defined(_MSC_VER) && _MSC_VER >= 1900 
+#include <openssl/applink.c> 
+#endif 
+ 

So applink is included also for ab.exe and when you do not use OpenSSL (like
LibreSSL) 

So better to add condition: 

#if defined(HAVE_OPENSSL) 
#include <openssl/applink.c

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org