You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Hitesh Khamesra <hk...@pivotal.io> on 2016/08/23 16:25:52 UTC
Review Request 51340: Added vmkind field in InterbalDistributedMember'
wrtieEssentialData/readEssentialData method
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51340/
-----------------------------------------------------------
Review request for geode, Bruce Schuchardt and Udo Kohlmeyer.
Repository: geode
Description
-------
Fix for GEM-946
Diffs
-----
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/GMSMember.java b7754ce
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/JGroupsMessenger.java f43c98d
Diff: https://reviews.apache.org/r/51340/diff/
Testing
-------
Thanks,
Hitesh Khamesra
Re: Review Request 51340: Added vmkind field in
InterbalDistributedMember' wrtieEssentialData/readEssentialData method
Posted by Bruce Schuchardt <bs...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51340/#review146549
-----------------------------------------------------------
Wouldn't it be better to just set a VmKind in the ID created by JGroupsMessenger if it can't find a corresponding ID in the membership views? Either that or get rid of the assertion in InternalDistributedMember. Adding an extra byte to every message transmitted seems like a big price to pay just to avoid this assertion failure.
- Bruce Schuchardt
On Aug. 23, 2016, 4:25 p.m., Hitesh Khamesra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51340/
> -----------------------------------------------------------
>
> (Updated Aug. 23, 2016, 4:25 p.m.)
>
>
> Review request for geode, Bruce Schuchardt and Udo Kohlmeyer.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Fix for GEM-946
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/GMSMember.java b7754ce
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/JGroupsMessenger.java f43c98d
>
> Diff: https://reviews.apache.org/r/51340/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Hitesh Khamesra
>
>
Re: Review Request 51340: Added vmkind field in
InterbalDistributedMember' wrtieEssentialData/readEssentialData method
Posted by Hitesh Khamesra <hk...@pivotal.io>.
> On Aug. 23, 2016, 4:34 p.m., Bruce Schuchardt wrote:
> > You need to create an Apache JIRA ticket describing this problem.
Created GEODE-1812
- Hitesh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51340/#review146541
-----------------------------------------------------------
On Aug. 23, 2016, 4:25 p.m., Hitesh Khamesra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51340/
> -----------------------------------------------------------
>
> (Updated Aug. 23, 2016, 4:25 p.m.)
>
>
> Review request for geode, Bruce Schuchardt and Udo Kohlmeyer.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Fix for GEM-946
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/GMSMember.java b7754ce
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/JGroupsMessenger.java f43c98d
>
> Diff: https://reviews.apache.org/r/51340/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Hitesh Khamesra
>
>
Re: Review Request 51340: Added vmkind field in
InterbalDistributedMember' wrtieEssentialData/readEssentialData method
Posted by Bruce Schuchardt <bs...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51340/#review146541
-----------------------------------------------------------
You need to create an Apache JIRA ticket describing this problem.
- Bruce Schuchardt
On Aug. 23, 2016, 4:25 p.m., Hitesh Khamesra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51340/
> -----------------------------------------------------------
>
> (Updated Aug. 23, 2016, 4:25 p.m.)
>
>
> Review request for geode, Bruce Schuchardt and Udo Kohlmeyer.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Fix for GEM-946
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/GMSMember.java b7754ce
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/JGroupsMessenger.java f43c98d
>
> Diff: https://reviews.apache.org/r/51340/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Hitesh Khamesra
>
>