You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/03/18 07:41:43 UTC
[GitHub] [iceberg] openinx opened a new pull request #2349: Flink: Fix the manifest kryo serialization issue.
openinx opened a new pull request #2349:
URL: https://github.com/apache/iceberg/pull/2349
This fix the issue: https://github.com/apache/iceberg/issues/2346
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue merged pull request #2349: Flink: Fix the manifest kryo serialization issue.
Posted by GitBox <gi...@apache.org>.
rdblue merged pull request #2349:
URL: https://github.com/apache/iceberg/pull/2349
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] openinx commented on a change in pull request #2349: Flink: Fix the manifest kryo serialization issue.
Posted by GitBox <gi...@apache.org>.
openinx commented on a change in pull request #2349:
URL: https://github.com/apache/iceberg/pull/2349#discussion_r601017528
##########
File path: core/src/main/java/org/apache/iceberg/GenericManifestFile.java
##########
@@ -145,7 +145,12 @@ private GenericManifestFile(GenericManifestFile toCopy) {
this.existingRowsCount = toCopy.existingRowsCount;
this.deletedFilesCount = toCopy.deletedFilesCount;
this.deletedRowsCount = toCopy.deletedRowsCount;
- this.partitions = copyList(toCopy.partitions, PartitionFieldSummary::copy);
+ if (toCopy.partitions != null) {
+ this.partitions = copyList(toCopy.partitions(), PartitionFieldSummary::copy)
+ .toArray(new PartitionFieldSummary[0]);
Review comment:
I think you are saying that we don't have to convert the `partitions` array to a list then copy it again , and convert it back to `partitions` array in the end ( if use the `copyList` approach`).
Yes, I agree.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on a change in pull request #2349: Flink: Fix the manifest kryo serialization issue.
Posted by GitBox <gi...@apache.org>.
rdblue commented on a change in pull request #2349:
URL: https://github.com/apache/iceberg/pull/2349#discussion_r600824358
##########
File path: core/src/main/java/org/apache/iceberg/GenericManifestFile.java
##########
@@ -145,7 +145,12 @@ private GenericManifestFile(GenericManifestFile toCopy) {
this.existingRowsCount = toCopy.existingRowsCount;
this.deletedFilesCount = toCopy.deletedFilesCount;
this.deletedRowsCount = toCopy.deletedRowsCount;
- this.partitions = copyList(toCopy.partitions, PartitionFieldSummary::copy);
+ if (toCopy.partitions != null) {
+ this.partitions = copyList(toCopy.partitions(), PartitionFieldSummary::copy)
+ .toArray(new PartitionFieldSummary[0]);
Review comment:
Do we need to use `copyList`? What about using a Stream instead?
```java
Streams.of(toCopy.partitions).map(PartitionFieldSummary::copy).toArray(PartitionFieldSummary[]::new);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org