You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "Abacn (via GitHub)" <gi...@apache.org> on 2025/11/17 19:39:00 UTC
[PR] Fix inconsistent data type in GenericRecord and AvroSchema for AvroWriter [beam]
Abacn opened a new pull request, #36839:
URL: https://github.com/apache/beam/pull/36839
Fix #36735
**Please** add a meaningful description for your change here
* Fix inconsistent data type in GenericRecord and AvroSchema for AvroWriter
* Fixed PortableBigQueryDestinations not honoring avroschema attached to AvroWriteRequest, causing Avro Schema is inferred from Beam schema for every element.
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix inconsistent data type in GenericRecord and AvroSchema for AvroWriter [beam]
Posted by "gemini-code-assist[bot] (via GitHub)" <gi...@apache.org>.
gemini-code-assist[bot] commented on PR #36839:
URL: https://github.com/apache/beam/pull/36839#issuecomment-3543556312
## Summary of Changes
Hello @Abacn, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request resolves a critical data type inconsistency and performance issue within the Avro writing mechanism, particularly affecting PortableBigQueryDestinations. By ensuring that the AvroWriter correctly utilizes the provided Avro schema from AvroWriteRequest and implementing robust numeric type up-casting in AvroUtils, the changes prevent redundant schema inference and maintain data integrity during conversion from Beam Row to Avro GenericRecord. This ultimately leads to more reliable and efficient data serialization.
### Highlights
* **Avro Schema Honoring**: Fixed an issue in PortableBigQueryDestinations where the AvroWriter was not honoring the explicitly attached Avro schema in AvroWriteRequest, leading to inefficient schema inference per element.
* **Data Type Consistency**: Introduced logic in AvroUtils to handle implicit numeric type up-casting (e.g., int to long, float to double) when converting Beam Row values to Avro GenericRecord, ensuring consistency with the target Avro schema.
* **Enhanced Testing**: Updated BigQueryFileLoadsSchemaTransformProviderTest with a more comprehensive schema including a nullable INT32 field and corresponding test data to validate the schema handling improvements.
<details>
<summary><b>Using Gemini Code Assist</b></summary>
<br>
The full guide for Gemini Code Assist can be found on our [documentation page](https://developers.google.com/gemini-code-assist/docs/review-github-code), here are some quick tips.
<b>Invoking Gemini</b>
You can request assistance from Gemini at any point by creating a comment using either `/gemini <command>` or `@gemini-code-assist <command>`. Below is a summary of the supported commands on the current page.
Feature | Command | Description
--- | --- | ---
Code Review | `/gemini review` | Performs a code review for the current pull request in its current state.
Pull Request Summary | `/gemini summary` | Provides a summary of the current pull request in its current state.
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help | `/gemini help` | Displays a list of available commands.
<b>Customization</b>
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a `.gemini/` folder in the base of the repository. Detailed instructions can be found [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github).
<b>Limitations & Feedback</b>
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up [here](https://google.qualtrics.com/jfe/form/SV_2cyuGuTWsEw84yG).
<b>You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the [Gemini Code Assist IDE Extension](https://cloud.google.com/products/gemini/code-assist).</b>
</details>
[^1]: Review the [Privacy Notices](https://policies.google.com/privacy), [Generative AI Prohibited Use Policy](https://policies.google.com/terms/generative-ai/use-policy), [Terms of Service](https://policies.google.com/terms), and learn how to configure Gemini Code Assist in GitHub [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). Gemini can make mistakes, so double check it and [use code with caution](https://support.google.com/legal/answer/13505487).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix inconsistent data type in GenericRecord and AvroSchema for AvroWriter [beam]
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #36839:
URL: https://github.com/apache/beam/pull/36839#issuecomment-3543567849
R: @tarun-google @ahmedabu98
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix inconsistent data type in GenericRecord and AvroSchema for AvroWriter [beam]
Posted by "gemini-code-assist[bot] (via GitHub)" <gi...@apache.org>.
gemini-code-assist[bot] commented on code in PR #36839:
URL: https://github.com/apache/beam/pull/36839#discussion_r2535331609
##########
sdks/java/extensions/avro/src/main/java/org/apache/beam/sdk/extensions/avro/schemas/utils/AvroUtils.java:
##########
@@ -1214,6 +1214,16 @@ private static org.apache.avro.Schema getFieldSchema(
return fieldType.getNullable() ? ReflectData.makeNullable(baseType) : baseType;
}
+ private static final org.apache.avro.Schema INT_AVRO_TYPE =
+ org.apache.avro.Schema.create(Type.INT);
+ private static final org.apache.avro.Schema LONG_AVRO_TYPE =
+ org.apache.avro.Schema.create(Type.LONG);
+ private static final org.apache.avro.Schema FLOAT_AVRO_TYPE =
+ org.apache.avro.Schema.create(Type.FLOAT);
+ private static final org.apache.avro.Schema DOUBLE_AVRO_TYPE =
+ org.apache.avro.Schema.create(Type.DOUBLE);
Review Comment:
For improved maintainability and to reduce boilerplate, consider replacing these individual constants with a single static `Map` that maps Avro schemas to their corresponding numeric conversion functions. This would centralize the logic for numeric conversions and make it more extensible. You will need to import `java.util.function.Function`.
```suggestion
private static final java.util.Map<org.apache.avro.Schema, java.util.function.Function<Number, ? extends Number>> NUMERIC_CONVERTERS =
org.apache.beam.vendor.guava.v32_1_2_jre.com.google.common.collect.ImmutableMap.of(
org.apache.avro.Schema.create(Type.INT), Number::intValue,
org.apache.avro.Schema.create(Type.LONG), Number::longValue,
org.apache.avro.Schema.create(Type.FLOAT), Number::floatValue,
org.apache.avro.Schema.create(Type.DOUBLE), Number::doubleValue);
```
##########
sdks/java/extensions/avro/src/main/java/org/apache/beam/sdk/extensions/avro/schemas/utils/AvroUtils.java:
##########
@@ -1230,6 +1240,18 @@ private static org.apache.avro.Schema getFieldSchema(
return value;
}
+ // Handle implicit up-cast: use avroSchema
+ if (INT_AVRO_TYPE.equals(typeWithNullability.type)) {
+ return ((Number) value).intValue();
+ } else if (LONG_AVRO_TYPE.equals(typeWithNullability.type)) {
+ return ((Number) value).longValue();
+ } else if (FLOAT_AVRO_TYPE.equals(typeWithNullability.type)) {
+ return ((Number) value).floatValue();
+ } else if (DOUBLE_AVRO_TYPE.equals(typeWithNullability.type)) {
+ return ((Number) value).doubleValue();
+ }
Review Comment:
This `if-else if` chain can be simplified by using the `NUMERIC_CONVERTERS` map (as suggested in another comment). This makes the code more concise and easier to extend with new numeric types in the future.
```java
if (NUMERIC_CONVERTERS.containsKey(typeWithNullability.type)) {
return NUMERIC_CONVERTERS.get(typeWithNullability.type).apply((Number) value);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix inconsistent data type in GenericRecord and AvroSchema for AvroWriter [beam]
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #36839:
URL: https://github.com/apache/beam/pull/36839#issuecomment-3548862431
testCdcUsingHexSequenceNum (org.apache.beam.sdk.io.gcp.bigquery.StorageApiSinkRowUpdateIT) failed not related to the change. Test passed on previous commit. merging for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix inconsistent data type in GenericRecord and AvroSchema for AvroWriter [beam]
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #36839:
URL: https://github.com/apache/beam/pull/36839#issuecomment-3543577963
/gemini review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix inconsistent data type in GenericRecord and AvroSchema for AvroWriter [beam]
Posted by "tarun-google (via GitHub)" <gi...@apache.org>.
tarun-google commented on PR #36839:
URL: https://github.com/apache/beam/pull/36839#issuecomment-3545138528
LGTM, Thanks for fixing !!
see if we can incorporate both Gemini suggestions for clean code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix inconsistent data type in GenericRecord and AvroSchema for AvroWriter [beam]
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on code in PR #36839:
URL: https://github.com/apache/beam/pull/36839#discussion_r2535313955
##########
sdks/java/extensions/avro/src/main/java/org/apache/beam/sdk/extensions/avro/schemas/utils/AvroUtils.java:
##########
@@ -1230,6 +1240,18 @@ private static org.apache.avro.Schema getFieldSchema(
return value;
}
+ // Handle implicit up-cast: use avroSchema
+ if (INT_AVRO_TYPE.equals(typeWithNullability.type)) {
Review Comment:
This mirrors https://github.com/apache/avro/pull/737
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix inconsistent data type in GenericRecord and AvroSchema for AvroWriter [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36839:
URL: https://github.com/apache/beam/pull/36839#issuecomment-3543571060
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment `assign set of reviewers`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix inconsistent data type in GenericRecord and AvroSchema for AvroWriter [beam]
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn merged PR #36839:
URL: https://github.com/apache/beam/pull/36839
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org